From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 8E2001BA1A; Thu, 18 Sep 2025 19:05:45 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 10C651B987; Thu, 18 Sep 2025 19:05:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by atuin.qyliss.net (Postfix) with ESMTPS id AF8E11B984 for ; Thu, 18 Sep 2025 19:05:40 +0000 (UTC) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-71d6083cc69so13888667b3.2 for ; Thu, 18 Sep 2025 12:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758222338; x=1758827138; darn=spectrum-os.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=+p18FLRyb6U0laAuEpJ3YVypxNcZpzupsiwCocI1GuA=; b=AhYo7HPkmCSSYEArg/+9Dcxg3SDdFKF9eUYMxTOSzqDMQSXNXHb9D5Ifg6LA7p81Bw MUgoynqqOTQt+tM2ybjhpqpfdBF5gMwHSInFoCgXq/E4YtUFfR9/bMCRqVKJ/oz3RmNz WDWkNJLmIT2ypchs//L0cSJbQe3wf+ZDa9+DpnnBGJsDXveK3TXHcBO6lZ+2h21sl28S fwcNSGHFnngaPNvDF7q8j9z2lSACCegAt0Esm2wR9oiIquFlBXsB+l82i7LGHJFNbUyo uKeYdXEehFcopYm7/vsOnCO7nr47IRAi2zDJ6r4ory4AdNWAf4K7fkuVX3kN5q19AB/D 4e0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758222338; x=1758827138; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+p18FLRyb6U0laAuEpJ3YVypxNcZpzupsiwCocI1GuA=; b=AwoKXOZY00UxJMydSpLdqMAW/xrFsv/9IH6iddd07dO3MLUt6oUZE0TglEDu0t8dSQ wfOgmA6AeNoF2HwB0V6kh9eVpMDUPXEtN5pzUsZxy/VCR5ekSOrWAGpaJ5GU/Fd4gYVc /8PEaPR8/WfeQrcnd9BCRI1Hsp6LPKrwmXJnAjqNMv01ePmHbUgvo89y8Jtv0koK7DMg wpLkjDgp5DrgxZ/tZWU7tBGAZeCjAzaxPUd/D4fYNrVKYYUzRU5s+9P/uUeDTYT/tX6S pEJPWSeQQmOfSDXxF13AOnAE3qHNwwlG5W2Zm2GT8E2Jr1KNxNc0ezV0nQayvfYAbk+V 6EXw== X-Gm-Message-State: AOJu0Yx2aIqrCau4e2I6hdxcgCFf4BBJUGAA/LUmJVSKOLBOiRwuslwr /MBLY+VNC0xaExMjKs44xT/uzXWdgd0lSE/HDtofK92j8z5diEqpBhw0M9pJbw== X-Gm-Gg: ASbGncvbFgnWZgB5qyxX++IL0KoneBEl4jtWeklhDVyg0zb7QbFN25Ny6LSz2Wtu+T1 +/oygVHnnfDi/EKwl2gIFiLgAofPpp/5bSpPKLmtwQlu3n7wlVSz4Tnue8J7/Tj5sck801TUV+v pALa9mUFupr6SxNGI2tSVaH934aPEtGguyTHsDKkVhER3McImn/AOzPfFaTxJydc6NIRH6OdHJM WU+R/pjClM71YUm2i2RIsLCyR4Y1PlEu8CHGwB0+BZVI4iuVHz6knNGKNrCvYm/q5o/yoVYUy6M yxcu389yJarNs52nEJCl1awkzEm5x7XHtw738pAToCakmeGslJwKclVirxnYZBrpZVrnu1hL6dK XQaih/hiDhrHvTlJPo1n76o55+P3wSYRkVDieudbUqlvt9iA6YFKMPFH1xq9GXqFY2i5Ap3tEgs 47tAluR8sywN+5GaS4+sQT5ApjM20NfK6pRLpXBC1MRWeX8NToC7uE+cB4LtGGIQ== X-Google-Smtp-Source: AGHT+IEkJUMOT6s3Mehf/1bqgSBJGiGYpFXq4mYqSnM01nzL1kM56Aa64XeMi4gXGOCA9paN2yDuog== X-Received: by 2002:a05:690c:c92:b0:738:7494:452e with SMTP id 00721157ae682-73d3c016268mr4997567b3.34.1758222338335; Thu, 18 Sep 2025 12:05:38 -0700 (PDT) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-7397186dd11sm8733777b3.40.2025.09.18.12.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 12:05:37 -0700 (PDT) From: Demi Marie Obenour Date: Thu, 18 Sep 2025 15:03:35 -0400 Subject: [PATCH] tools/start-vmm: Don't disable improper_ctypes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250918-no-improper-ctypes-v1-1-20b17c8ef946@gmail.com> X-B4-Tracking: v=1; b=H4sIAIZXzGgC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1MDS0ML3bx83czcgqL8gtQi3eSSyoLUYl1zo6SUZEsDY/NUk1QloMaCotS 0zAqwodGxtbUAaUFZ8GQAAAA= X-Change-ID: 20250918-no-improper-ctypes-72bdc9037e4e To: Spectrum OS Development X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758222214; l=890; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=x07tc+NvqPCibVJKHvAplFPB75SjBMqao4R4pU6FsGc=; b=Ju0gZ8qI4Y7nEoEhmUM83OJun5n5/C5OYIXzSC07k5LadLqwme9NchtMyEUkKAcabJDe6cvo0 oDoTZDYkEs5A+yixJNW2yIKE1e5D5oSnOq8SUOOD14zrzAaaklyF64A X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: 3UJPOHI744F7TA4ZKPBCDI2NDIL2A764 X-Message-ID-Hash: 3UJPOHI744F7TA4ZKPBCDI2NDIL2A764 X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Alyssa Ross , Demi Marie Obenour X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The code didn't use improper ctypes. Signed-off-by: Demi Marie Obenour --- tools/start-vmm/net.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/start-vmm/net.rs b/tools/start-vmm/net.rs index c6f5ff1baf2ecedc099ac529e6dbf2711aaae385..1e4665ceb02c9a8899231a100e631f6ce425994d 100644 --- a/tools/start-vmm/net.rs +++ b/tools/start-vmm/net.rs @@ -42,7 +42,6 @@ extern "C" { /// The rest of the result is only valid if the returned fd is not -1. // SAFETY: &Path is sized, so it's okay to pass a reference to it // to C, as long as it's opaque to C. - #[allow(improper_ctypes)] pub fn net_setup(name: *const c_char, len: c_int) -> NetConfigC; } --- base-commit: edd53bb5dd9b682fec744d6df7921b64e0f56565 change-id: 20250918-no-improper-ctypes-72bdc9037e4e -- Sincerely, Demi Marie Obenour (she/her/hers)