From: Demi Marie Obenour <demiobenour@gmail.com>
To: Spectrum OS Development <devel@spectrum-os.org>
Cc: Demi Marie Obenour <demiobenour@gmail.com>, Alyssa Ross <hi@alyssa.is>
Subject: [PATCH v4 0/2] Fix build of forwarder, then improve it
Date: Tue, 21 Oct 2025 15:27:03 -0400 [thread overview]
Message-ID: <20251021-fix-forwarder-build-v4-0-b978718c004d@gmail.com> (raw)
In-Reply-To: <20251008-fix-forwarder-build-v3-1-705d1636d4f1@gmail.com>
The first patch fixes the build of the XDP forwarder and ensures it does
not include any libc headers. The second patch is a significant
cleanup and also should improve performance a tiny amount.
Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
---
Changes in v4:
- Use find_program instead of passing clang path as Meson option.
- Use path to Linux kernel package instead of path to include directory.
- Split the patch into two parts: a minimal one that just fixes the
build, and a bigger one that refactors the BPF programs.
- Link to v3: https://spectrum-os.org/lists/archives/spectrum-devel/20251008-fix-forwarder-build-v3-1-a93e5156fb6a@gmail.com
Changes in v3:
- Fix build.
- Clean up XDP programs.
- Link to v2: https://spectrum-os.org/lists/archives/spectrum-devel/20251006-fix-forwarder-build-v2-1-6fdd7e05cb14@gmail.com
Changes in v2:
- Rewrite the programs to not use the helpers.
- This doesn't build.
Link to v1: https://spectrum-os.org/lists/archives/spectrum-devel/20251003-fix-forwarder-build-v1-1-856b78ae5656@gmail.com
---
Demi Marie Obenour (2):
tools/xdp-forwarder: Do not include libc headers in eBPF programs
tools/xdp-forwarder: Simplify forwarder programs
tools/default.nix | 11 +-
tools/meson.options | 4 +
tools/xdp-forwarder/helpers.h | 54 +++++++
tools/xdp-forwarder/meson.build | 11 +-
tools/xdp-forwarder/parsing_helpers.h | 274 ----------------------------------
tools/xdp-forwarder/prog_physical.c | 52 ++++---
tools/xdp-forwarder/prog_router.c | 48 ++++--
tools/xdp-forwarder/rewrite_helpers.h | 146 ------------------
8 files changed, 138 insertions(+), 462 deletions(-)
---
base-commit: c5d5786d3dc938af0b279c542d1e43bce381b4b9
change-id: 20251003-fix-forwarder-build-2889ea9aec91
--
Sincerely,
Demi Marie Obenour (she/her/hers)
next parent reply other threads:[~2025-10-21 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251008-fix-forwarder-build-v3-1-705d1636d4f1@gmail.com>
2025-10-21 19:27 ` Demi Marie Obenour [this message]
2025-10-21 19:27 ` [PATCH v4 1/2] tools/xdp-forwarder: Do not include libc headers in eBPF programs Demi Marie Obenour
2025-10-24 20:35 ` Alyssa Ross
2025-10-21 19:27 ` [PATCH v4 2/2] tools/xdp-forwarder: Simplify forwarder programs Demi Marie Obenour
2025-10-25 11:17 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021-fix-forwarder-build-v4-0-b978718c004d@gmail.com \
--to=demiobenour@gmail.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).