From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 3762120E22; Tue, 21 Oct 2025 19:47:23 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id C5C3120DED; Tue, 21 Oct 2025 19:47:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by atuin.qyliss.net (Postfix) with ESMTPS id ECD6020DEA for ; Tue, 21 Oct 2025 19:47:17 +0000 (UTC) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-784a5f53e60so27151467b3.2 for ; Tue, 21 Oct 2025 12:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761076035; x=1761680835; darn=spectrum-os.org; h=cc:to:references:in-reply-to:content-transfer-encoding:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to; bh=xL+Y9WgHPijxg2b7J5b4Bbq02/6RTR7Ap/iPMyo0X7k=; b=I87A4cp2SbiH0dksTTa0mCrHhD01XBXBwR2dLAWHjfy/iT3JwZxvxMQCnQpvZCcFo3 oX21CjQ4B9dqBooLpJHudHW25rJtZ0cDqnTd84EyWY+Mgz8QIyOuMZ4YaNFbHpynri1H pe+U1iGhqZ3A4XtqtmYyr2f3xlf8w9ZjO3oxF1gehgUtLDAS0eiOcwsc6ZpHHuxISz9K y6GzLTbakk1UuUsSzyQDlJfA6hoUgm2+inW9LNbB5otsqelgy4cYFWYi8NYG+Wn0TwkC 1Ufua1TNDVEIRuCn006aLNHD4zc7A644DPFy2l8dDjmpUth22WpjGWNprhCkQBu7DfpK 86jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761076035; x=1761680835; h=cc:to:references:in-reply-to:content-transfer-encoding:mime-version :message-id:date:subject:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xL+Y9WgHPijxg2b7J5b4Bbq02/6RTR7Ap/iPMyo0X7k=; b=TGQYsCARwdIrMnjRbA2FUIIBQr/Z9QLMOAKXhjIX0/+n2aAtQfLJiwzdCw9fjPFF4r zZZNGPO9fhpD+JnLMolZw+IE3mYGzBT3SrMJaNWuKuWUlIgh7mbkX46k4yzJmL/gvk7Z SMBfkf9zlm55sEjhYjy+bKn8yH+Zpydzt42EYnjYRD96ANsmZq5lcFnVwK86Vk/4fvcN XAJMJjJpP8SRQNg7fEw6JMrL1m08RwEBGBP/EpjcSlElQXRJHK28Q0rYq+PRFbPDcvKg GgUq3roPeU0TRiovJ/56ovBRsks4/gJLoFM2MwGJ5tGxFDXyht+h9u1e5ukaAlyx+FhI PAiw== X-Gm-Message-State: AOJu0Yy6ZJqNCz0sccAn4vfJAGw86tcZ8kYB8tx0AyQeOckPgPyqydFs EJe248TKbPJo/ZLXdarePhTI4iH02TLx93pZt4vNbQ72IRhSlJe7eBCDewokirdy X-Gm-Gg: ASbGncs2/9Y0WqXLJ+kAasU0hrm9X3WMCe5rceh74L/xRa2o5Bx971f70x54GWRP9KR 6xGnCdvRLSiMxfRdNdXUravUcnCaN8djxymmNbhot4xmvStjLjxusunZs7dMoEk5q3UxXKGvI8u TTBacWyI5hseh8lYyZoXClNzWHF0ZSTQ4+g/EVQKvdP6LsX0WcQFjvuIFlq+nJXX9eifYyjQUJf ZmCH7BlR4gopPfoCI7C365Z49KdE2XO2WxxxbAmjYwGWsU4tfHbYBGvtN21XVVveEvwie69lJKo TCaQMg4u1H3skbbRh9PsBqHQMFDDmKRaaVNbW5eygFivUwS8CJTIenxPFE2obEbyneZ1XXJwh8B Wk5XckOXIjFettpKgNgn8ALS9gMqbrfAfP+3akJCQYfc7NSAplRkpOkSrzd8k+vQRZeF6Uky64a ypSrx7Pzfew5YGwl/fomKvCpAxmHtPp/3ejOoPO6tZ0qDuisgRmC6ImWnZHwjV63g/Qpdl40F2x Htw9DYjnc61Glfrkf7ETYur X-Google-Smtp-Source: AGHT+IFMEAdpki2tyU67IoK0+s2D9GqN5wEacVV38uELkalew5GyPcBhPpwKe7K7qRVB85yQx9OPtg== X-Received: by 2002:a05:690e:130e:b0:63e:30e1:1697 with SMTP id 956f58d0204a3-63e30e116damr7916963d50.31.1761076035395; Tue, 21 Oct 2025 12:47:15 -0700 (PDT) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-63e266bb40asm3438842d50.10.2025.10.21.12.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 12:47:14 -0700 (PDT) From: Demi Marie Obenour Subject: [PATCH v4 0/2] Fix build of forwarder, then improve it Date: Tue, 21 Oct 2025 15:27:03 -0400 Message-Id: <20251021-fix-forwarder-build-v4-0-b978718c004d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAIfe92gC/33NSw6CMBCA4auQrq3pg5biynsYF6UdoAlY02rVE O5uYUUMcflPZr6ZUITgIKJTMaEAyUXnbznKQ4FMr28dYGdzI0aYoIRw3Lo3bn146WAh4ObpBou ZUjXoWoOpKcqX9wB5bVUv19y9iw8fPuuTRJfpfy9RTLESsqmUBiGFPHejdsPR+BEtXmJbQ+4bL BuytbYCIkxDy1+Dbw21b/BsVERYKrm0ZUu3xjzPXz/ES0c+AQAA X-Change-ID: 20251003-fix-forwarder-build-2889ea9aec91 In-Reply-To: <20251008-fix-forwarder-build-v3-1-705d1636d4f1@gmail.com> References: <20251008-fix-forwarder-build-v3-1-705d1636d4f1@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761074823; l=1915; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=JGfNzLMExQHOtC4OnVn6eU8vtIF5q+ixsyfZE0xtsBQ=; b=VPl5pwFtl86Np4SekRhnnfSX9fIGt/THoO3t6AvMtQg755Z0tketwGoFLc2LLpmnZvIJ/8+dx OA74Pl8EeNOAQ+1jzDh/SXaIIXEWxaClFAHg362gbf6tS/9Y9icsR37 X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: ELR2TRROV4SAGTYTTJP7OGPWFJFTGLVJ X-Message-ID-Hash: ELR2TRROV4SAGTYTTJP7OGPWFJFTGLVJ X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The first patch fixes the build of the XDP forwarder and ensures it does not include any libc headers. The second patch is a significant cleanup and also should improve performance a tiny amount. Signed-off-by: Demi Marie Obenour --- Changes in v4: - Use find_program instead of passing clang path as Meson option. - Use path to Linux kernel package instead of path to include directory. - Split the patch into two parts: a minimal one that just fixes the build, and a bigger one that refactors the BPF programs. - Link to v3: https://spectrum-os.org/lists/archives/spectrum-devel/20251008-fix-forwarder-build-v3-1-a93e5156fb6a@gmail.com Changes in v3: - Fix build. - Clean up XDP programs. - Link to v2: https://spectrum-os.org/lists/archives/spectrum-devel/20251006-fix-forwarder-build-v2-1-6fdd7e05cb14@gmail.com Changes in v2: - Rewrite the programs to not use the helpers. - This doesn't build. Link to v1: https://spectrum-os.org/lists/archives/spectrum-devel/20251003-fix-forwarder-build-v1-1-856b78ae5656@gmail.com --- Demi Marie Obenour (2): tools/xdp-forwarder: Do not include libc headers in eBPF programs tools/xdp-forwarder: Simplify forwarder programs tools/default.nix | 11 +- tools/meson.options | 4 + tools/xdp-forwarder/helpers.h | 54 +++++++ tools/xdp-forwarder/meson.build | 11 +- tools/xdp-forwarder/parsing_helpers.h | 274 ---------------------------------- tools/xdp-forwarder/prog_physical.c | 52 ++++--- tools/xdp-forwarder/prog_router.c | 48 ++++-- tools/xdp-forwarder/rewrite_helpers.h | 146 ------------------ 8 files changed, 138 insertions(+), 462 deletions(-) --- base-commit: c5d5786d3dc938af0b279c542d1e43bce381b4b9 change-id: 20251003-fix-forwarder-build-2889ea9aec91 -- Sincerely, Demi Marie Obenour (she/her/hers)