patches and low-level development discussion
 help / color / mirror / code / Atom feed
* [PATCH] release/checks/integration: add nc timeout
@ 2025-10-31 11:13 Alyssa Ross
  2025-11-01  0:50 ` Demi Marie Obenour
  2025-11-02 12:44 ` Alyssa Ross
  0 siblings, 2 replies; 3+ messages in thread
From: Alyssa Ross @ 2025-10-31 11:13 UTC (permalink / raw)
  To: devel; +Cc: Demi Marie Obenour

I recently saw a transient timeout of this test.  Looking at the logs,
it seems like, before netvm was rebooted, nc was already running, and
that nc never failed, getting stuck.  Presumably, if it had failed,
another nc run would have connected successfully.  Avoid this by
setting a 2 second timeout for nc to ensure this eternal hang can't
happen.

Reported-by: Demi Marie Obenour <demiobenour@gmail.com>
Link: https://spectrum-os.org/lists/archives/spectrum-devel/f52c1aa7-96c0-462b-9287-0dbbae037e4f@gmail.com
Fixes: ae45978 ("release/checks/networking: init")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
 release/checks/integration/default.nix | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/release/checks/integration/default.nix b/release/checks/integration/default.nix
index 340fb6e..81db264 100644
--- a/release/checks/integration/default.nix
+++ b/release/checks/integration/default.nix
@@ -19,7 +19,7 @@ let
     type = "nix";
     run = writeShellScript "run" ''
       set -x
-      while :; do echo hello | ${libressl.nc}/bin/nc -N 10.0.2.2 1234; done
+      while :; do echo hello | ${libressl.nc}/bin/nc -Nw 2 10.0.2.2 1234; done
     '';
   };
 

base-commit: b1bb4e5050b09a8edcafc0cf1b1b9c9ab42832bc
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] release/checks/integration: add nc timeout
  2025-10-31 11:13 [PATCH] release/checks/integration: add nc timeout Alyssa Ross
@ 2025-11-01  0:50 ` Demi Marie Obenour
  2025-11-02 12:44 ` Alyssa Ross
  1 sibling, 0 replies; 3+ messages in thread
From: Demi Marie Obenour @ 2025-11-01  0:50 UTC (permalink / raw)
  To: Alyssa Ross, devel


[-- Attachment #1.1.1: Type: text/plain, Size: 1590 bytes --]

On 10/31/25 07:13, Alyssa Ross wrote:
> I recently saw a transient timeout of this test.  Looking at the logs,
> it seems like, before netvm was rebooted, nc was already running, and
> that nc never failed, getting stuck.  Presumably, if it had failed,
> another nc run would have connected successfully.  Avoid this by
> setting a 2 second timeout for nc to ensure this eternal hang can't
> happen.
> 
> Reported-by: Demi Marie Obenour <demiobenour@gmail.com>
> Link: https://spectrum-os.org/lists/archives/spectrum-devel/f52c1aa7-96c0-462b-9287-0dbbae037e4f@gmail.com
> Fixes: ae45978 ("release/checks/networking: init")
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
>  release/checks/integration/default.nix | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/release/checks/integration/default.nix b/release/checks/integration/default.nix
> index 340fb6e..81db264 100644
> --- a/release/checks/integration/default.nix
> +++ b/release/checks/integration/default.nix
> @@ -19,7 +19,7 @@ let
>      type = "nix";
>      run = writeShellScript "run" ''
>        set -x
> -      while :; do echo hello | ${libressl.nc}/bin/nc -N 10.0.2.2 1234; done
> +      while :; do echo hello | ${libressl.nc}/bin/nc -Nw 2 10.0.2.2 1234; done
>      '';
>    };
>  
> 
> base-commit: b1bb4e5050b09a8edcafc0cf1b1b9c9ab42832bc

That looks good to me.  I would have expected a TCP timeout, but I'm
not surprised it didn't happen.  nc might even explicitly disable
those unless a timeout is set.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] release/checks/integration: add nc timeout
  2025-10-31 11:13 [PATCH] release/checks/integration: add nc timeout Alyssa Ross
  2025-11-01  0:50 ` Demi Marie Obenour
@ 2025-11-02 12:44 ` Alyssa Ross
  1 sibling, 0 replies; 3+ messages in thread
From: Alyssa Ross @ 2025-11-02 12:44 UTC (permalink / raw)
  To: Alyssa Ross, devel; +Cc: Demi Marie Obenour

This patch has been committed as c61b297b493a948f5ea469c568bffc61bdd5b1f3,
which can be viewed online at
https://spectrum-os.org/git/spectrum/commit/?id=c61b297b493a948f5ea469c568bffc61bdd5b1f3.

This is an automated message.  Send comments/questions/requests to:
Alyssa Ross <hi@alyssa.is>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-02 12:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-31 11:13 [PATCH] release/checks/integration: add nc timeout Alyssa Ross
2025-11-01  0:50 ` Demi Marie Obenour
2025-11-02 12:44 ` Alyssa Ross

Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).