From: Demi Marie Obenour <demiobenour@gmail.com>
To: Spectrum OS Development <devel@spectrum-os.org>
Cc: Alyssa Ross <hi@alyssa.is>, Demi Marie Obenour <demiobenour@gmail.com>
Subject: [PATCH] img/app: Use set -euo pipefail for building the erofs
Date: Fri, 07 Nov 2025 22:14:10 -0500 [thread overview]
Message-ID: <20251107-pipefail-v1-1-68612cc47eab@gmail.com> (raw)
This caught problems when I was trying to filter the set of files to be
built.
Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
---
img/app/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/img/app/Makefile b/img/app/Makefile
index 981889ebe55d9ba03228977f3dc0ea3f26d5c4fb..48eba871339d314479f730101246ace3fa39e2db 100644
--- a/img/app/Makefile
+++ b/img/app/Makefile
@@ -46,6 +46,7 @@ build/empty:
mkdir -p $@
build/rootfs.erofs: ../../scripts/make-erofs.sh $(PACKAGES_FILE) $(FILES) $(BUILD_FILES) build/empty build/fifo file-list.mk
+ set -euo pipefail; \
{ \
cat $(PACKAGES_FILE) ;\
for file in $(FILES) $(LINKS); do printf '%s\n%s\n' $$file "$${file#image/}"; done ;\
---
base-commit: 22e216712322cdfb85094bbd27ff34c4366fad41
change-id: 20251107-pipefail-92dd75264707
--
Sincerely,
Demi Marie Obenour (she/her/hers)
next reply other threads:[~2025-11-08 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 3:14 Demi Marie Obenour [this message]
2025-11-09 11:17 ` [PATCH] img/app: Use set -euo pipefail for building the erofs Alyssa Ross
2025-11-09 18:58 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107-pipefail-v1-1-68612cc47eab@gmail.com \
--to=demiobenour@gmail.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).