From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E03FF1CCE1; Sat, 08 Nov 2025 03:43:31 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id B819A1CC9B; Sat, 08 Nov 2025 03:43:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yx1-xb136.google.com (mail-yx1-xb136.google.com [IPv6:2607:f8b0:4864:20::b136]) by atuin.qyliss.net (Postfix) with ESMTPS id 0B23C1CC95 for ; Sat, 08 Nov 2025 03:43:21 +0000 (UTC) Received: by mail-yx1-xb136.google.com with SMTP id 956f58d0204a3-63fc6115d65so1418275d50.0 for ; Fri, 07 Nov 2025 19:43:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762573399; x=1763178199; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=83rtRi7uGU9LaKNy00vR1Wd6+oBcJLTsqYjzrRcNZoQ=; b=h0XprbhZjik+OFhl4TyvTlZPPR3T6daRvO5JzLxN9n/uA50Us2YWN++1f2+TJxmRsf +EJdm1hJtltcE05IRRJbksXOhBLFGEp5zDazHLQ+Dc6h76nGXv2FikoojlRyCiq7kcf2 PodSlhG2EejYPCi+8TqZ0pTR/fgrXvRghHQkPlBP3GrxEnycb0cUxuTrwf7IqjiNqZzW myilq9pz8vQVT93SYO/jtlQCQl3JfNX5iqDfYnTPjSFvKnZ89n8ykeZ5rw7PXzXOlbHz qGMEUoXSo78DFD9uJ9lu1Sg4ONelfAhLylsvWJ2PIS5XhTZuGFh32zvUYjetEFaZNRon e7zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762573399; x=1763178199; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=83rtRi7uGU9LaKNy00vR1Wd6+oBcJLTsqYjzrRcNZoQ=; b=QbgdUOMW/63zFUW1pJIbv+zeM/ZG68jKkUz6xrluJAkK0ZmafSkfaAD+jAZ/JVzROO mnRW4uSN/IhfwgEbkg/GTWVFIyOCK6q0BLVe0H48sVpyxGZvDfrV2DWvhyLIxf0T9aiN lhRFDVqlZdDUQ35ftNo4c88wAQ5OFD039oOxvMrjQuWHUDqMO6y9UESjlfLgbWnEBqB7 XWgq2d/vCD0/iB1jKixmUnf+lCUDWeDJd2PzkzATkI3QwhkureeT4CggWDMMQzRYIh3i Tl4S8Y75MhFRldhZWydwNi7/+NZ0IPqrkFtGeGgOZlMTyZtEqDJpfCNqOWk4GYxx5eNp Z4bw== X-Gm-Message-State: AOJu0Yx7YT3CQchfICDwl/Hedh5WTK4RuzBEQBZMPkeI3m5hjavrPNN6 Y7yrgG/cPDoNWM6fO5/pXSMo6q0sctFoQ+WcYgPjPvm6RN/nHJm0exwzVD48sQ== X-Gm-Gg: ASbGnctubkDmEa4LZsS/ujbTaG9BC22yhRzT1FTsKrQUrtxtZIgkaX48igsI7FF4tg/ hJRK+g2cwRgrsy2UZs5kWBqe20GqT+7nOYa38u3OyIN6IL7/z2Ib+RYPf1lLQgBXEEwwAcGVJTJ 8d3TLdOKakLbC9KaiXIq3C3URRrxBYY4Cc2P+mzxN0gVmAA+5GXUkOxvDDZLg9J0tAiI+jTGjm3 Li6LMKKbpOmRh9/xj0A6oeJxjeprcJR59wfU4KsUhCOGdm36EPGVEXG9lmSV6hVpxrfC1o4OwOl z+LRDRU8Q//GdZ1N7D0nCCD0ZVL6LVa/SPRUADHFxXZvkXi2H0Y2X+OYMaMNTeVpOSRyjdET/BQ MeE+NGfpHHNZUexhA4b+d64GsdYx4ZSfRpOXmE9OWp6ygo+GPShdNkvnrsvgjBVDDSIzKChPdSd OKLtccoTpSSgHtjjVbeEuG13/2xGPNfAxHgXzAYQYr7rlug4zHHQcrIifVLAtf9VSN1gvNVEBO1 ROMcmyfPb5sPw81m8NYSWn1 X-Google-Smtp-Source: AGHT+IEkqi3oIR6rH/9ahzE5Z9jaOqpUQkDPy/gISpby9a8AxfRPpwvHf8NF6UBctRu9RfN8auNPfA== X-Received: by 2002:a05:690e:42d0:b0:63f:add1:e6da with SMTP id 956f58d0204a3-640d45d03b2mr840758d50.57.1762573399438; Fri, 07 Nov 2025 19:43:19 -0800 (PST) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-640d5231643sm286734d50.5.2025.11.07.19.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Nov 2025 19:43:18 -0800 (PST) From: Demi Marie Obenour Date: Fri, 07 Nov 2025 22:41:54 -0500 Subject: [PATCH 1/4] scripts/run-qemu.sh: better error checks & formatting MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251107-simple-sh-quote-fix-v1-1-5f2d35260c4d@gmail.com> References: <20251107-simple-sh-quote-fix-v1-0-5f2d35260c4d@gmail.com> In-Reply-To: <20251107-simple-sh-quote-fix-v1-0-5f2d35260c4d@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762573313; l=1517; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=Wui0vqGsLmCHpy+v9pQGmEtQCLGJsFha7I8czy0msMk=; b=747z+PTPuMDS3jQVIh5cPamMC4C3DMSfuu/B03w19EEArwNiXT7jRVMR153z43w2vdxiIHbe1 nGeOUPBIsFKBhQu5s7W5gknCcCTyIdHpvIITcGLxQj8Xrse8qyy+FsX X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: SQM3ARWTYY6YBLTUMJA2XTPM5KGIPTFK X-Message-ID-Hash: SQM3ARWTYY6YBLTUMJA2XTPM5KGIPTFK X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: No other functional change intended. Signed-off-by: Demi Marie Obenour --- scripts/run-qemu.sh | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/scripts/run-qemu.sh b/scripts/run-qemu.sh index 64fd29259ab108bc547cb7c74623ae9dc288b3b7..9c6c8193bbeba5916038c82d8f76992051719c19 100755 --- a/scripts/run-qemu.sh +++ b/scripts/run-qemu.sh @@ -1,11 +1,15 @@ -#!/bin/sh -ue +#!/bin/sh -- # SPDX-FileCopyrightText: 2023-2025 Alyssa Ross # SPDX-License-Identifier: EUPL-1.2+ # This script wraps around QEMU to paper over platform differences, # which can't be handled portably in Make language. +set -uef +if [ -n ${ARCH+test} ]; then + ARCH=$(uname -m) +fi -case "${ARCH:="$(uname -m)"}" in +case $ARCH in aarch64) machine=virt,accel=kvm:tcg,gic-version=3,iommu=smmuv3 ;; @@ -17,13 +21,13 @@ case "${ARCH:="$(uname -m)"}" in esac i=0 -while [ $i -lt $# ]; do - arg="$1" +while [ "$i" -lt "$#" ]; do + arg=$1 shift - case "$arg" in + case $arg in -append) - set -- "$@" -append "${append:+$append }$1" + set -- "$@" -append ${append:+"$append "}"$1" i=$((i + 2)) shift continue @@ -31,10 +35,10 @@ while [ $i -lt $# ]; do -device) IFS=, for opt in $1; do - case "$opt" in - *-iommu) - unset iommu - ;; + case $opt in + *-iommu) + unset iommu + ;; esac break done -- 2.51.2