From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 7017B1CC50; Sat, 08 Nov 2025 03:43:35 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 4656D1CCA6; Sat, 08 Nov 2025 03:43:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yx1-xb12a.google.com (mail-yx1-xb12a.google.com [IPv6:2607:f8b0:4864:20::b12a]) by atuin.qyliss.net (Postfix) with ESMTPS id 5DACB1CC9D for ; Sat, 08 Nov 2025 03:43:23 +0000 (UTC) Received: by mail-yx1-xb12a.google.com with SMTP id 956f58d0204a3-63e1e1bf882so1120480d50.1 for ; Fri, 07 Nov 2025 19:43:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762573402; x=1763178202; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DnBxYgxnsvermMD2jSleWTuPW7MHMEhOR9EF2cyBrzg=; b=XyfjdnPGKr11MvKu2FsFIkbdUCFqgPKDI//c9J1SsaMHZYYmXaAeZ6ppik2f0nshe1 weSJu9MF9y7UjOfTyAjmr+lthLMrtpjfsvy1arD+lwsiAW2/V8F/g8EODXqjQpVAAEDS Z1a31aaKCKP39+gTi40tISy4g9C9vaUpS0tlOoS5uGWqau2f9Q6bS+GAjLFwnd1oztCn Vlby3cS33m4BqnZVLAJ6ThgUmfYAF91UIy5E0draTQ/kGH3SUEsdMvU+oRr2vGCjrejB FgXox7rmGSPo1tgKPfEvqi/nJcxeyc3sv8vWfSVP9wTu9aNkPtfRyE9TAVvVBkO/+rFx We2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762573402; x=1763178202; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DnBxYgxnsvermMD2jSleWTuPW7MHMEhOR9EF2cyBrzg=; b=lzooawxxqt7Mk9l39lm0BVcmsLJqEirPoeIGltxOHDnu2HFHRezYRABaBDgueskjhf ZR2fE1uSA5NgF4Ny1FHLLw5Y3jC3c5SPyRXdQskdFxoc+Sol7nn8gfUu237vHYCL+OAq xNnz3hO/Gjj84o0O8d3DdmYUqqo94DuPszo4SwC7f9dDy9j3W7h20BaItbOd/RNr4E1Y 3vDic9LhlUDg8nBJLxwXo4BvD6jOzW15r7FQ65bri6AQvXz2MByP9JkMO3tfdSpBMT6z cUpMM7mZFD68crQwgTmeoX556t5cgqBaa0HwcYFiciKUQ3VxWshP6bb7TwyO8GHhhDPa bepg== X-Gm-Message-State: AOJu0YwMelv6jRKGCBlzUo5NvC6E3sRfwnEbQgDIvWd07875Mc4JfFE1 jXqW8cgMwhGMooBGicKLBmOd13ty7p6v8NyJVpuI0zN3lQSHnHyDd1VXk5g5cw== X-Gm-Gg: ASbGncvYsnIR7dUNUT6XxNEHbYXzuwfIYAjt1nklOPIkcghgKMyCN6WSFxWXJOvep5k OFSXKcJ78KJCPeNpC1BfVSy/EOzv5XDpieM0EkFURNdiZ1uvKitAw8eqFKpN/LKd13I95ifXr3G wxEcLAiUb9lCOzSjWQOsQutR2ugvCJW3MM4KOOOs7sE2P6SXfn5NB+aFXwYqYjKj1XNafzbC10t +j0fBW7HP+1d+B2QmiHCvVvR2+UhlwrZflIPge6NnxffdXzHuN+ssAVy6RcSdoajYZJoSZtqUTh iIzNlaAstGB+yt0RQdV06UU5IBtxZxE3BgFNOSgjRWy42juE1DVy+DYocrw8rz3zTPQHIdUDXlX GFzNrJ8BLfwc1ffpTijWNHEUfsc8RWsAiqVZfQnYArTcKtTz66VFL3rar/QtJ+/pfXEtx7CixGX u9O4Jqo9QQCp5iGmnRneC/xRlnKKXz8e7jEHbOmUFukpWbQzwqmm+i12NfMqcjdmchzTXUDeiV1 u0eIpCft0iywLqnjXQUGKomrsrv9EJ/5KU= X-Google-Smtp-Source: AGHT+IHNCOgOkp1hQAHnaAT4v7cn+uRawTI6Dfh+EyuzWf8pyorlqTwlKflbGb9QGzkYNkdrZ7FVBA== X-Received: by 2002:a05:690c:6e0e:b0:786:91ac:e15b with SMTP id 00721157ae682-787d5391755mr24789927b3.23.1762573401817; Fri, 07 Nov 2025 19:43:21 -0800 (PST) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-640cffc140asm825664d50.25.2025.11.07.19.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Nov 2025 19:43:20 -0800 (PST) From: Demi Marie Obenour Date: Fri, 07 Nov 2025 22:41:55 -0500 Subject: [PATCH 2/4] scripts/run-qemu.sh: decrease indentation MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251107-simple-sh-quote-fix-v1-2-5f2d35260c4d@gmail.com> References: <20251107-simple-sh-quote-fix-v1-0-5f2d35260c4d@gmail.com> In-Reply-To: <20251107-simple-sh-quote-fix-v1-0-5f2d35260c4d@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762573313; l=2614; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=RyFkZOphWAIXT8g2vScJ/OIwbKWVKhpsHwcy/4Pkx+I=; b=M4vJUnJ8Gn0/Liw8HDrwub30eL4Aqqz0wBYt0cSdCOqnh+3WzW2T5QS4cyTg5eOa8pCHhFjNX Fvd2ZFHUt9PBKT5KAhnFYt7hE5csEVgX44jEtft7FOxYDcC2+TtOltl X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: 7ZKTMMMKXB2SUURA4OWJCUECSR2UZRNH X-Message-ID-Hash: 7ZKTMMMKXB2SUURA4OWJCUECSR2UZRNH X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The rightward drift made the code harder to read. No functional change. Signed-off-by: Demi Marie Obenour --- scripts/run-qemu.sh | 106 ++++++++++++++++++++++++++-------------------------- 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/scripts/run-qemu.sh b/scripts/run-qemu.sh index 9c6c8193bbeba5916038c82d8f76992051719c19..ab324d8fda0810516cb2180d1372bbeb546f52bc 100755 --- a/scripts/run-qemu.sh +++ b/scripts/run-qemu.sh @@ -10,14 +10,14 @@ if [ -n ${ARCH+test} ]; then fi case $ARCH in - aarch64) - machine=virt,accel=kvm:tcg,gic-version=3,iommu=smmuv3 - ;; - x86_64) - append="console=ttyS0${append:+ $append}" - iommu=intel-iommu,intremap=on - machine=q35,accel=kvm:tcg,kernel-irqchip=split - ;; +aarch64) + machine=virt,accel=kvm:tcg,gic-version=3,iommu=smmuv3 + ;; +x86_64) + append="console=ttyS0${append:+ $append}" + iommu=intel-iommu,intremap=on + machine=q35,accel=kvm:tcg,kernel-irqchip=split + ;; esac i=0 @@ -26,49 +26,49 @@ while [ "$i" -lt "$#" ]; do shift case $arg in - -append) - set -- "$@" -append ${append:+"$append "}"$1" - i=$((i + 2)) - shift - continue - ;; - -device) - IFS=, - for opt in $1; do - case $opt in - *-iommu) - unset iommu - ;; - esac - break - done - unset IFS - ;; - -machine) - set -- "$@" "$arg" - i=$((i + 1)) - arg= + -append) + set -- "$@" -append ${append:+"$append "}"$1" + i=$((i + 2)) + shift + continue + ;; + -device) + IFS=, + for opt in $1; do + case $opt in + *-iommu) + unset iommu + ;; + esac + break + done + unset IFS + ;; + -machine) + set -- "$@" "$arg" + i=$((i + 1)) + arg= - IFS=, - for opt in $1; do - case "$opt" in - virtualization=on) - case "$ARCH" in - aarch64) - opt="$opt,accel=tcg" - ;; - *) - continue - ;; - esac - ;; + IFS=, + for opt in $1; do + case "$opt" in + virtualization=on) + case "$ARCH" in + aarch64) + opt="$opt,accel=tcg" + ;; + *) + continue + ;; esac + ;; + esac - arg="$arg${arg:+,}$opt" - done - unset IFS + arg="$arg${arg:+,}$opt" + done + unset IFS - shift + shift esac set -- "$@" "$arg" @@ -78,12 +78,12 @@ done for arg; do case "$arg" in - -append) - append= - ;; - -kernel) - kernel=1 - ;; + -append) + append= + ;; + -kernel) + kernel=1 + ;; esac done -- 2.51.2