patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Spectrum OS Development <devel@spectrum-os.org>
Cc: Demi Marie Obenour <demiobenour@gmail.com>, Alyssa Ross <hi@alyssa.is>
Subject: [PATCH 4/4] scripts/run-qemu.sh: Unset variables from the environment
Date: Fri, 07 Nov 2025 22:41:57 -0500	[thread overview]
Message-ID: <20251107-simple-sh-quote-fix-v1-4-5f2d35260c4d@gmail.com> (raw)
In-Reply-To: <20251107-simple-sh-quote-fix-v1-0-5f2d35260c4d@gmail.com>

These could affect the script.

Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
---
 scripts/run-qemu.sh | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/run-qemu.sh b/scripts/run-qemu.sh
index 14c58729dfceb3a0d2566fcfe076d6c10433419f..ba32467956a509b1744ade461f2fe5f20ae7a5b9 100755
--- a/scripts/run-qemu.sh
+++ b/scripts/run-qemu.sh
@@ -9,12 +9,15 @@ if [ -n ${ARCH+test} ]; then
 	ARCH=$(uname -m)
 fi
 
+unset kernel
+
 case $ARCH in
 aarch64)
 	machine=virt,accel=kvm:tcg,gic-version=3,iommu=smmuv3
+	unset iommu append
 	;;
 x86_64)
-	append="console=ttyS0${append:+ $append}"
+	append=console=ttyS0
 	iommu=intel-iommu,intremap=on
 	machine=q35,accel=kvm:tcg,kernel-irqchip=split
 	;;
@@ -79,7 +82,7 @@ done
 for arg; do
 	case "$arg" in
 	-append)
-		append=
+		unset append
 		;;
 	-kernel)
 		kernel=1

-- 
2.51.2


  parent reply	other threads:[~2025-11-08  3:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-08  3:41 [PATCH 0/4] Minor improvements to scripts/run-qemu.sh Demi Marie Obenour
2025-11-08  3:41 ` [PATCH 1/4] scripts/run-qemu.sh: better error checks & formatting Demi Marie Obenour
2025-11-09 11:28   ` Alyssa Ross
2025-11-13 12:23   ` Alyssa Ross
2025-11-13 15:36     ` Demi Marie Obenour
2025-11-13 16:56       ` Alyssa Ross
2025-11-13 19:29         ` Demi Marie Obenour
2025-11-08  3:41 ` [PATCH 2/4] scripts/run-qemu.sh: decrease indentation Demi Marie Obenour
2025-11-08  3:41 ` [PATCH 3/4] scripts/run-qemu.sh: Preserve ,, in QEMU arguments Demi Marie Obenour
2025-11-13 12:28   ` Alyssa Ross
2025-11-13 15:36     ` Demi Marie Obenour
2025-11-13 19:30     ` Demi Marie Obenour
2025-11-08  3:41 ` Demi Marie Obenour [this message]
2025-11-13 12:27   ` [PATCH 4/4] scripts/run-qemu.sh: Unset variables from the environment Alyssa Ross
2025-11-13 19:30     ` Demi Marie Obenour
2025-11-14 11:22   ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251107-simple-sh-quote-fix-v1-4-5f2d35260c4d@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).