* [PATCH] img/app: Use set -euo pipefail for building the erofs
@ 2025-11-08 3:14 Demi Marie Obenour
2025-11-09 11:17 ` Alyssa Ross
2025-11-09 18:58 ` Alyssa Ross
0 siblings, 2 replies; 3+ messages in thread
From: Demi Marie Obenour @ 2025-11-08 3:14 UTC (permalink / raw)
To: Spectrum OS Development; +Cc: Alyssa Ross, Demi Marie Obenour
This caught problems when I was trying to filter the set of files to be
built.
Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
---
img/app/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/img/app/Makefile b/img/app/Makefile
index 981889ebe55d9ba03228977f3dc0ea3f26d5c4fb..48eba871339d314479f730101246ace3fa39e2db 100644
--- a/img/app/Makefile
+++ b/img/app/Makefile
@@ -46,6 +46,7 @@ build/empty:
mkdir -p $@
build/rootfs.erofs: ../../scripts/make-erofs.sh $(PACKAGES_FILE) $(FILES) $(BUILD_FILES) build/empty build/fifo file-list.mk
+ set -euo pipefail; \
{ \
cat $(PACKAGES_FILE) ;\
for file in $(FILES) $(LINKS); do printf '%s\n%s\n' $$file "$${file#image/}"; done ;\
---
base-commit: 22e216712322cdfb85094bbd27ff34c4366fad41
change-id: 20251107-pipefail-92dd75264707
--
Sincerely,
Demi Marie Obenour (she/her/hers)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] img/app: Use set -euo pipefail for building the erofs
2025-11-08 3:14 [PATCH] img/app: Use set -euo pipefail for building the erofs Demi Marie Obenour
@ 2025-11-09 11:17 ` Alyssa Ross
2025-11-09 18:58 ` Alyssa Ross
1 sibling, 0 replies; 3+ messages in thread
From: Alyssa Ross @ 2025-11-09 11:17 UTC (permalink / raw)
To: Demi Marie Obenour; +Cc: Spectrum OS Development
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
Demi Marie Obenour <demiobenour@gmail.com> writes:
> This caught problems when I was trying to filter the set of files to be
> built.
>
> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
Makes sense, but I'll also make the same change in host/rootfs and
vm/sys/net.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] img/app: Use set -euo pipefail for building the erofs
2025-11-08 3:14 [PATCH] img/app: Use set -euo pipefail for building the erofs Demi Marie Obenour
2025-11-09 11:17 ` Alyssa Ross
@ 2025-11-09 18:58 ` Alyssa Ross
1 sibling, 0 replies; 3+ messages in thread
From: Alyssa Ross @ 2025-11-09 18:58 UTC (permalink / raw)
To: Demi Marie Obenour, Spectrum OS Development
Cc: Alyssa Ross, Demi Marie Obenour
This patch has been committed as 7f90dafab8e8b8a4f43cc95934ce49b31111a5a2,
which can be viewed online at
https://spectrum-os.org/git/spectrum/commit/?id=7f90dafab8e8b8a4f43cc95934ce49b31111a5a2.
This is an automated message. Send comments/questions/requests to:
Alyssa Ross <hi@alyssa.is>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-09 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-08 3:14 [PATCH] img/app: Use set -euo pipefail for building the erofs Demi Marie Obenour
2025-11-09 11:17 ` Alyssa Ross
2025-11-09 18:58 ` Alyssa Ross
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).