From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 45D371F253; Thu, 13 Nov 2025 13:27:09 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 3ADC91F233; Thu, 13 Nov 2025 13:27:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by atuin.qyliss.net (Postfix) with ESMTPS id BACB11F22F for ; Thu, 13 Nov 2025 13:27:03 +0000 (UTC) Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id 832D0EC00A1 for ; Thu, 13 Nov 2025 08:27:02 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Thu, 13 Nov 2025 08:27:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1763040422; x= 1763126822; bh=swfR/z87HET0djskoFaNGFstBvxWmVAxJZizSsdx1kE=; b=R TPmu2g4FwwIfWrPXeBgZgprHcy4RgpD13SihPjpNS6H9IvCAiPczGF7aJ+ReDHrC b7BYphfjkeL6fwTochZaAWDunh3qw2nstkBfS9QSIh8nrhJLPbOBVbXyTVPPy05h Mf1KToxOigTW28uVdbAzUN4lq1PRSNfEKsrPPbGill/FBlWgHj4h/Mh0oOrrWgXu Oeobp4MdzGeLL6s80ae0vK6GEEJQfMHX2M5dzBTFgYUKYt3FPKWPrD8UANyj3hMV Bb2Q1xYIz0kGfiIZ3CbhipZV8ndlxK+jO/t3nSHoh6Q/ripDxyyHJbnJmPkHRubv uQ2W9D4tyURw3qCHmKLQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1763040422; x=1763126822; bh=swfR/z87HET0djskoFaNGFstBvxW mVAxJZizSsdx1kE=; b=sJ8NggPXjjp5V5XnKpNOcSNW8AnSVFMI+Bvm3zrzoCNP dmH1Eizl9rqB4xGEhZLcETSC9BRQe0Rt0ne+3k4nHO3JO6ll1VGvwtSbVUbVooSr pp/pyI3wh9ShnYBCNHLT4XDt+lyR0SvIbo6ohWlRTfCYFf5a+akoS0fUq92yAu3j YcGXqLrTzQjX7LPr/bufmTi3nwCeludyS1nKO05/5pUU72h22gP2ZNUEWs8mLkEL btSRl61G7om/o+ws4oZbbOJh6aHMFblOZmkcx6yKqkK2WwlOsEP8eersruAOxHYe Br4p/C8yIB0hcqjCsO4OJSDt1gpX5fyfeDyrWC95dw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdejtdehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtre dttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhisheq necuggftrfgrthhtvghrnhepgfefudekvdelieelledufeevheeglefggedvudejvddtff euueevffehleejkedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprhgtphhtthhopedupdhmohguvg epshhmthhpohhuthdprhgtphhtthhopeguvghvvghlsehsphgvtghtrhhumhdqohhsrdho rhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 13 Nov 2025 08:27:02 -0500 (EST) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 34AF5139C958; Thu, 13 Nov 2025 14:27:01 +0100 (CET) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH 3/5] Don't create/chmod device nodes in generic rules Date: Thu, 13 Nov 2025 14:26:40 +0100 Message-ID: <20251113132642.92899-3-hi@alyssa.is> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251113132642.92899-1-hi@alyssa.is> References: <20251113132642.92899-1-hi@alyssa.is> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: KRKOO6ONTJX27C2WACSDG27XLC5PMEA5 X-Message-ID-Hash: KRKOO6ONTJX27C2WACSDG27XLC5PMEA5 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: These rules shouldn't be making any changes to device nodes. (Although this is mostly hypothetical since I didn't find any devices with MODALIAS uevent keys and device nodes.) Fixes: 88f2695 ("Initial commit") Fixes: aeb5104 ("Initial commit") Signed-off-by: Alyssa Ross --- img/app/image/etc/mdev.conf | 2 +- vm/sys/net/image/etc/mdev.conf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/img/app/image/etc/mdev.conf b/img/app/image/etc/mdev.conf index 30e17e6..7382067 100644 --- a/img/app/image/etc/mdev.conf +++ b/img/app/image/etc/mdev.conf @@ -1,7 +1,7 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2021-2023 Alyssa Ross --$MODALIAS=.* 0:0 660 +importas -Siu MODALIAS modprobe -q $MODALIAS +-$MODALIAS=.* 0:0 0 ! +importas -Siu MODALIAS modprobe -q $MODALIAS $INTERFACE=.* 0:0 0 ! +/etc/mdev/iface $MODALIAS=virtio:d0000001Av.* 0:0 0 ! +/etc/mdev/virtiofs dri/card0 0:0 660 +background { /etc/mdev/listen card0 } diff --git a/vm/sys/net/image/etc/mdev.conf b/vm/sys/net/image/etc/mdev.conf index 15f2d01..412f7f5 100644 --- a/vm/sys/net/image/etc/mdev.conf +++ b/vm/sys/net/image/etc/mdev.conf @@ -1,5 +1,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2021 Alyssa Ross --$MODALIAS=.* 0:0 660 +importas -Siu MODALIAS modprobe -q $MODALIAS +-$MODALIAS=.* 0:0 0 ! +importas -Siu MODALIAS modprobe -q $MODALIAS $INTERFACE=.* 0:0 0 ! +/etc/mdev/iface -- 2.51.0