From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 311CB1F2F1; Thu, 13 Nov 2025 13:27:18 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 38CBB1F247; Thu, 13 Nov 2025 13:27:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by atuin.qyliss.net (Postfix) with ESMTPS id D7B671F231 for ; Thu, 13 Nov 2025 13:27:03 +0000 (UTC) Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id 6FAE3EC009B for ; Thu, 13 Nov 2025 08:27:02 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Thu, 13 Nov 2025 08:27:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1763040422; x= 1763126822; bh=XXf6RCfRHgXNoVJU1E4gjZsvvmoVnunPBrjWGfLC7o4=; b=S Psf14Pa9qHhNAmgAoK1rYnlNpHwJs0cp/fiVkN67LaX+Qg1dlgMGgavg4dwScKZB 8IBAYnzGNQ7DrHmXcJv2knOjmjI9Qp1rA4JgvJ4U9Z7fV9U6mZ6WPOGnKHF2wD5s yF8o+XAvcs86UQNKrTKgaL1RR1CVY4bee7Q1sJWx+vJV1tiOW3wnIVKuKSa5kmSm vxu3haRTzXqgRLkQTkvzVyGHvv/E6pQ/LJqqPtw4jYEytm1+m7HO+v7RJZWu0Hnr YiPc/nveXjEUc6FmaQzeQtjXts0pl0r5W0BlSI2i8k0Romfp1OD+miCv0hkBJD91 ogxA7XSkwc9JXom5osCuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1763040422; x=1763126822; bh=XXf6RCfRHgXNoVJU1E4gjZsvvmoV nunPBrjWGfLC7o4=; b=JMJrSLPr9+10kJldMaROeHsnNXqhJhOvZLD38QoNvh6k c39vyVxGXw9LW4Tp4cj4KruMTsKyEsT5iwAsrgn7e/TnxhVoy1jeOBUk07WFXX9l ZGfMk5rLXh5O/WTJzCaScrYWBEbCOO3D8Kcqk8Zv5/v9ttoZ4Lp10tUSt0O3wePw 7UpiiUFH5IX2jq3I3bnEnitYFJ+CeUnV7AROxrJXaVKSBKYfq6XDTRlUEbPLpa9e MX5ctdjFSc3SNqzEtgoYsxL3TXDBaIYDzQokuOyM1f10iuWojspSHT6RWa9F1bKh kddae2Wn8NQnDHq/m1MX9FXBdwJJAiBxtVRC/VF+RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdejtdeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekredtre dttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhisheq necuggftrfgrthhtvghrnhepgfefudekvdelieelledufeevheeglefggedvudejvddtff euueevffehleejkedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprhgtphhtthhopedupdhmohguvg epshhmthhpohhuthdprhgtphhtthhopeguvghvvghlsehsphgvtghtrhhumhdqohhsrdho rhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 13 Nov 2025 08:27:02 -0500 (EST) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 3EA95139C95B; Thu, 13 Nov 2025 14:27:01 +0100 (CET) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH 4/5] Don't change mode of unmatched devtmpfs devices Date: Thu, 13 Nov 2025 14:26:41 +0100 Message-ID: <20251113132642.92899-4-hi@alyssa.is> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251113132642.92899-1-hi@alyssa.is> References: <20251113132642.92899-1-hi@alyssa.is> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: RKJUU4TOV5RD7RAEDZOGVREIFNWZFVKR X-Message-ID-Hash: RKJUU4TOV5RD7RAEDZOGVREIFNWZFVKR X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Otherwise, it falls back to the default rule, which sets mode 0660. Not ideal for e.g. /dev/null! Fixes: 88f2695 ("Initial commit") Fixes: aeb5104 ("Initial commit") Signed-off-by: Alyssa Ross --- img/app/image/etc/mdev.conf | 5 ++++- vm/sys/net/image/etc/mdev.conf | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/img/app/image/etc/mdev.conf b/img/app/image/etc/mdev.conf index 7382067..df215b9 100644 --- a/img/app/image/etc/mdev.conf +++ b/img/app/image/etc/mdev.conf @@ -1,8 +1,11 @@ # SPDX-License-Identifier: EUPL-1.2+ -# SPDX-FileCopyrightText: 2021-2023 Alyssa Ross +# SPDX-FileCopyrightText: 2021-2023, 2025 Alyssa Ross -$MODALIAS=.* 0:0 0 ! +importas -Siu MODALIAS modprobe -q $MODALIAS $INTERFACE=.* 0:0 0 ! +/etc/mdev/iface $MODALIAS=virtio:d0000001Av.* 0:0 0 ! +/etc/mdev/virtiofs dri/card0 0:0 660 +background { /etc/mdev/listen card0 } snd/controlC0 0:0 660 +background { /etc/mdev/listen controlC0 } + +# Don't change mode of other device nodes created by devtmpfs. +.* 0:0 0 ! diff --git a/vm/sys/net/image/etc/mdev.conf b/vm/sys/net/image/etc/mdev.conf index 412f7f5..2a7e5fe 100644 --- a/vm/sys/net/image/etc/mdev.conf +++ b/vm/sys/net/image/etc/mdev.conf @@ -1,5 +1,8 @@ # SPDX-License-Identifier: EUPL-1.2+ -# SPDX-FileCopyrightText: 2021 Alyssa Ross +# SPDX-FileCopyrightText: 2021, 2025 Alyssa Ross -$MODALIAS=.* 0:0 0 ! +importas -Siu MODALIAS modprobe -q $MODALIAS $INTERFACE=.* 0:0 0 ! +/etc/mdev/iface + +# Don't change mode of other device nodes created by devtmpfs. +.* 0:0 0 ! -- 2.51.0