From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 9900CB7C1; Wed, 26 Nov 2025 19:41:54 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 7359AB751; Wed, 26 Nov 2025 19:41:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yx1-xb12b.google.com (mail-yx1-xb12b.google.com [IPv6:2607:f8b0:4864:20::b12b]) by atuin.qyliss.net (Postfix) with ESMTPS id F2FE3B6F1 for ; Wed, 26 Nov 2025 19:41:45 +0000 (UTC) Received: by mail-yx1-xb12b.google.com with SMTP id 956f58d0204a3-640d8b78608so113956d50.1 for ; Wed, 26 Nov 2025 11:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764186104; x=1764790904; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JTqd6ISISHLRnykjLh6pUg8F1vpqhe+qRF2nzRjTfwM=; b=I8kxyPiY18TtH8NOsvc9zVnswPRyjW1+BtKdmBHupjhl/+4DSp/TDMxZxQxDrh9fEz /18Svji3WiBghpFbTE8vpWfjhK6ganSLRC+0WEwVAcROccU6HXHsccM7OCXnqEsfxpOK QFJ07lfdvuUQr4+IbrDmw8BwzbZNerKeK8nxANcVthjMd9PmheqhQdGHxnUPW10Yv5is 3/W29kBiz57CimA5FQU13KjW8+FPwkYUCcfyppIcm08rjNYbTIyBKwh5QfLerM74UMZR wPyiQ/lEowPoCPvyIkrJYbwCFM/pQUvBYrAxWbj9XPcuJfjfuPErbXACTpwN0GXPCeBj bk/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764186104; x=1764790904; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JTqd6ISISHLRnykjLh6pUg8F1vpqhe+qRF2nzRjTfwM=; b=ZpWFUyHxrua9X/MbyqU8Tq8uEWXgak5Fa0z7ozmuK2Skn2DW7gWUJoSEE4lwNagOJ0 BOrZnz7lg2u7flBAyz0b1zf6YJ9EI0iPpXHruxed/3balOaeEhxtj6gnd8mlDgyhzBOz JMGwS+5+hiYnSf2cIilyCgMrC4hxM8A+qXKeQw1+IDeWKHk33rUR5cWklGvTrpX3XG7i eBkDxPN+eehfrZJkY4zU8fuXvVcGSI0MYZdaONjxgkSw3xhjkZKiO43X6FxtMyuWRmm4 TPRYU02hrx0Sddj2WaTTrxNCfTNHFj4U+7mCew0X44iWbzTUGAO8BXBQA0qY2q/ireDf TXFA== X-Gm-Message-State: AOJu0YzMWtja3jWKQFTTVeTE7wB2vWeQ+a8NhRj36ANAgc/6A9ZD+e7b ZbA6sVu3x9ZLH/zXwTimjfT9X9Iz90JdWJ3qu4mMzHrSzielpuamLx/90jS+Dw== X-Gm-Gg: ASbGncv3Kby+PqHgxK4ilRFRwFblJ79XWxBW7bQeXn9Xu5rfJneNEPsFWojClz4UcQx EY6/E7S4crUHdyu9+nMWybBl7RolIC2e52VRgk/LaTVwP0bh9jf2bDXp9RCgcJIHK0yNJm8M+Wo 3s7env1rRYuHwvx6pr8Z1I0Il526iC0wDui/2/inr2phT8dTUpOXPRqu069QSBTb+DNXPPCIt+r mxFhLVjqRK4pXy3sVo/4ab+8d3Sk0l+MAStwfCT/xHVWiorc5SA5mc8nm12Li6+v25xVttsisLh J329oNcJhdi/jGFuq481Bul0lUAyWKEdiyRsv1JCF7djbwHGCMyNV4CZzadlH6Da4qGc4mTqy96 TpKnA//9rWch8kjidS5zUD4/EYR1EYKJlF7lNJ1zgAJAv8gV1oF145fqPX52G5cVKpabUR97fWH cvikMtsA1tNp/svkawMEYaq7rql3v5GI7sbpr5tlrP1146HKjCVB6AmCxHuJZilspTn+W5BkCDf Inlil7dBb9/80j4eVmeiX6XG1EXzYa9tyM= X-Google-Smtp-Source: AGHT+IGXOkrMfdYl4h4GbJVgdlFk6PJLbeLuqzOyYpEo9V7DpRM5RjSrkeMsD+cruPjNXlOPsvlJhQ== X-Received: by 2002:a05:690e:1304:b0:643:86d:745a with SMTP id 956f58d0204a3-643086d74bdmr11774896d50.22.1764186103696; Wed, 26 Nov 2025 11:41:43 -0800 (PST) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-78a798a5decsm69546297b3.21.2025.11.26.11.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 11:41:43 -0800 (PST) From: Demi Marie Obenour Date: Wed, 26 Nov 2025 14:40:42 -0500 Subject: [PATCH v5 02/13] scripts: port make-gpt.sh to bash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251126-updates-v5-2-fd746748febd@gmail.com> References: <20251126-updates-v5-0-fd746748febd@gmail.com> In-Reply-To: <20251126-updates-v5-0-fd746748febd@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764186040; l=6204; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=/RZGdJFUz1f6qgMbkzHOscQbG4DiZBPkHqhqQTGct30=; b=zg7xK4TYA23cz0mUFP/HKaueYQr0kpnf4OrH3yx9mrL2cnONabYrRVwn8fTQkSVNUii88gs61 aitcBcRmc7GCYBwv4V2/j8TTr9ydhAbiVT57zCfOaVWTzvjPkI0m1I6 X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: 2BD67UH4FQZH7ISFKJRIVWGOJXDU3HO6 X-Message-ID-Hash: 2BD67UH4FQZH7ISFKJRIVWGOJXDU3HO6 X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Future changes will be using bash-specific features. Use bash-specific code for this. Also add some error checks. No other functional change intended. Signed-off-by: Demi Marie Obenour --- Changes since v4: - Improve commit message. Changes since v2: - Do not use wrapper script. - Make script non-executable. - Invoke script as 'bash FILE' to work around /usr/bin/env not working during a Nix build. --- host/initramfs/Makefile | 4 ++-- host/rootfs/Makefile | 2 +- img/app/Makefile | 2 +- release/live/Makefile | 2 +- scripts/make-gpt.sh | 20 ++++++++++---------- vm/sys/net/Makefile | 2 +- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/host/initramfs/Makefile b/host/initramfs/Makefile index f27f5e07c4707914962197b4fea8f385729370aa..2304b0885a152d8a659dddcc58f948d096034e2d 100644 --- a/host/initramfs/Makefile +++ b/host/initramfs/Makefile @@ -36,7 +36,7 @@ build/mountpoints: find build/mountpoints -mindepth 1 -exec touch -d @0 {} ';' build/live.img: ../../scripts/format-uuid.sh ../../scripts/make-gpt.sh ../../scripts/sfdisk-field.awk $(ROOT_FS_IMAGES) - ../../scripts/make-gpt.sh $@.tmp \ + bash ../../scripts/make-gpt.sh $@.tmp \ $(ROOT_FS_VERITY):verity:$$(../../scripts/format-uuid.sh "$$(dd if=$(ROOT_FS_VERITY_ROOTHASH) bs=32 skip=1 count=1 status=none)") \ $(ROOT_FS_IMAGE):root:$$(../../scripts/format-uuid.sh "$$(head -c 32 $(ROOT_FS_VERITY_ROOTHASH))") mv $@.tmp $@ @@ -45,7 +45,7 @@ build/loop.tar: build/live.img $(TAR) -cf $@ build/live.img build/loop.img: ../../scripts/make-gpt.sh ../../scripts/sfdisk-field.awk build/loop.ext4 - ../../scripts/make-gpt.sh $@.tmp \ + bash ../../scripts/make-gpt.sh $@.tmp \ build/loop.ext4:56a3bbc3-aefa-43d9-a64d-7b3fd59bbc4e mv $@.tmp $@ diff --git a/host/rootfs/Makefile b/host/rootfs/Makefile index 4cb048ac08b3265b0435d6ff6fc612a58c169ce9..f45758041f2f682618cb0f9e54e5a74f0b49874e 100644 --- a/host/rootfs/Makefile +++ b/host/rootfs/Makefile @@ -93,7 +93,7 @@ clean: .PHONY: clean build/live.img: ../../scripts/format-uuid.sh ../../scripts/make-gpt.sh ../../scripts/sfdisk-field.awk build/verity-timestamp $(ROOT_FS_IMAGES) - ../../scripts/make-gpt.sh $@.tmp \ + bash ../../scripts/make-gpt.sh $@.tmp \ $(ROOT_FS_VERITY):verity:$$(../../scripts/format-uuid.sh "$$(dd if=$(ROOT_FS_VERITY_ROOTHASH) bs=32 skip=1 count=1 status=none)") \ $(ROOT_FS_IMAGE):root:$$(../../scripts/format-uuid.sh "$$(head -c 32 $(ROOT_FS_VERITY_ROOTHASH))") mv $@.tmp $@ diff --git a/img/app/Makefile b/img/app/Makefile index 48eba871339d314479f730101246ace3fa39e2db..f16c2df1b90bbec6750f2980da4dbaf49c9cb0ea 100644 --- a/img/app/Makefile +++ b/img/app/Makefile @@ -26,7 +26,7 @@ $(imgdir)/appvm/vmlinux: $(KERNEL) $(imgdir)/appvm/blk/root.img: ../../scripts/make-gpt.sh ../../scripts/sfdisk-field.awk build/rootfs.erofs mkdir -p $$(dirname $@) - ../../scripts/make-gpt.sh $@.tmp \ + bash ../../scripts/make-gpt.sh $@.tmp \ build/rootfs.erofs:root:5460386f-2203-4911-8694-91400125c604:root mv $@.tmp $@ diff --git a/release/live/Makefile b/release/live/Makefile index b37ccce42feb3ac7e8ce4faf96a67902b55be808..c712db3727b7008105388a278552fd3d81eb3b4c 100644 --- a/release/live/Makefile +++ b/release/live/Makefile @@ -10,7 +10,7 @@ DTBS ?= build/empty dest = build/live.img $(dest): ../../scripts/format-uuid.sh ../../scripts/make-gpt.sh ../../scripts/sfdisk-field.awk build/boot.fat $(ROOT_FS_IMAGES) - ../../scripts/make-gpt.sh $@.tmp \ + bash ../../scripts/make-gpt.sh $@.tmp \ build/boot.fat:c12a7328-f81f-11d2-ba4b-00a0c93ec93b \ $(ROOT_FS_VERITY):verity:$$(../../scripts/format-uuid.sh "$$(dd if=$(ROOT_FS_VERITY_ROOTHASH) bs=32 skip=1 count=1 status=none)") \ $(ROOT_FS_IMAGE):root:$$(../../scripts/format-uuid.sh "$$(head -c 32 $(ROOT_FS_VERITY_ROOTHASH))") diff --git a/scripts/make-gpt.sh b/scripts/make-gpt.sh old mode 100755 new mode 100644 index 96f0d2c8494c093558c0e32e7e920b569bb078ef..0ae3d0005e5ae7d6214270fedb2fafb0a7064cf5 --- a/scripts/make-gpt.sh +++ b/scripts/make-gpt.sh @@ -1,11 +1,11 @@ -#!/bin/sh -eu -# +#!/usr/bin/env -S bash -- # SPDX-FileCopyrightText: 2021-2023 Alyssa Ross # SPDX-FileCopyrightText: 2022 Unikie # SPDX-License-Identifier: EUPL-1.2+ # -# usage: make-gpt.sh GPT_PATH PATH:PARTTYPE[:PARTUUID[:PARTLABEL]]... +# usage: bash make-gpt.sh GPT_PATH PATH:PARTTYPE[:PARTUUID[:PARTLABEL]]... +set -xeuo pipefail ONE_MiB=1048576 # Prints the number of 1MiB blocks required to store the file named @@ -40,16 +40,15 @@ scriptsDir="$(dirname "$0")" out="$1" shift -nl=' -' table="label: gpt" # Keep 1MiB free at the start, and 1MiB free at the end. gptBytes=$((ONE_MiB * 2)) for partition; do - sizeMiB="$(sizeMiB "$(partitionPath "$partition")")" - table="$table${nl}size=${sizeMiB}MiB,$(awk -f "$scriptsDir/sfdisk-field.awk" -v partition="$partition")" - gptBytes="$((gptBytes + sizeMiB * ONE_MiB))" + partitionPath=$(partitionPath "$partition") + sizeMiB=$(sizeMiB "$partitionPath") + table+=$'\n'"size=${sizeMiB}MiB,$(awk -f "$scriptsDir/sfdisk-field.awk" -v partition="$partition")" + gptBytes=$((gptBytes + sizeMiB * ONE_MiB)) done rm -f "$out" @@ -60,6 +59,7 @@ EOF n=0 for partition; do - fillPartition "$out" "$n" "$(partitionPath "$partition")" - n="$((n + 1))" + partitionPath=$(partitionPath "$partition") + fillPartition "$out" "$n" "$partitionPath" + n=$((n + 1)) done diff --git a/vm/sys/net/Makefile b/vm/sys/net/Makefile index d71c2325eff3bae921f33c61f799846d35e401c2..e403d697d90c0021a7a8d1dbc1553cfbda74a117 100644 --- a/vm/sys/net/Makefile +++ b/vm/sys/net/Makefile @@ -25,7 +25,7 @@ $(vmdir)/netvm/vmlinux: $(KERNEL) $(vmdir)/netvm/blk/root.img: ../../../scripts/make-gpt.sh ../../../scripts/sfdisk-field.awk build/rootfs.erofs mkdir -p $$(dirname $@) - ../../../scripts/make-gpt.sh $@.tmp \ + bash ../../../scripts/make-gpt.sh $@.tmp \ build/rootfs.erofs:root:ea21da27-0391-48da-9235-9d2ab2ca7844:root mv $@.tmp $@ -- 2.52.0