patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Subject: [PATCH 13/13] img/app: run applications as non-root
Date: Wed, 26 Nov 2025 22:34:06 +0100	[thread overview]
Message-ID: <20251126213407.1773744-13-hi@alyssa.is> (raw)
In-Reply-To: <20251126213407.1773744-1-hi@alyssa.is>

The session bus has to run as the same user as the application,
because xdg-desktop-portal expects to be able to open the
application's /proc/pid/root to check if it's a Flatpak.

Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
 img/app/image/etc/s6-rc/app/run        | 13 ++++---------
 img/app/image/etc/s6-rc/dbus-vsock/run |  2 ++
 img/app/image/etc/s6-rc/dbus/run       |  3 +++
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/img/app/image/etc/s6-rc/app/run b/img/app/image/etc/s6-rc/app/run
index 601926b..5ce5b3a 100755
--- a/img/app/image/etc/s6-rc/app/run
+++ b/img/app/image/etc/s6-rc/app/run
@@ -4,15 +4,8 @@
 
 export TMPDIR /run
 
-backtick USER { id -un }
-backtick HOME {
-  importas -i user USER
-  homeof $user
-}
-
-importas -i home HOME
-if { mkdir -p -- $home }
-cd $home
+export HOME /home/user
+cd /home/user
 
 if { /etc/mdev/wait virtiofs0 }
 
@@ -22,6 +15,7 @@ foreground {
   case $type {
     appimage {
       if { modprobe fuse }
+      s6-setuidgid user
       export LD_LIBRARY_PATH /lib64
       /run/virtiofs/virtiofs0/config/run
     }
@@ -32,6 +26,7 @@ foreground {
 	  store /nix/store
       }
 
+      s6-setuidgid user
       /run/virtiofs/virtiofs0/config/run
     }
   }
diff --git a/img/app/image/etc/s6-rc/dbus-vsock/run b/img/app/image/etc/s6-rc/dbus-vsock/run
index 37fae7d..4733bae 100755
--- a/img/app/image/etc/s6-rc/dbus-vsock/run
+++ b/img/app/image/etc/s6-rc/dbus-vsock/run
@@ -14,4 +14,6 @@ systemd-socket-activate -l vsock::219 --now
 if { fdmove 1 3 echo }
 fdclose 3
 
+s6-setuidgid user
+
 socat ACCEPT-FD:4,fork UNIX-CONNECT:/run/session-bus
diff --git a/img/app/image/etc/s6-rc/dbus/run b/img/app/image/etc/s6-rc/dbus/run
index a609e86..031d730 100644
--- a/img/app/image/etc/s6-rc/dbus/run
+++ b/img/app/image/etc/s6-rc/dbus/run
@@ -3,6 +3,9 @@
 # SPDX-FileCopyrightText: 2023, 2025 Alyssa Ross <hi@alyssa.is>
 
 s6-ipcserver-socketbinder -Ba 0770 /run/session-bus
+if { chown user: /run/session-bus }
+
+s6-setuidgid user
 
 export LISTEN_FDS 1
 getpid LISTEN_PID
-- 
2.51.0


  parent reply	other threads:[~2025-11-26 21:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 21:33 [PATCH 01/13] pkgs: gtk3: backport fix for unset XDG_RUNTIME_DIR Alyssa Ross
2025-11-26 21:33 ` [PATCH 02/13] pkgs: s6: backport s6-softlimit -P Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:33 ` [PATCH 03/13] img/app: wayland-proxy-virtwl: move Wayland socket Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:33 ` [PATCH 04/13] img/app: wayland-proxy-virtwl: run as non-root Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:33 ` [PATCH 05/13] img/app: pipewire: move sockets out of XDG_RUNTIME_DIR Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:33 ` [PATCH 06/13] img/app: remove XDG_RUNTIME_DIR Alyssa Ross
2025-12-01  5:55   ` Demi Marie Obenour
2025-12-01 11:24     ` Alyssa Ross
2025-12-01 19:05       ` Demi Marie Obenour
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:34 ` [PATCH 07/13] img/app: wireplumber: run as non-root Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:34 ` [PATCH 08/13] img/app: pipewire: disable D-Bus Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:34 ` [PATCH 09/13] img/app: pipewire: stop fighting s6 over lockfiles Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:34 ` [PATCH 10/13] img/app: pipewire: run as non-root Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:34 ` [PATCH 11/13] img/app: dbus: create socket outside daemon Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:34 ` [PATCH 12/13] img/app: add application user Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-11-26 21:34 ` Alyssa Ross [this message]
2025-12-01  5:58   ` [PATCH 13/13] img/app: run applications as non-root Demi Marie Obenour
2025-12-01 11:31     ` Alyssa Ross
2025-12-02 12:30   ` Alyssa Ross
2025-12-02 12:30 ` [PATCH 01/13] pkgs: gtk3: backport fix for unset XDG_RUNTIME_DIR Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251126213407.1773744-13-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).