From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 842E61D928; Fri, 05 Dec 2025 16:27:21 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 617BC1D911; Fri, 05 Dec 2025 16:27:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yx1-xb130.google.com (mail-yx1-xb130.google.com [IPv6:2607:f8b0:4864:20::b130]) by atuin.qyliss.net (Postfix) with ESMTPS id 91F731D90F for ; Fri, 05 Dec 2025 16:27:18 +0000 (UTC) Received: by mail-yx1-xb130.google.com with SMTP id 956f58d0204a3-63fc72db706so2089032d50.2 for ; Fri, 05 Dec 2025 08:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764952036; x=1765556836; darn=spectrum-os.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=We+p/l+aCmSS5Sbr963u4OqW+RPvSi1qIK9USu9wvqE=; b=gtExkVjl1G90GNTlijWRjrmBVHkT9fndt1NHprdnL0nPIj7Aml41c2DBYlcNfTfpEk 1bB+hRcRkKsCZMGAfP5C9KyTKq9GaKCy6D619BxBPCreAhy6LnTtSLNkJKdckttL2Q+e 2IDlaZ779tpgKQI25mzZHpQcySZN43A4i/OTNAoKqilw4sRl0fWjF34S2d73K2yXoU+N 7cmPyq8Z4m18HohcoctmzKk2ZZZmGJ5T59QlTELILx+UmXfjo4toDQxNp11ba1346XEF HEBZXVDXcB8s+yPHsDbd4kd4Br9yz1zuP01O2EArPuf1xGa8B4D780lB0P3eegxhgkec O3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764952036; x=1765556836; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=We+p/l+aCmSS5Sbr963u4OqW+RPvSi1qIK9USu9wvqE=; b=XWmv/hKLClq8Hio0SMxsMnGft3PLvKlkBuXBNy1TihfDKKhdvEjWxnF3E4YfEjmUlF LExqhpjsQcD9O1+609flunKdh6PKLEzswjaoiAw3DzHyGH2ipPEDpfVowoH4Gmx8bfur fDlyaBAi0TwP1epS7CxzVYXR3JBs8klYpoyfmZj03RderU7y/VJ7jKoukp+4XUnGeNdg XRSP8kVYB5UiC8uD5yXM8jdFNuTiMPZR/zqsmw/cNfgADkxWLSwRRRr+E7CgbDHaSQs4 2LXb1dZwRq+rDfsHrH3y9GFwF/6qITJeyJw1Cb+L1IJkN9e/NJqh+qycICIot6PxJEtd s05g== X-Gm-Message-State: AOJu0YycLpEJ8S/zxrwwtjbnPtBJC0pOUEXOqlDqcCWFs2IgTSqvuvJ+ gh9FKfCxZM8esIeWrk9u1UPR/35SxzS6sEfACb0mVZs5+5kvmw2TEaQGjTz3PA== X-Gm-Gg: ASbGnctO28I0er0ChOtJsT0v/Lmd+cGJ8bjSDJukcZO3D8H4NHEdhDxTasmzf1gOLwQ bVM1cfsbytSxxnatdi5HMYVBdbIng5M+Sdd0lmFgLbdjmE9I2+ewD7LXp7gdPcsVC46IH3DIy5r B9/PC4Ehum6Pg3ld6QwQEgCI8xw16GqoawzsGJkNMJtVGRg8Khm0cVs/5Mo79LLOa9lpw0CISbX zpqsbrjJapx1oE7zcX0JCv5PYPgTsfwKoGTnN/qgLFwqSBQW/tGEB26pPeV1yxyHcfAAXMC4Kgb LeTbJEmcNHbqwpz1t386RSwlVRjxHAXSFgpfkwFn/s/3fbYvptNa7AbW/zx9uAT04+qkZDJbPMN qWHByGrbidyKNfDa/ENCJB9UtC2Tl4sLTtaEzxmlcyr8k+tEpKLrFIlUZtGvZsKcHSBCIadX5aK S79B/1/OCruC78/SjBHGo9dAtyH95+tWKY4D27o9Wd8exKOqpvFhwdVfLmXm1cb+iDdYGq64iC2 LxcFGJq6jdVFg5jWbLWYgWKxrJjaNyFQOI= X-Google-Smtp-Source: AGHT+IE12C/2TTVlNtHqBKa0Jh/CrKGM33gL1mDdNIaS0IfdPByNe0mVaPM48zgl9LwyvFh6k0UyTw== X-Received: by 2002:a05:690e:11ca:b0:63f:a103:5d2d with SMTP id 956f58d0204a3-6443d936792mr5726030d50.37.1764952035818; Fri, 05 Dec 2025 08:27:15 -0800 (PST) Received: from localhost.localdomain (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-78c1b7a5d98sm18204107b3.54.2025.12.05.08.27.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 08:27:15 -0800 (PST) From: Demi Marie Obenour Date: Fri, 05 Dec 2025 11:26:38 -0500 Subject: [PATCH] host/rootfs: Always fail if there is a globbing problem MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251205-globfail-v1-1-e15b8ea09258@gmail.com> X-B4-Tracking: v=1; b=H4sIAL0HM2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1NDIwNj3fSc/KS0xMwcXRPDRNOUJIOUVBNLcyWg8oKi1LTMCrBR0bG1tQC wmW5KWgAAAA== X-Change-ID: 20251203-globfail-41a5db0de497 To: Spectrum OS Development X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764951997; l=3481; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=CDn/fSocY+Bs385i/5jnWidDnpACvgjiBIT/xQjcv8o=; b=35pey/rzTf4wHX+4lcWoKVtascbtxRUDHLF0g207blypJZlzKZgCfS0wgf/W54Eht4zxwIS18 0MpiKdoFVteCwwyxen3GxZtsgh/XyY2ctd/P0Y737oYSsCPGj7q+g6w X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: XDWGHJB2UMNFS22HIV5MHXVSAVLT2KJ3 X-Message-ID-Hash: XDWGHJB2UMNFS22HIV5MHXVSAVLT2KJ3 X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Alyssa Ross , Demi Marie Obenour X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Better to fail than to continue after an unknown problem has happened. Signed-off-by: Demi Marie Obenour --- host/rootfs/image/etc/s6-rc/static-nodes/up | 2 +- host/rootfs/image/usr/bin/assign-devices | 2 +- host/rootfs/image/usr/bin/run-vmm | 2 +- host/rootfs/image/usr/bin/vm-import | 2 +- host/rootfs/image/usr/bin/vm-start | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/host/rootfs/image/etc/s6-rc/static-nodes/up b/host/rootfs/image/etc/s6-rc/static-nodes/up index e1bdd4061441b39d7b46575a05754331970b951e..66f4fa7954beffc201f0985b3be10bd6a98f1d3a 100644 --- a/host/rootfs/image/etc/s6-rc/static-nodes/up +++ b/host/rootfs/image/etc/s6-rc/static-nodes/up @@ -2,7 +2,7 @@ # SPDX-FileCopyrightText: 2021 Alyssa Ross pipeline { - elglob -0 modules_devname /lib/modules/*/modules.devname + elglob -w0 modules_devname /lib/modules/*/modules.devname /etc/parse-devname $modules_devname } diff --git a/host/rootfs/image/usr/bin/assign-devices b/host/rootfs/image/usr/bin/assign-devices index 58dd3cc0dfc3ceec4c82988755ed1ddbd224abfd..99988d64dbf2802cdbfd69c299f899ccbc1cf390 100755 --- a/host/rootfs/image/usr/bin/assign-devices +++ b/host/rootfs/image/usr/bin/assign-devices @@ -2,7 +2,7 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2025 Alyssa Ross -elglob -0 devices /sys/bus/pci/drivers/vfio-pci/????:??:??.? +elglob -w0 devices /sys/bus/pci/drivers/vfio-pci/????:??:??.? forx -pE device { $devices } # This script is designed to be re-entrant and called multiple times. diff --git a/host/rootfs/image/usr/bin/run-vmm b/host/rootfs/image/usr/bin/run-vmm index ba8b59c2677408acdd01c2eda3cf2dd60992d881..1a09c93bd1ac121c72f8132393979bf03663f1c2 100755 --- a/host/rootfs/image/usr/bin/run-vmm +++ b/host/rootfs/image/usr/bin/run-vmm @@ -22,7 +22,7 @@ background -d { # Find any net-provider relationships this VM is involved in cd /run/vm/by-id - elglob -0 providers */config/providers/net/* + elglob -w0 providers */config/providers/net/* forx -pE path { $providers } backtick -E client_id { awk -v path=${path} -F / "BEGIN { split(path, p); print p[1] }" diff --git a/host/rootfs/image/usr/bin/vm-import b/host/rootfs/image/usr/bin/vm-import index c1d1bbc106b8034c82c8e09c1bff81a06c233fe4..06f90d83509c318bc364d9c0e111878235ae50d3 100755 --- a/host/rootfs/image/usr/bin/vm-import +++ b/host/rootfs/image/usr/bin/vm-import @@ -3,7 +3,7 @@ # SPDX-FileCopyrightText: 2023-2024 Alyssa Ross cd $2 -elglob -0 names * +elglob -w0 names * forx -po0 -E name { $names } diff --git a/host/rootfs/image/usr/bin/vm-start b/host/rootfs/image/usr/bin/vm-start index 67480e5215d8a8260ce3f03c67f71ba8f210c291..94d08437b75f59a728be0e8a1efbc5af3b44f6c5 100755 --- a/host/rootfs/image/usr/bin/vm-start +++ b/host/rootfs/image/usr/bin/vm-start @@ -7,7 +7,7 @@ foreground { s6-rc -bu change vm-env } foreground { redirfd -w 2 /dev/null cd /run/vm/by-id/${1}/config/providers/net - elglob -0 providers * + elglob -w0 providers * forx -pE provider { $providers } backtick -E provider_id { backtick -E id_path { readlink /run/vm/by-name/${provider} } --- base-commit: 92e219e7c08c479d216a46d2736ea9d229ff034d change-id: 20251203-globfail-41a5db0de497 -- Sincerely, Demi Marie Obenour (she/her/hers)