patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Cc: "Demi Marie Obenour" <demiobenour@gmail.com>,
	"Johannes Süllner" <johannes.suellner@mailbox.org>
Subject: [PATCH v2 1/2] vm/app/systemd-sysupdate: fix mounting overlay
Date: Mon,  8 Dec 2025 22:03:15 +0100	[thread overview]
Message-ID: <20251208210416.426243-2-hi@alyssa.is> (raw)

This assumed it would be run as root, so has been broken since we
stopped running application scripts as root inside img/app VMs.

Reported-by: Johannes Süllner <johannes.suellner@mailbox.org>
Link: https://matrix.to/#/!xSysqhzbOZImdvGpix:fairydust.space/$9psDI3BIP00EIzW-qOqzJswkwzgYyQLKpbfDDp0uo6k?via=fairydust.space&via=matrix.org&via=dataaturservice.se
Fixes: 8bfcbf9 ("img/app: run applications as non-root")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
v2: remove redundant -U flag
v1: https://spectrum-os.org/lists/archives/spectrum-devel/20251208154738.300709-1-hi@alyssa.is/

 vm/app/systemd-sysupdate/download-update | 1 +
 1 file changed, 1 insertion(+)

diff --git a/vm/app/systemd-sysupdate/download-update b/vm/app/systemd-sysupdate/download-update
index eada41c..f8f5aed 100755
--- a/vm/app/systemd-sysupdate/download-update
+++ b/vm/app/systemd-sysupdate/download-update
@@ -3,6 +3,7 @@
 # SPDX-FileCopyrightText: 2025 Demi Marie Obenour <demiobenour@gmail.com>
 export LC_ALL C
 export LANGUAGE C
+unshare -mr
 if { mount -toverlay -olowerdir=/run/virtiofs/virtiofs0/etc:/etc -- overlay /etc }
 backtick tmpdir { mktemp -d /tmp/sysupdate-XXXXXX }
 # Not a useless use of cat: if there are NUL bytes in the URL

base-commit: 5104fa720ce8b00612c5487fc47124fbf99e58c6
-- 
2.51.0


             reply	other threads:[~2025-12-08 21:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08 21:03 Alyssa Ross [this message]
2025-12-08 21:03 ` [PATCH v2 2/2] vm/app/systemd-sysupdate: retry a few times Alyssa Ross
2025-12-09 10:19   ` Alyssa Ross
2025-12-09 10:19 ` [PATCH v2 1/2] vm/app/systemd-sysupdate: fix mounting overlay Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251208210416.426243-2-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=johannes.suellner@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).