patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Cc: Demi Marie Obenour <demiobenour@gmail.com>
Subject: [PATCH v2 5/6] host/rootfs: add wayland group
Date: Tue,  9 Dec 2025 13:10:27 +0100	[thread overview]
Message-ID: <20251209121023.705026-10-hi@alyssa.is> (raw)
In-Reply-To: <20251209121023.705026-2-hi@alyssa.is>

This will allow clients running as unprivileged users to connect to
the compositor.

Signed-off-by: Alyssa Ross <hi@alyssa.is>
Message-ID: <20251209085628.603316-5-hi@alyssa.is>
---
v2: avoid widening umask for weston
v1: https://spectrum-os.org/lists/archives/spectrum-devel/20251209085628.603316-5-hi@alyssa.is/

 .../etc/s6-linux-init/run-image/etc/group     |  1 +
 .../image/etc/s6-rc/weston/notification-fd    |  2 +-
 .../etc/s6-rc/weston/notification-fd.license  |  2 +-
 host/rootfs/image/etc/s6-rc/weston/run        | 21 +++++++++++++++++++
 4 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/etc/group b/host/rootfs/image/etc/s6-linux-init/run-image/etc/group
index e3ade468..fe72eb76 100644
--- a/host/rootfs/image/etc/s6-linux-init/run-image/etc/group
+++ b/host/rootfs/image/etc/s6-linux-init/run-image/etc/group
@@ -13,3 +13,4 @@ disk:x:11:
 cdrom:x:12:
 tape:x:13:
 kvm:x:14:
+wayland:x:15:
diff --git a/host/rootfs/image/etc/s6-rc/weston/notification-fd b/host/rootfs/image/etc/s6-rc/weston/notification-fd
index 00750edc..7ed6ff82 100644
--- a/host/rootfs/image/etc/s6-rc/weston/notification-fd
+++ b/host/rootfs/image/etc/s6-rc/weston/notification-fd
@@ -1 +1 @@
-3
+5
diff --git a/host/rootfs/image/etc/s6-rc/weston/notification-fd.license b/host/rootfs/image/etc/s6-rc/weston/notification-fd.license
index c49c11b6..0d3d47ca 100644
--- a/host/rootfs/image/etc/s6-rc/weston/notification-fd.license
+++ b/host/rootfs/image/etc/s6-rc/weston/notification-fd.license
@@ -1,2 +1,2 @@
 SPDX-License-Identifier: CC0-1.0
-SPDX-FileCopyrightText: 2021 Alyssa Ross <hi@alyssa.is>
+SPDX-FileCopyrightText: 2025 Alyssa Ross <hi@alyssa.is>
diff --git a/host/rootfs/image/etc/s6-rc/weston/run b/host/rootfs/image/etc/s6-rc/weston/run
index aa1e7b61..167675de 100644
--- a/host/rootfs/image/etc/s6-rc/weston/run
+++ b/host/rootfs/image/etc/s6-rc/weston/run
@@ -4,6 +4,26 @@
 
 importas -Siu WAYLAND_DISPLAY
 
+piperw 4 3
+background {
+  fdclose 3
+
+  if {
+    fdmove -c 0 4
+    redirfd -w 1 /dev/null
+    head -c 1
+  }
+  fdclose 4
+
+  if { chmod -- 0770 $WAYLAND_DISPLAY }
+  if { chgrp -- wayland $WAYLAND_DISPLAY }
+
+  fdmove -c 1 5
+  echo
+}
+fdclose 4
+fdclose 5
+
 # Workaround for
 # https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1911
 if { mkdir -p -m 0700 /run/user/0 }
@@ -20,4 +40,5 @@ importas -i home HOME
 cd $home
 if { udevadm wait /dev/dri/card0 }
 unshare --cgroup --ipc --net --uts
+
 weston -S $WAYLAND_DISPLAY
-- 
2.51.0


  parent reply	other threads:[~2025-12-09 12:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 12:10 [PATCH v2 1/6] host/rootfs: make passwd and group links into /run Alyssa Ross
2025-12-09 12:10 ` [PATCH v2 2/6] host/rootfs: install shadow Alyssa Ross
2025-12-09 18:23   ` Alyssa Ross
2025-12-09 12:10 ` [PATCH v2 3/6] host/rootfs: move Wayland out of XDG_RUNTIME_DIR Alyssa Ross
2025-12-09 18:23   ` Alyssa Ross
2025-12-09 12:10 ` [PATCH v2 4/6] host/rootfs: weston: add XDG_RUNTIME_DIR note Alyssa Ross
2025-12-09 18:23   ` Alyssa Ross
2025-12-09 12:10 ` Alyssa Ross [this message]
2025-12-09 18:23   ` [PATCH v2 5/6] host/rootfs: add wayland group Alyssa Ross
2025-12-09 12:10 ` [PATCH v2 6/6] host/rootfs: run crosvm device gpu as non-root Alyssa Ross
2025-12-09 18:23   ` Alyssa Ross
2025-12-09 18:23 ` [PATCH v2 1/6] host/rootfs: make passwd and group links into /run Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251209121023.705026-10-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).