patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Cc: Demi Marie Obenour <demiobenour@gmail.com>
Subject: [PATCH 1/2] host/rootfs: remove /proc/kcore bind mounts
Date: Mon, 15 Dec 2025 13:27:06 +0100	[thread overview]
Message-ID: <20251215122707.116898-1-hi@alyssa.is> (raw)

Neither of these services run as root any more, so they don't have
access to /proc/kcore any more regardless.  (Also we don't have
/proc/kcore on aarch64 so this previously errored there.)

Fixes: 62590b8 ("host/rootfs: Sandbox crosvm")
Fixes: ec47d36 ("host/rootfs: Sandbox Cloud Hypervisor")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
 .../service/vm-services/template/data/service/vhost-user-gpu/run | 1 -
 host/rootfs/image/usr/bin/run-vmm                                | 1 -
 2 files changed, 2 deletions(-)

diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/template/data/service/vhost-user-gpu/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/template/data/service/vhost-user-gpu/run
index b1f9bac..e063a82 100755
--- a/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/template/data/service/vhost-user-gpu/run
+++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/template/data/service/vhost-user-gpu/run
@@ -40,7 +40,6 @@ bwrap
   --tmpfs /proc/irq
   --remount-ro /proc/irq
   --ro-bind /dev/null /proc/timer_list
-  --ro-bind /dev/null /proc/kcore
   --ro-bind /dev/null /proc/kallsyms
   --ro-bind /dev/null /proc/sysrq-trigger
   --
diff --git a/host/rootfs/image/usr/bin/run-vmm b/host/rootfs/image/usr/bin/run-vmm
index 0640239..e30b14c 100755
--- a/host/rootfs/image/usr/bin/run-vmm
+++ b/host/rootfs/image/usr/bin/run-vmm
@@ -113,7 +113,6 @@ bwrap
   --tmpfs /proc/irq
   --remount-ro /proc/irq
   --ro-bind /dev/null /proc/timer_list
-  --ro-bind /dev/null /proc/kcore
   --ro-bind /dev/null /proc/kallsyms
   --ro-bind /dev/null /proc/sysrq-trigger
   --

base-commit: 6ceeb9b236cc50d2bba90068533ca1b7ff229c8b
-- 
2.51.0


             reply	other threads:[~2025-12-15 12:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 12:27 Alyssa Ross [this message]
2025-12-15 12:27 ` [PATCH 2/2] host/rootfs: disable CONFIG_PROC_SCSI in kernel Alyssa Ross
2025-12-16  5:15   ` Demi Marie Obenour
2025-12-15 18:36 ` [PATCH 1/2] host/rootfs: remove /proc/kcore bind mounts Demi Marie Obenour
2025-12-16  9:55   ` Alyssa Ross
2025-12-16 12:48     ` Alyssa Ross
2026-01-27 16:40       ` Alyssa Ross
2026-02-01 19:40     ` Demi Marie Obenour
2025-12-16 10:30 ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251215122707.116898-1-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).