patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Cc: Demi Marie Obenour <demiobenour@gmail.com>
Subject: [PATCH 2/2] host/rootfs: disable CONFIG_PROC_SCSI in kernel
Date: Mon, 15 Dec 2025 13:27:08 +0100	[thread overview]
Message-ID: <20251215122707.116898-3-hi@alyssa.is> (raw)
In-Reply-To: <20251215122707.116898-1-hi@alyssa.is>

This is a legacy interface.  I doubt anything in Spectrum depends on
it.  The previous approach of masking it out with Bubblewrap failed on
aarch64, where it was already disabled in the kernel config.

Fixes: 62590b8 ("host/rootfs: Sandbox crosvm")
Fixes: ec47d36 ("host/rootfs: Sandbox Cloud Hypervisor")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
This also means the floodgates are now open for any other rootfs kernel 
changes that anybody wants to propose.

 host/rootfs/default.nix                                     | 6 +++++-
 .../vm-services/template/data/service/vhost-user-gpu/run    | 2 --
 host/rootfs/image/usr/bin/run-vmm                           | 2 --
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/host/rootfs/default.nix b/host/rootfs/default.nix
index 66aa366..26757ef 100644
--- a/host/rootfs/default.nix
+++ b/host/rootfs/default.nix
@@ -49,7 +49,11 @@ let
     system.stateVersion = trivial.release;
   });
 
-  kernel = linux_latest;
+  kernel = linux_latest.override {
+    structuredExtraConfig = with lib.kernel; {
+      SCSI_PROC_FS = no;
+    };
+  };
 
   appvm = callSpectrumPackage ../../img/app { inherit (foot) terminfo; };
   netvm = callSpectrumPackage ../../vm/sys/net { inherit (foot) terminfo; };
diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/template/data/service/vhost-user-gpu/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/template/data/service/vhost-user-gpu/run
index e063a82..bdd842e 100755
--- a/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/template/data/service/vhost-user-gpu/run
+++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/template/data/service/vhost-user-gpu/run
@@ -31,8 +31,6 @@ bwrap
   --disable-userns
   --proc /proc
   --ro-bind /proc/sys /proc/sys
-  --tmpfs /proc/scsi
-  --remount-ro /proc/scsi
   --tmpfs /proc/acpi
   --remount-ro /proc/acpi
   --tmpfs /proc/fs
diff --git a/host/rootfs/image/usr/bin/run-vmm b/host/rootfs/image/usr/bin/run-vmm
index e30b14c..d71f7eb 100755
--- a/host/rootfs/image/usr/bin/run-vmm
+++ b/host/rootfs/image/usr/bin/run-vmm
@@ -104,8 +104,6 @@ bwrap
   --bind /run /run
   --proc /proc
   --ro-bind /proc/sys /proc/sys
-  --tmpfs /proc/scsi
-  --remount-ro /proc/scsi
   --tmpfs /proc/acpi
   --remount-ro /proc/acpi
   --tmpfs /proc/fs
-- 
2.51.0


  reply	other threads:[~2025-12-15 12:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 12:27 [PATCH 1/2] host/rootfs: remove /proc/kcore bind mounts Alyssa Ross
2025-12-15 12:27 ` Alyssa Ross [this message]
2025-12-16  5:15   ` [PATCH 2/2] host/rootfs: disable CONFIG_PROC_SCSI in kernel Demi Marie Obenour
2025-12-15 18:36 ` [PATCH 1/2] host/rootfs: remove /proc/kcore bind mounts Demi Marie Obenour
2025-12-16  9:55   ` Alyssa Ross
2025-12-16 12:48     ` Alyssa Ross
2026-01-27 16:40       ` Alyssa Ross
2026-02-01 19:40     ` Demi Marie Obenour
2025-12-16 10:30 ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251215122707.116898-3-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).