patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: devel@spectrum-os.org
Cc: Yureka <yuka@yuka.dev>
Subject: [PATCH] img/app: only set known interfaces to up
Date: Sun,  3 May 2026 19:31:17 +0200	[thread overview]
Message-ID: <20260503173116.1489891-2-hi@alyssa.is> (raw)

Linux 7.1-rc1 defaults IPV6_SIT to built-in, which means a sit0 device
always exists.  (I think this is unintentional and have sent a patch
to change it back to a module by default[1].)  Depending on which
interface, sit0 or the eth0 connected to the router, comes up first,
networking may end up not working.  Make our interface handling more
robust by only bringing the interfaces from the router up, rather than
all interfaces unconditionally.

Link: https://lore.kernel.org/netdev/20260503165714.1477819-1-hi@alyssa.is/ [1]
Fixes: 88f2695c ("Initial commit")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
Not sure whether maybe it would be a good idea to check
type = 1 (ARPHRD_ETHER) as well?

 img/app/image/etc/mdev/iface | 1 +
 1 file changed, 1 insertion(+)

diff --git a/img/app/image/etc/mdev/iface b/img/app/image/etc/mdev/iface
index 67eee84f..55ec160c 100755
--- a/img/app/image/etc/mdev/iface
+++ b/img/app/image/etc/mdev/iface
@@ -4,5 +4,6 @@
 
 background {
   importas -Si INTERFACE
+  if { grep -q ^02:00: /sys/class/net/${INTERFACE}/address }
   ip link set $INTERFACE up
 }

base-commit: ea05e3e48816037e442e6ee8205f924191c9634c
-- 
2.53.0


             reply	other threads:[~2026-05-03 17:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 17:31 Alyssa Ross [this message]
2026-05-18  7:10 ` [PATCH] img/app: only set known interfaces to up Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260503173116.1489891-2-hi@alyssa.is \
    --to=hi@alyssa.is \
    --cc=devel@spectrum-os.org \
    --cc=yuka@yuka.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).