From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 68219B071; Sat, 20 Jun 2026 19:47:51 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 65854B052; Sat, 20 Jun 2026 19:47:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) by atuin.qyliss.net (Postfix) with ESMTPS id 63190B04F for ; Sat, 20 Jun 2026 19:47:46 +0000 (UTC) Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 65C801D0008B; Sat, 20 Jun 2026 15:47:44 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sat, 20 Jun 2026 15:47:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm3; t=1781984864; x=1782071264; bh=uwfeSYHv2gFdbJL7sRH6F l6J+YxvwnlgsHjAZZQYRb8=; b=ZnNjUFNWqIsg5lHaNGtipGUOFutMSZlYzIUJ4 xIdlNb+oTIEs8a0dXL861WGZB+jrcjts1bnKICQfbT/PUHvfjoQCzwYrQwPJcdZL 8rNi6QZ/x/Rk9XqG2MXsPyO5nmcOQNXooRM0e+Z917UuOonI1i8hERIINSgfTSKv ScB92fC6ntniwTkSrKT8SXNI7dpm420VJQV2B2mbyYxg2T1R0rw/GOa6I4JcO9xQ A2Dob7lmDVeBPmb2DJn2MyaSZAzcPzpTiBykYffmBCEspciWgqeZuhgBcvHiQGmj PU9w/9jDb4hYILp2UrK5MJWmqBR89HDSce31cO9Um0aT8CTvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1781984864; x=1782071264; bh=uwfeSYHv2gFdbJL7sRH6Fl6J+YxvwnlgsHj AZZQYRb8=; b=k5t5cJC2cz9pxGUTybjLfnLNRp0ZE2gQ74ub0pjfkng7A8xZI2g sndsuVBuFai6smBX+LpJIASJoX05JxjfJJ67XEBwNsgLvtUXVXX2lNNoFIMUptxq XbpLvbOzVugOJD7bGXjx2q1gCHTUpBjzmMoGH0t2vyKyiSVRKlt/34LG+fhzbagZ kxhCBomG23mLJVrbOX5DcBVHbaa1CoHLscF+HFaPUhGjsb+gMx/hFx1k9K6/ABRz Mqg5//0EdnkAQoL4Ylf6yd1V3S0jjbEGKiG5N2YfSXrC5dbdEnnAiF3RAjAFeLho iGuBXO9dNPBlcv8h+G1BmlVdhy9PeQGUwgQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFlC2GsHEb474ZeoQcLl0poMCRsF7L/zpKJleH9hNVPFRjWhiCQC+nfbCDbrHdqpA 70EPPlNX0xG8cvqBJoqJAsDTZi2JLUymLXRLn44poEj/5ksUc9hVPZgDQYlDkxABglx7kk hEG6N4PNg6ubkyRNmGT9YSOj2RuoxPaGBYaSvx72HRPN7Ick9wn3crlZhjEJ1Q+qVSrnTw 00denNjRBoUiMj64PuGunMF327zXTIIhOGQxKQxICLmWIhm39XzfB2KDREVAe+P1UaL0y5 UfkI7HGLo5d/mSSkiPh0ofRiIa0KSKGKYhuJVMSl1lFKW+VCeg3w4yBDWkg/Dht9DT/0U4 GtBKiQHn3QuuBQne4jRETX6iU/kjQ2M3HYufecRhKgKWb5vIDrx/NFOIUn6v0l5uoMqNj/ icZQ1/bMr0vaZ24o4WvCbTHGAw+k/XKUELbMLg9BYEfWrz84U7RFP7yV2q5UCnSZI1qKgr 3GwmmjQQl0lt8WdURQ+2dLGC0sCfXpYj51BRMH6Mu5ILkR52bjDpZW4VCJ6664ijFv1L42 WSzLvooe+vmnhM1eTCfAEQrsJtnE3WuENXPcGB2BHB/H8ibuI7WrpIOjJSqcBT4yP4piXA BJsGziTR9NvA50WVBceEQrbRdPKNG38ChUrXLRdAavClIkZ2qTbbhR5Y8GEQ X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 20 Jun 2026 15:47:43 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 4C7BFB8DAA81; Sat, 20 Jun 2026 21:47:41 +0200 (CEST) From: Alyssa Ross To: devel@spectrum-os.org Subject: [PATCH] host/rootfs: fix vm-console Date: Sat, 20 Jun 2026 21:46:36 +0200 Message-ID: <20260620194635.53707-2-hi@alyssa.is> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: KOYKWJWEO46H43ABLIUAWCWWDBNIH5YT X-Message-ID-Hash: KOYKWJWEO46H43ABLIUAWCWWDBNIH5YT X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Yureka Lilian , Demi Marie Obenour X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: cloud-hypervisor was being run with its own /dev/pts, so vm-console couldn't find the VM PTY to open it. Furthermore, for Cloud Hypervisor to actually use the global /dev/pts now that it runs as non-root, it needs to be able to open /dev/pts/ptmx. ptmxmode=666 matches how systemd mounts /dev/pts. Fixes: 6138e44a ("host/rootfs: run Cloud Hypervisor as non-root") Fixes: ec47d362 ("host/rootfs: Sandbox Cloud Hypervisor") Signed-off-by: Alyssa Ross --- Posting to the list in particular to give a chance to anybody who wants to tell me the sandboxing should be done a different way. host/rootfs/image/etc/fstab | 2 +- host/rootfs/image/usr/bin/run-vmm | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/host/rootfs/image/etc/fstab b/host/rootfs/image/etc/fstab index 18bb5e45..4d52a1da 100644 --- a/host/rootfs/image/etc/fstab +++ b/host/rootfs/image/etc/fstab @@ -1,7 +1,7 @@ # SPDX-License-Identifier: CC0-1.0 # SPDX-FileCopyrightText: 2020-2021, 2025 Alyssa Ross proc /proc proc nosuid,nodev,noexec 0 0 -devpts /dev/pts devpts nosuid,noexec,gid=5,mode=620 0 0 +devpts /dev/pts devpts nosuid,noexec,gid=5,mode=620,ptmxmode=666 0 0 tmpfs /dev/shm tmpfs nosuid,nodev 0 0 tmpfs /media tmpfs nosuid,nodev,noexec,nosymfollow,mode=755 0 0 sysfs /sys sysfs nosuid,nodev,noexec 0 0 diff --git a/host/rootfs/image/usr/bin/run-vmm b/host/rootfs/image/usr/bin/run-vmm index 94199434..6967dc55 100755 --- a/host/rootfs/image/usr/bin/run-vmm +++ b/host/rootfs/image/usr/bin/run-vmm @@ -93,6 +93,7 @@ bwrap --unshare-user --dev /dev --dev-bind /dev/kvm /dev/kvm + --dev-bind /dev/pts /dev/pts --dev-bind /dev/vfio /dev/vfio --tmpfs /dev/shm --tmpfs /tmp base-commit: 57bf21eaf65ca5a42d18999ba65f96dcd338113c -- 2.54.0