From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id BF28F1C72; Sat, 11 Jul 2026 20:14:33 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 81BA91C05; Sat, 11 Jul 2026 20:14:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by atuin.qyliss.net (Postfix) with ESMTPS id 50C2B1BCC for ; Sat, 11 Jul 2026 20:14:27 +0000 (UTC) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-81d152c1c39so10015787b3.2 for ; Sat, 11 Jul 2026 13:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783800866; x=1784405666; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1LgcZ2mW4+8KrZI79dnW4OO5r9ge4x9iC2Wg0/RwRSY=; b=XpXEdkSg9utyxB4IQnyfYik0mNHmZeE2fU9TEs4VP6Edd1oCy/TvSZxi/kX6vkmwD3 ylmTLRzc70Ix5x+U6Lz6Zw3kfK/8NNZCNVe7z7X/hRe/juXRAadRPi/hN/OWDm7qiS9f nULI9QLNXfkRrCyLY1v/QDD4MNjaDiBoOZG7UiMVT8ylielx1xD9xcqQbjsq4Bzl7w1m 0P/YohlPYKXdcKpL+LE1xa6EA7TAY+7lTblbmcqeDXC/xMrdbWsQu3a836AwxdPjXZCm h8DKfEDfB8GU1l+Ef7bA0WubVpSHbtBkUbAXEwSSAHcIX0sSbSYHiJRFjZXuInA1T9nQ TGqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783800866; x=1784405666; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1LgcZ2mW4+8KrZI79dnW4OO5r9ge4x9iC2Wg0/RwRSY=; b=LdXKWOwsVZkYVk44FMbR8CA3wDT/Zbpwu85Kykmri7H1jaqP1dUL8PQQIvGSGm5W/C Sgy1M9B9rH7TL6wShjI9xe8dMie+elFAujQ26BAeNpOuTXXd5jyG8QcPRHPpBsdGFwHE 4YDdO+2pIk9GtFtUJspaL8H/96dtRNS7pJ1zcBg2nWUU1q0BU7BVwA3nYxIxHk8wrFYC O97LDIpL8zoscSR5XFtzkWW0wiaVJAHyoD6zvtrQ5trhZs1LAhW5ChEAX5Y8wYvvPipE bG6LDgNxJlW5JZC+WzTfS+p4y9CnQiTvWoX645h6WHsOD2bRqRJVUjWUILAg4HWD/bcr j0qA== X-Gm-Message-State: AOJu0Yz0c+DeLeW7dtf6by3Y+ZHHHEbRogPLg5+6Qmo0HqZiXtLJoSnP tIm74nboLtZQXGOZZT07gwblsHjIQOM+qMOP+oIfBIz6QbQTIUEBL5OvHTZttA== X-Gm-Gg: AfdE7clpn+UNZrt4DOHpUSX7xNNhgJnocMe6//RoWq2l+U1edqeh1kq7fJNbY6S3ea5 uG7qsV3E6hCe6I+NUOZizWEtfF/FbfjRRuVLP2HWAFx5UmMnV/oonCz58j6i2efzSCo1QiN3o92 Qqw+bny2IAQf1f2pj2TpwASZetqrqvuWlnF/jpAZdHCJ7tluDzrRkt1THt4XgJpMemx9rSFnNyF +MpPmy0KaFaOiB1Qf/z8qt/SZ6V8ixWJdv+uyvcXYbq3ZB1kA4siHBIJ8wVRsIJSo5o0OiqWOop FTEohetksn/eFQL/AtG5tD/9/wHGhB1/9t7uUUY/gjD3/tk5OnsMCsBAc1Owd7hnn+KFvsRFzh7 zX3OIB47eXzOHlIH5EF14HXPCWdaRFj0sbF9EojoOYyajRvPgErfR5ZXnOwx2YXLa+rG9jkRmk9 wxcGgVJfIdLUr6V6Sja/o7KO81MA== X-Received: by 2002:a05:690c:660e:b0:80c:85b6:764a with SMTP id 00721157ae682-81e902d814fmr27039587b3.63.1783800865891; Sat, 11 Jul 2026 13:14:25 -0700 (PDT) Received: from localhost.localdomain ([185.98.168.14]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-81e6c1a44e1sm78501397b3.29.2026.07.11.13.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 13:14:24 -0700 (PDT) From: Demi Marie Obenour Date: Sat, 11 Jul 2026 16:12:12 -0400 Subject: [PATCH v3 08/22] host/rootfs: Add comments where cgroups are intentionally not used MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260711-cgroups-v3-8-5cba61a20cba@gmail.com> References: <20260711-cgroups-v3-0-5cba61a20cba@gmail.com> In-Reply-To: <20260711-cgroups-v3-0-5cba61a20cba@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783800724; l=5887; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=D33VSRiQv1F6YkUJyGSbw4pwIxuuHfoxH3Eneqd1fnk=; b=9E7q9vYJVkg6ojX0ZX/mt5mIR6zguNEqeWV2w56eikdiQLXcBe6IdZcMz3Azf6SV9yRot0vGL tKQAn1SapY4D99DEJSEIPgUuIxlibqUURTxYq4m/JQPCnSMwSe/ctOy X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: 7ANPCYMH5XTSK5VOKJOQDJPVY5T3YNYS X-Message-ID-Hash: 7ANPCYMH5XTSK5VOKJOQDJPVY5T3YNYS X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Most services should use cgroups, but some do not. Signed-off-by: Demi Marie Obenour --- host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run | 1 + .../etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run | 1 + .../image/etc/s6-linux-init/run-image/service/serial-getty/template/run | 1 + 8 files changed, 8 insertions(+) diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run index 4d2cd7172e887e90d9ce87489cdacf41e51f77e8..5b2421a3dedf7c282ea818f4064535d0fc29d511 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty2 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run index 06abf5422365ff4edc9379e5cbcab716e6830399..3ca382f76368174ee1f99ea880827958c57b602c 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty3 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run index 3dd235fc93d403fc8971e923ec62cb025684b67a..983bd82927e468bab6ae20f61411680d173e4924 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty4 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run index 86b9a1ef70300de52f33a84cbfac22a77e00df36..fb55327dff5f189f543fb3629702caad9ff247e2 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run @@ -2,6 +2,7 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2025 Alyssa Ross +# cgroups make no sense here s6-ipcserver-socketbinder -a 0700 /run/root-terminal if { chown wayland /run/root-terminal } diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run index 327f4ccc5056e7ef87c089e666090307845cae3a..a6733604e91692f8440fd68efeb1a6b7378be167 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2023 Alyssa Ross +# cgroups make no sense for shutdownd s6-linux-init-shutdownd -Bc /etc/s6-linux-init diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run index 8f7bd889e50d76a49b98d8ba9e2c6172f287277c..cf3f5c7b499d997fd426062651eca64b3accc146 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run @@ -2,5 +2,6 @@ # SPDX-License-Identifier: ISC # SPDX-FileCopyrightText: Copyright (c) 2015-2024 Laurent Bercot +# cgroups make no sense for a logger redirfd -rnb 0 fifo s6-log -bpd3 -- T /run/log diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run index 78f794202bf174f3c036f3e20755ac087a988277..8fb1b6779c0bb1e3cdf67d1fa14722caacc25994 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2023 Alyssa Ross +# No need for a cgroup here. s6-svscan -d3 instance diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run index f3ed9a7f08e60206afd222f4fc02c5fb19527561..775b828c72b9d73bef8a3355fb3ae0536975f474 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021, 2024 Alyssa Ross +# Don't put this in a cgroup. We want nohup to work. getty -i -n -l /etc/login 0,115200,57600,38400,9600 $1 dumb -- 2.55.0