From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 983736715; Wed, 22 Jul 2026 02:17:05 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 571C966CB; Wed, 22 Jul 2026 02:17:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yx1-xb131.google.com (mail-yx1-xb131.google.com [IPv6:2607:f8b0:4864:20::b131]) by atuin.qyliss.net (Postfix) with ESMTPS id 83DC166C7 for ; Wed, 22 Jul 2026 02:17:01 +0000 (UTC) Received: by mail-yx1-xb131.google.com with SMTP id 956f58d0204a3-667923d86a7so6098467d50.0 for ; Tue, 21 Jul 2026 19:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784686620; x=1785291420; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1LgcZ2mW4+8KrZI79dnW4OO5r9ge4x9iC2Wg0/RwRSY=; b=Kja0JYsWv4pLO/7kgx0XWrk+G34XbmM281Rk5s1w6vbyp9/FkI4YHpTe3oxDCQi/Lt ecR8DL43vyg5HOU4Ej9MhLlsUMSCZCd9xCJS0g+il1ogiMOJo8XPi1nxzrMmhH1h3Kku Y75BuPo0+AuM/pSotuhD0gS98lY7VqKwXZUPa5UrpTSzf/cwC7hMMaxOzuPK7clOA5aN /qNzLPrskH86H3zbT7ImaASmudQ1MQlBSFBP+axukO5PIBllUJczBpXP0shHy2hTmm7U 8bS5QfGYPmLf0gaYEjmwlLovdOVdUMIUqPpmk2HJjXNGake6U44XiIOI2exvcO+ThtkX mbtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784686620; x=1785291420; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1LgcZ2mW4+8KrZI79dnW4OO5r9ge4x9iC2Wg0/RwRSY=; b=s+JxldtenBcLV59e6ergnfLR1kGjyEk2glAzi6Rq+PoGc8NXi1hmwe0WN8sZAc3jj7 FCu1rt4DYKH1HJv9QSkuCkb3ar1HSrlqJc+w1GWU3bOH8SFoydItA5TYpSYrONtXUfM2 cWiH3sgG8JvcGXLZHFBgJHn2b7YN+GhCEUtriuJFbGPF6kpIKfQbdKKdpW7fF5M2AAob rN0FBqLNB4bv16yJoBGl8SjTdW3ovZUlP7uIJvPxXxKL5IMNAtzbF/pETcachLTGdnEF ZT2NqywHOVLwXrlMdvc+JtOa1Ew10LiqW8B2y2IXCSkO4ouIViqPSTqb2aOgSB9/dDxt aoqQ== X-Gm-Message-State: AOJu0YyWrTfN/jFek7+YHBHpmey74E0sLPNWGTJe0dlzbjS6vk6fzCja c4xtRzBZCyCYH8xksirBlhMXOWgJCGGyo+/AXhd5HJZ7jy7fW9VnAJe/KKlVxA== X-Gm-Gg: AR+sD10Ij8tEBHETMRS68XOLmP8ET+ZTGz6zrITvcrXeC5to46axREC9Xt/2qcxPsvV aIWOjbZwdty4tZacNW2sUOJoYzN8tTxZmVWaqxRNqE3zfu7fh6m6ZK16PBIvOg40STmPPGTRe52 AykRNNNDAQT7dAXAW/MKuWtn6T1LZ0IphlbDqDUr7BtfqZS5I/vYOddd2ZfdXxW3j+CczltQYIh dhJ0B7EmlzuQrMYOfKNrLxlr+CFvwrbHnp2nQ70eACQoJNXAtdHiZ14yeDq4Q4iSDTlkmBTE73j JLxyLwq9pnuMDMs81QzqLUUu4PgHP/KbVvu3aiVEsvKVQipCdZrlDK4XSckyoX+/IkSSpNjH8Xq BzWq4LE6QBedmv0H8XvJuRv5qGQGPpXXRZcPxHvucm8vIvdAiWY3aaSX08+qIi0/W992Ih2y/Sy QrNLsRO58Nt346PH8= X-Received: by 2002:a53:c681:0:b0:668:c30:5c29 with SMTP id 956f58d0204a3-6688ea2e4a4mr441599d50.49.1784686619939; Tue, 21 Jul 2026 19:16:59 -0700 (PDT) Received: from localhost.localdomain ([185.98.168.14]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-6689056551csm576737d50.8.2026.07.21.19.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 19:16:58 -0700 (PDT) From: Demi Marie Obenour Date: Tue, 21 Jul 2026 21:59:12 -0400 Subject: [PATCH v4 07/20] host/rootfs: Add comments where cgroups are intentionally not used MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260721-cgroups-v4-7-46b2e5fff7b6@gmail.com> References: <20260721-cgroups-v4-0-46b2e5fff7b6@gmail.com> In-Reply-To: <20260721-cgroups-v4-0-46b2e5fff7b6@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784685545; l=5887; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=D33VSRiQv1F6YkUJyGSbw4pwIxuuHfoxH3Eneqd1fnk=; b=gU22U48mA07fRQaTfLgg4LLyZW1CNnrmH89lB2MIrwrEHo5wpd1L0+6KsoWUW37R4QnHuCci7 gqYmAET3IBcAx15smsXUzVAeH+Lk61h962sz9UhXDg9ITRaATB6Qhk+ X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: JU6OZSDBFHWFHUPQG7LGWMPRK6WL26ST X-Message-ID-Hash: JU6OZSDBFHWFHUPQG7LGWMPRK6WL26ST X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Most services should use cgroups, but some do not. Signed-off-by: Demi Marie Obenour --- host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run | 1 + .../etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run | 1 + .../image/etc/s6-linux-init/run-image/service/serial-getty/template/run | 1 + 8 files changed, 8 insertions(+) diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run index 4d2cd7172e887e90d9ce87489cdacf41e51f77e8..5b2421a3dedf7c282ea818f4064535d0fc29d511 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty2 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run index 06abf5422365ff4edc9379e5cbcab716e6830399..3ca382f76368174ee1f99ea880827958c57b602c 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty3 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run index 3dd235fc93d403fc8971e923ec62cb025684b67a..983bd82927e468bab6ae20f61411680d173e4924 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty4 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run index 86b9a1ef70300de52f33a84cbfac22a77e00df36..fb55327dff5f189f543fb3629702caad9ff247e2 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run @@ -2,6 +2,7 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2025 Alyssa Ross +# cgroups make no sense here s6-ipcserver-socketbinder -a 0700 /run/root-terminal if { chown wayland /run/root-terminal } diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run index 327f4ccc5056e7ef87c089e666090307845cae3a..a6733604e91692f8440fd68efeb1a6b7378be167 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2023 Alyssa Ross +# cgroups make no sense for shutdownd s6-linux-init-shutdownd -Bc /etc/s6-linux-init diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run index 8f7bd889e50d76a49b98d8ba9e2c6172f287277c..cf3f5c7b499d997fd426062651eca64b3accc146 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run @@ -2,5 +2,6 @@ # SPDX-License-Identifier: ISC # SPDX-FileCopyrightText: Copyright (c) 2015-2024 Laurent Bercot +# cgroups make no sense for a logger redirfd -rnb 0 fifo s6-log -bpd3 -- T /run/log diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run index 78f794202bf174f3c036f3e20755ac087a988277..8fb1b6779c0bb1e3cdf67d1fa14722caacc25994 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2023 Alyssa Ross +# No need for a cgroup here. s6-svscan -d3 instance diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run index f3ed9a7f08e60206afd222f4fc02c5fb19527561..775b828c72b9d73bef8a3355fb3ae0536975f474 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021, 2024 Alyssa Ross +# Don't put this in a cgroup. We want nohup to work. getty -i -n -l /etc/login 0,115200,57600,38400,9600 $1 dumb -- 2.55.0