From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id D79A3BC29; Fri, 31 Jul 2026 22:00:53 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 22317BA82; Fri, 31 Jul 2026 22:00:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yx1-xb12b.google.com (mail-yx1-xb12b.google.com [IPv6:2607:f8b0:4864:20::b12b]) by atuin.qyliss.net (Postfix) with ESMTPS id 3799DB9FB for ; Fri, 31 Jul 2026 22:00:40 +0000 (UTC) Received: by mail-yx1-xb12b.google.com with SMTP id 956f58d0204a3-668c1b780e5so2191598d50.2 for ; Fri, 31 Jul 2026 15:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785535239; x=1786140039; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=snNLvOV2zkElodBeuDMI0IMiSjJ2DOiqevqP4I33YmY=; b=fdfed4C1q76AaFtldEQsbBIQ0IGtaTYiChy79N4fDg5kioR0tAUl+3T6R6fD2fPSzz JKXxP48MtWS75wwMUrPhf163Dqxw60knZg1tAeIe8Yry2ywswrdTq04OuJyAPeeL2+rR k47r/ZfP1oYkv9PXa8rNdAlBNObHcSrxCBaJCP8nobyLoByoDVVmrHRjQeHs+3NGeYDY H5a3U3BmapLNnh6ML6MkmXwjO94pu6ujQRILtRc+WPDl0fGGRBjerjMyheulkpY/sk4L SzK6gL2auya9uUZoPqjnalYr3PHlMMvW9Q3NGu/4yrNksd2Srh3RYS9TsEBC0iQ7IXDL sHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785535239; x=1786140039; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=snNLvOV2zkElodBeuDMI0IMiSjJ2DOiqevqP4I33YmY=; b=SqHyYJOChWuGCv2SGuBx+nKDoqGeCu2HNO/Up2NooZTfqvFqlkHAv4nZvC+FPTsN1T WOGEZ4N7VvwB8KjdUIYHLUwTIWSvNFdwR5HbPAYyK1nNU5i51U+3hJct1YtfM9NHp3tq V2wqdbNwizgK62vrUgcMjqO7cZ5vw4EuBG7DiI7YnYCuDqTF5nYNoUe/53W5UaC9MqSH OxGF+2Zbat6rNoA37HKioBa3O3x3Lz9SOvcjS+krYgl9O1aiO+LSUMkk4GVtwGPmmCIP yQVw9LFnm9r7l32chSeAz6aUWjVPekCBo9nvM1BXB1R10Tg2w/TxiP9ZA15Ke2QbGV5D GAiQ== X-Gm-Message-State: AOJu0Yy4j3cOyscXyaz4vSeXdYCd3wus61lv02dZpTlGGxnjh5hpeP2+ r9KcPBGs+f86a2zh0H20fj+dVrZx1eipYzV7w7U0oBrcLSWtWWbyTRGSRPbNkQ== X-Gm-Gg: AR+sD11esVkgB1W/3/bpqO91IbhNbujXijcHLQidxY8/aQE/sAKUJhT0DnQNmEUpyBb 8kkpP4N7etY1IBRCsIL17pkOk9lp/sDYIZm/gdCNCn04ly+JRLAsE6LxsDeTCEeBbH8EzjKnFFw O0VStYGvDTWE6Z0oaqE8UrMvrcXFge9H0DLYr3kWsPtTj35njElzI3nSB0wEeKMpaCdZUcWVnHB ZbKbhO1O5bMCD5okf5nRJd89V4qx+xeBszspcuIHLKPSZR0CYswTp7TB+RQxJAQaBFCsaaIe23c mCptoJ71g2iiFmbv3KwF842vGtu+i0WlKK0IAqdgr1InH/fKKZ7l4VB/yOFiEvfe7NQ7GnroXY3 gX5q3g8Gvm+sEfLPieg6vWO0M6nmIcHAt+iNJtxoXb+IieDjn9YkNphteTjKCAdBmw0arNRtm6K j7GI65eEHaeh1+vWmOKFVAw0rCAj/f2mpiVZvpdc1E0JtrOJOls4kszhLLXhSW/m7yHJBlElCTB D4dlJnzNsMx X-Received: by 2002:a05:690e:168c:b0:668:56aa:6d77 with SMTP id 956f58d0204a3-6694efdd7acmr1753577d50.9.1785535238616; Fri, 31 Jul 2026 15:00:38 -0700 (PDT) Received: from localhost.localdomain ([185.98.168.14]) by smtp.gmail.com with UTF8SMTPSA id 956f58d0204a3-66948fcb3acsm1326813d50.10.2026.07.31.15.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 15:00:38 -0700 (PDT) From: Demi Marie Obenour Date: Fri, 31 Jul 2026 17:54:53 -0400 Subject: [PATCH v5 13/19] host/rootfs: run-appimage: Purge the per-VM cgroup MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260731-cgroups-v5-13-b325bac9d34f@gmail.com> References: <20260731-cgroups-v5-0-b325bac9d34f@gmail.com> In-Reply-To: <20260731-cgroups-v5-0-b325bac9d34f@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785534880; l=999; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=vqDdssvrbMsuZQrQTP48t05AoRSUGMwzwDWIyUg3EWk=; b=qKoIp7MscGvthq+pt0QW0sPz0S9xgLU4mfvQhJnh0gkIbNs+LeW3EowjMOgkdR6cqNRBxyoai 7lK9QpPC4bwDZOE796jp9ddrEKMrrAO/CGQZCYMyIoMNfWsR9mqWUJb X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: HOZA5GRPDQEML5RFRVALOTEVZDOINMFF X-Message-ID-Hash: HOZA5GRPDQEML5RFRVALOTEVZDOINMFF X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Demi Marie Obenour Reviewed-by: Alyssa Ross --- host/rootfs/image/usr/bin/run-appimage | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/host/rootfs/image/usr/bin/run-appimage b/host/rootfs/image/usr/bin/run-appimage index 672ec22d4b815fb9c2940e13ae08ed4093baee4e..03020c89b02f295844f5ed814034ba66be741f4b 100755 --- a/host/rootfs/image/usr/bin/run-appimage +++ b/host/rootfs/image/usr/bin/run-appimage @@ -89,7 +89,12 @@ fdclose 4 foreground { run-vmm $id } fdclose 3 -if { s6-instance-delete /run/service/vm-services $id } +if { + # Even if s6-instance-delete fails, cgroup-purge is enough + # to ensure that the VMM and all per-VM services are killed. + foreground { s6-instance-delete /run/service/vm-services $id } + cgroup-purge /vm-services.slice/vm-${id}.slice +} if { umount -R /run/vm/by-id/${id}/ns } rm -r -- $diskdir /run/vm/by-id/${id} /run/configs/${id} -- 2.55.0