From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 57712BAE1; Fri, 31 Jul 2026 22:00:46 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 12C49B959; Fri, 31 Jul 2026 22:00:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by atuin.qyliss.net (Postfix) with ESMTPS id A01C2B93E for ; Fri, 31 Jul 2026 22:00:31 +0000 (UTC) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-81ed073fed0so21780647b3.0 for ; Fri, 31 Jul 2026 15:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785535230; x=1786140030; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kV+Fnk5pl9TfVCks9BJG5pg0kcr6vHanzNlfk89awnA=; b=AwwaWNd1YJE4IFwafs8r3tdcLIsTVMZkp/Z6v/1ke5j2cMZ9hZ6LMxieovVdHwz7xJ eulOVD0S59OAXcZCa3ucfRiRxVmVGfbiOWa0APRoa373rRlDl2QQaaDT5rx5qpWJBfJ0 g1sppZ41d1i8TUudJN1ool/xm+PIcV2ROzSL9M5IxSx2ZV4gaJvY+KtbQh+jC2zNmfmY dy8CtpnmK58ApQgVnlJEzjunX4W10qY6Fs51iDOXKem8+aiYbpGHMCdL4eoxFuVphVrN bgOXoVuDbj65nVLfUXkqQ5cdpSscT5+xljqlTB94ahGdvrVCae8ZWHfw4JVJoZ7bipNn ckPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785535230; x=1786140030; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kV+Fnk5pl9TfVCks9BJG5pg0kcr6vHanzNlfk89awnA=; b=VKkS8iC6Me69KY86S275BsVxRjw4DWvjnzWG/Bsh7vNQmaHaRxKtQFDeugWyMQT41N xEzCdlZPNK3BNJ1tgAY5t6RkgGv8ZQaodYKVsuIV3BB6n85VtMYfjZImyplEcND58LBv DVQLgR8ZMMRXHY5goN12HpC2qLoyNTZIgIvkbpWyIqUSXGuPKx+0g85B14FVe61EgfFu cuXGwpT72edlllc0aEeR/2u/LN5RHUD2Sk3JOgYjeh81nkAiI0CnQLuu9zgTdkJHIh3o qCK5de/L9sSuDO+TZKSJYp3kOhkUBJhOYX6ySG/C7MIhOO8Z2nhSzigCdaSUGpJS9rk3 Y0Aw== X-Gm-Message-State: AOJu0Yy7QhpCxOohTboAm4k9MVr/itXUmRuUk2VDjlagMyfX/sBGRhVa 1dQbWWJcx1enHO2Qov4pNZ5emB1f98RZ8CNs8jK2IK7KZbr5+iynoS/2/RVdrA== X-Gm-Gg: AR+sD11EKg8gQnXmKfngIaRx32pGpRiXNLj/+yZ9H+u9DId6n46obsJi1JYiVxDbrZg SDpQ4UORAvBkS/CtK27hrvchqxabXGDNXuBP7UJipb6eJbd+NkGOPwZJCteWC5ieqZawMgxA8KV ixwaYfkyaeEN5B+Mj9Bh+rSlpc01Q64+efqQV0yfAih1yNYJ/LWzAY1dXHXnOA7l5uqD4XyWTAv d7ofWaUt203PQZsy4bdyhn1XgkupuHGL1YzGqlf3C5obUWhCdbBSDOK1GtGWoWjvb7UJN45ylHM 9mLeFSk+XGDN+TF76w4go8NN0kP10xIl6/5nml1aZW0tZTO3DEFU6VC7eh52tZIqyxHKMZMoAm2 L0AU1Zw4tzmkGFqXLNBtHjS4LhcYrpN3qTUf9xu95wzrfCn9oxhRti4plBuxmfcwAwIauoZpYh5 hdtXSK7nNvivlABZ1rnUCWNE6DP+8Y2e5Z1WMeaXpwXNFUGiU9TXUKPm8IlVr6uPVzVl+Ecl85x g== X-Received: by 2002:a05:690c:4b11:b0:81c:872a:5152 with SMTP id 00721157ae682-81fd4bda24fmr19207437b3.30.1785535230071; Fri, 31 Jul 2026 15:00:30 -0700 (PDT) Received: from localhost.localdomain ([185.98.168.14]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-81fcd0d5ed8sm15067767b3.24.2026.07.31.15.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 15:00:29 -0700 (PDT) From: Demi Marie Obenour Date: Fri, 31 Jul 2026 17:54:47 -0400 Subject: [PATCH v5 07/19] host/rootfs: serial-getty-generator: Use cgroups MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260731-cgroups-v5-7-b325bac9d34f@gmail.com> References: <20260731-cgroups-v5-0-b325bac9d34f@gmail.com> In-Reply-To: <20260731-cgroups-v5-0-b325bac9d34f@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785534880; l=2539; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=nR9qFCQWFAvzsDZYiGCA/g/s2k1xOXxarCkaGVbSiwg=; b=6HF+lWuBsQazU3ydMcGypm4NVeLepnQiCqfiXfZgYp8K4S7rb3AqEPiU7nsL+s/JN3oVCvdME R01rbcrRaNYCJ8ZY8UfKiczyv8TtLSvj2vMYctwYeauKNH6FzqcWvFg X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: MONQAECZFBMFFJ3Q6M7P47M53Y3OTO3G X-Message-ID-Hash: MONQAECZFBMFFJ3Q6M7P47M53Y3OTO3G X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Avoids concurrent execution and leaked child processes. Signed-off-by: Demi Marie Obenour Reviewed-by: Alyssa Ross --- host/rootfs/file-list.mk | 1 + .../s6-linux-init/run-image/service/serial-getty-generator/finish | 5 +++++ .../etc/s6-linux-init/run-image/service/serial-getty-generator/run | 4 +++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/host/rootfs/file-list.mk b/host/rootfs/file-list.mk index 3899d620717fc97f42e669e5313c4100dcf5b1cd..deb4937fe380ff143fc2aafccee1b846fe15b974 100644 --- a/host/rootfs/file-list.mk +++ b/host/rootfs/file-list.mk @@ -21,6 +21,7 @@ FILES = \ image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run \ image/etc/s6-linux-init/run-image/service/s6-svscan-log/notification-fd \ image/etc/s6-linux-init/run-image/service/s6-svscan-log/run \ + image/etc/s6-linux-init/run-image/service/serial-getty-generator/finish \ image/etc/s6-linux-init/run-image/service/serial-getty-generator/run \ image/etc/s6-linux-init/run-image/service/serial-getty/notification-fd \ image/etc/s6-linux-init/run-image/service/serial-getty/run \ diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-generator/finish b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-generator/finish new file mode 100755 index 0000000000000000000000000000000000000000..b1fb5799a949a5e69d5926a2145873da5f09e0a3 --- /dev/null +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-generator/finish @@ -0,0 +1,5 @@ +#!/usr/bin/execlineb -WS3 +# SPDX-License-Identifier: EUPL-1.2+ +# SPDX-FileCopyrightText: 2026 Demi Marie Obenour + +cgroup-purge $3 diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-generator/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-generator/run index bf66ab0878fc6d8e77ca71a4a89e50c139a6bb11..a1846a29cf55892127feb7ecfc0adcd12f0497bd 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-generator/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-generator/run @@ -1,7 +1,9 @@ -#!/bin/execlineb -WP +#!/bin/execlineb -WS1 # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2024-2025 Alyssa Ross +# avoid concurrent operation +cgroup-setup --leaf -- $1 piperw 3 4 background { fdclose 3 -- 2.55.0