From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 5DB47A3B4; Sun, 30 Aug 2026 06:45:20 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id C90C8A409; Sun, 30 Aug 2026 06:45:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by atuin.qyliss.net (Postfix) with ESMTPS id D4D42A373 for ; Sun, 30 Aug 2026 06:45:16 +0000 (UTC) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-836ce6cbe1eso25525217b3.1 for ; Sat, 29 Aug 2026 23:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788072316; x=1788677116; darn=spectrum-os.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Yxwff/vEd50ah9fr9ux9no4kiyf3boqGIMXiqs25SVg=; b=Lv6aNvetkTipXIGeDWjyeEXUj6sDwtkse6SKxfZhZmoBP3H2vdrLlSILHXKLgOjVW3 bPblDn5aDuk7x5q5SaCePZXQ/wUeSPJIgVPRdKbmk/6UMwt9sVTkctWghXopvZZM6G/B sMtk34mg7iPqpf5DLPM7pu8xj4mI0/s+JBlnTBsMwVdvG8zaF903sM2P4Xtm1Q4zYCrv kuaXTXIXYrDeKNeH9XfNmSq1xrOF5BzZh49qZqRM6JimaP+TXConjfFQyeudGdttg6nz 2z/foYZM8fUdclvwF40Em4yc5aoQ5R1QHjEVJcPRaP4XIhgnpoKMAyeALXyQBhdKANSy YaFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788072316; x=1788677116; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Yxwff/vEd50ah9fr9ux9no4kiyf3boqGIMXiqs25SVg=; b=j+k00+kWNUmklsGd+HoCDBW71griGy1h210SbvssDzFmJJFWDipEUuYRp1ogP4IAXy rMLqrgH5LfHPgNBQBssF0tAOEfE0z6UVDUea/ZSpTiJS5RUMrSw7VA6UjF7hGj8RHNvw cjZw1JItM2DHMEDRX/7iDuSrSqMcojYFQkNGXsx9PDdXX+N7TmMuazSiMRBdd9F6JI6O TMhrb0+bU5/b9u0+FjIvYv0cmhTbso/eW0Giw5ikIID+qxlJ1kJJSnxphQXL17kAQOeI k2XqO/q2pg9ENEJa4XMsEM/Gex0VRtTmYjh3gU12MZXxWXMZpa0ga1MhReuIZK2lNU9v MPKA== X-Gm-Message-State: AFuF++lgpZ/lXE0w8LeR9dk58Wj/3ECO41cn6lhJq5W11U1EfVPtw/G4 ciuIqtn26RPjkH1I2OMOXInQcAYDdWjC2aTlXZ2BSSYdCBiljN6fuIeLKoX7kg== X-Gm-Gg: AYBFou0DtOC/KV/KwyAaVxQ5skOCwn9VYoeCzAGy7qAbUpu5Skd6uB7iVQTydxn7WUB ATiBHTIKOsU9EIOPDnFd0Y6zDl6k8TcMRKOSTCWq4ZHdskWZphuQGvpE2JQutZ4UmjxBacjluny XcLkbaI7ayM+a0i6ezWMO0qtzPx/cTvcZM6bCHHtY92c5wi1VYJXcuaBdfgbw2+V/YE8Vb+XtUl J9cgubbaIjkDcAf+meXzokO/RYMJaD/ANRPQzeKNb+571HzyjWyiPIGMJJKXD4SeWIWZATGNGZi FWW3RcsJ8pRoaAaB2Aegv+yov3C1fav2iVqOyI/ekFkrtJbwXLXOWJdRitoW+oYqoJUpQJPDQv9 kimT142qKrM+MG5H5KfxA3kM0uHKOdvWsN8Sy0SDqakbDWg73BEYbk0Yy8ZJr9N6MSEUucpxwgE kvcpf2b4ikxylYn1Xp2og928DgeP5fh+nalZBTnusQ6C6BWmCZJ45RkJ5pfT2TZamRBVc2k82Nt g== X-Received: by 2002:a05:690c:f13:b0:858:ad19:324d with SMTP id 00721157ae682-85d67df459fmr66236537b3.3.1788072315655; Sat, 29 Aug 2026 23:45:15 -0700 (PDT) Received: from localhost.localdomain ([185.98.168.14]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-85e66abb13asm30055537b3.36.2026.08.29.23.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Aug 2026 23:45:14 -0700 (PDT) From: Demi Marie Obenour Date: Sun, 30 Aug 2026 02:06:39 -0400 Subject: [PATCH v8 05/18] host/rootfs: Add comments where cgroups are intentionally not used MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260830-cgroups-v8-5-239b09ba7013@gmail.com> References: <20260830-cgroups-v8-0-239b09ba7013@gmail.com> In-Reply-To: <20260830-cgroups-v8-0-239b09ba7013@gmail.com> To: Spectrum OS Development X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788069995; l=5928; i=demiobenour@gmail.com; s=20250729; h=from:subject:message-id; bh=RsuuUf1MhysdYf1w8kzKgPlrGHn0tticre7xv+Ha7ds=; b=LVoC5eKe5waVAYuNLpQd6kqdZh1SSgUxGiG/CBjzx3tkzQXtosL2AxREfThsT8pvaVLeKdSrF 1Zgv0yAuGWsDU+8exyDT9JObWlMm/Z1bRg/FqlpqGUymZo9rvS3hV8Z X-Developer-Key: i=demiobenour@gmail.com; a=ed25519; pk=X57Q4/YQDj9t4SBeKaDwvXYKB6quZJVx/DE2Ly2out0= Message-ID-Hash: BELHWVIBZI43XWZANCDZGGK7ZNXAMTNG X-Message-ID-Hash: BELHWVIBZI43XWZANCDZGGK7ZNXAMTNG X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency CC: Demi Marie Obenour , Alyssa Ross X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Most services should use cgroups, but some do not. Signed-off-by: Demi Marie Obenour Reviewed-by: Alyssa Ross --- host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run | 1 + .../etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run | 1 + host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run | 1 + .../image/etc/s6-linux-init/run-image/service/serial-getty/template/run | 1 + 8 files changed, 8 insertions(+) diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run index 4d2cd7172e887e90d9ce87489cdacf41e51f77e8..5b2421a3dedf7c282ea818f4064535d0fc29d511 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty2/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty2 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run index 06abf5422365ff4edc9379e5cbcab716e6830399..3ca382f76368174ee1f99ea880827958c57b602c 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty3/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty3 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run index 3dd235fc93d403fc8971e923ec62cb025684b67a..983bd82927e468bab6ae20f61411680d173e4924 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/getty-tty4/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross +# no cgroups so that nohup works getty -i -n -l /etc/login 0 tty4 linux diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run index 86b9a1ef70300de52f33a84cbfac22a77e00df36..fb55327dff5f189f543fb3629702caad9ff247e2 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/root-terminal/run @@ -2,6 +2,7 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2025 Alyssa Ross +# cgroups make no sense here s6-ipcserver-socketbinder -a 0700 /run/root-terminal if { chown wayland /run/root-terminal } diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run index 327f4ccc5056e7ef87c089e666090307845cae3a..a6733604e91692f8440fd68efeb1a6b7378be167 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2023 Alyssa Ross +# cgroups make no sense for shutdownd s6-linux-init-shutdownd -Bc /etc/s6-linux-init diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run index 8f7bd889e50d76a49b98d8ba9e2c6172f287277c..cf3f5c7b499d997fd426062651eca64b3accc146 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/s6-svscan-log/run @@ -2,5 +2,6 @@ # SPDX-License-Identifier: ISC # SPDX-FileCopyrightText: Copyright (c) 2015-2024 Laurent Bercot +# cgroups make no sense for a logger redirfd -rnb 0 fifo s6-log -bpd3 -- T /run/log diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run index 78f794202bf174f3c036f3e20755ac087a988277..8fb1b6779c0bb1e3cdf67d1fa14722caacc25994 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2023 Alyssa Ross +# No need for a cgroup here. s6-svscan -d3 instance diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run index f3ed9a7f08e60206afd222f4fc02c5fb19527561..775b828c72b9d73bef8a3355fb3ae0536975f474 100755 --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty/template/run @@ -2,4 +2,5 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2020-2021, 2024 Alyssa Ross +# Don't put this in a cgroup. We want nohup to work. getty -i -n -l /etc/login 0,115200,57600,38400,9600 $1 dumb -- 2.55.0