patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Alyssa Ross <hi@alyssa.is>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] host/rootfs: add mount-userdata command
Date: Sat, 13 Dec 2025 20:35:19 -0500	[thread overview]
Message-ID: <22aa00ea-9732-4607-bd7f-e2423c25c4ac@gmail.com> (raw)
In-Reply-To: <87tsxu641a.fsf@alyssa.is>


[-- Attachment #1.1.1: Type: text/plain, Size: 1212 bytes --]

On 12/13/25 05:59, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
> 
>> On 12/12/25 16:48, Alyssa Ross wrote:
>>> diff --git a/host/rootfs/image/usr/bin/mount-userdata b/host/rootfs/image/usr/bin/mount-userdata
>>> new file mode 100755
>>> index 00000000..e4a873c0
>>> --- /dev/null
>>> +++ b/host/rootfs/image/usr/bin/mount-userdata

(snip)

>>> +}
>>> +
>>> +multisubstitute {
>>> +  importas -Siu 0
>>> +  importas -Siu 1
>>> +  importas -Siu uuid
>>> +}
>>> +
>>> +case $uuid {
>>> +  "" {
>>> +    fdmove -c 1 2
>>> +    printf "%s: '%s' does not have a UUID\n" $0 $1
>>> +  }
>>> +}
>>> +
>>> +if { mount -m -o nosuid,nodev,noexec,nosymfollow -- $1 /media/${uuid} }
>>> +printf "%s\n" /media/${uuid}
>>
>> Do we really want a mode of 0755?  Also, I believe Spectrum should
>> use noatime.  This avoids a burst of unsharing of snapshots due to
>> atime updates.
> 
> Will applications be okay with that?  What do OpenSUSE/Fedora do?

I'll check.  I suspect they use relatime, but performance-wise I
doubt it's a good fit for snapshots of frequently-accessed volumesthat
rarely get written to.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-12-14  1:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-12 21:48 [PATCH] host/rootfs: add mount-userdata command Alyssa Ross
2025-12-12 23:02 ` Demi Marie Obenour
2025-12-13 10:59   ` Alyssa Ross
2025-12-14  1:35     ` Demi Marie Obenour [this message]
2025-12-13 12:31 ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22aa00ea-9732-4607-bd7f-e2423c25c4ac@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).