patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: "Mantas Mikulėnas" <grawity@gmail.com>
Cc: systemd development <systemd-devel@lists.freedesktop.org>,
	Spectrum OS Development <devel@spectrum-os.org>
Subject: Re: [systemd-devel] Non-idempotent RUN+= scripts
Date: Wed, 24 Sep 2025 16:46:54 -0400	[thread overview]
Message-ID: <290988e7-6a18-43b7-bd90-4e518f463c5c@gmail.com> (raw)
In-Reply-To: <CAPWNY8Wos_OW7x5UjLp1GCwr37n9SMmN4nJ496VXH7oGsuXRXg@mail.gmail.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1826 bytes --]

On 9/24/25 13:46, Mantas Mikulėnas wrote:
> On Wed, Sep 24, 2025 at 8:27 PM Demi Marie Obenour <demiobenour@gmail.com>
> wrote:
> 
>> There are cases where a RUN+= script needs to do something
>> exactly once each time a device appears, such as binding a
>> different driver to the device.  If the udev rule matches
>> based on a property (such as PCI device information) that
>> is set only by the kernel, is it okay to use ACTION=="add"
>> in the rule?  The only other options I know of are to either
>>
> 
> Such events can still be caused by the admin doing "udevadm trigger
> --action=". Not sure why one might do that, but probably better to not rely
> on nobody doing that.

In *this* case that should never happen, as Spectrum OS's host
is basically an appliance and ideally nobody would be able to
run commands like that.

Will an ACTION=="add" event always come before any other events?

>> 1. Add additional code to the script to make sure it is
>>    idempotent.  This might require adding a lock.
>>
> 
> Maybe not necessarily a lock as I *think* udev event processing is
> serialized (for a given device at least); a flag file in /run or an xattr
> on the /dev node might be enough.

These are PCI devices with no driver.  The difficulty with a flag file
is that it needs to be reliably removed.

>> 2. Use a persistent daemon.
>>
> 
> It might be possible to have a persistent Type=oneshot .service via
> ENV{SYSTEMD_WANTS}, with RefuseManualStop. Not sure if that's a good idea.
I'm not using systemd as PID 1, so this definitely isn't an option :).

It seems that a persistent daemon is the technically correct way to
do this, but it's a lot of extra complexity.  That's unfortunate,
but it somewhat makes sense.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-09-24 20:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 17:26 Non-idempotent RUN+= scripts Demi Marie Obenour
2025-09-24 17:46 ` [systemd-devel] " Mantas Mikulėnas
2025-09-24 20:46   ` Demi Marie Obenour [this message]
2025-09-25  4:30     ` Andrei Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=290988e7-6a18-43b7-bd90-4e518f463c5c@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=grawity@gmail.com \
    --cc=systemd-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).