patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Alyssa Ross <hi@alyssa.is>, devel@spectrum-os.org
Subject: Re: [PATCH] release/checks/integration: add nc timeout
Date: Fri, 31 Oct 2025 20:50:12 -0400	[thread overview]
Message-ID: <291ef18c-871a-4071-a82e-c45f23f9a8ee@gmail.com> (raw)
In-Reply-To: <20251031111358.39096-1-hi@alyssa.is>


[-- Attachment #1.1.1: Type: text/plain, Size: 1590 bytes --]

On 10/31/25 07:13, Alyssa Ross wrote:
> I recently saw a transient timeout of this test.  Looking at the logs,
> it seems like, before netvm was rebooted, nc was already running, and
> that nc never failed, getting stuck.  Presumably, if it had failed,
> another nc run would have connected successfully.  Avoid this by
> setting a 2 second timeout for nc to ensure this eternal hang can't
> happen.
> 
> Reported-by: Demi Marie Obenour <demiobenour@gmail.com>
> Link: https://spectrum-os.org/lists/archives/spectrum-devel/f52c1aa7-96c0-462b-9287-0dbbae037e4f@gmail.com
> Fixes: ae45978 ("release/checks/networking: init")
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
>  release/checks/integration/default.nix | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/release/checks/integration/default.nix b/release/checks/integration/default.nix
> index 340fb6e..81db264 100644
> --- a/release/checks/integration/default.nix
> +++ b/release/checks/integration/default.nix
> @@ -19,7 +19,7 @@ let
>      type = "nix";
>      run = writeShellScript "run" ''
>        set -x
> -      while :; do echo hello | ${libressl.nc}/bin/nc -N 10.0.2.2 1234; done
> +      while :; do echo hello | ${libressl.nc}/bin/nc -Nw 2 10.0.2.2 1234; done
>      '';
>    };
>  
> 
> base-commit: b1bb4e5050b09a8edcafc0cf1b1b9c9ab42832bc

That looks good to me.  I would have expected a TCP timeout, but I'm
not surprised it didn't happen.  nc might even explicitly disable
those unless a timeout is set.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-11-01  0:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31 11:13 [PATCH] release/checks/integration: add nc timeout Alyssa Ross
2025-11-01  0:50 ` Demi Marie Obenour [this message]
2025-11-02 12:44 ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=291ef18c-871a-4071-a82e-c45f23f9a8ee@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).