From: Demi Marie Obenour <demiobenour@gmail.com>
To: Alyssa Ross <hi@alyssa.is>,
Spectrum OS Development <devel@spectrum-os.org>
Subject: Re: 'make clean' followed by 'make' in the same Nix shell doesn't work
Date: Tue, 5 Aug 2025 15:09:13 -0400 [thread overview]
Message-ID: <35c65948-8987-4367-9b65-5022c297f3f3@gmail.com> (raw)
In-Reply-To: <87frefdvng.fsf@alyssa.is>
[-- Attachment #1.1.1: Type: text/plain, Size: 979 bytes --]
On 7/29/25 08:33, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
>
>> The following command fails to rebuild the image:
>>
>> $ nix-shell --run 'make clean && make run-qemu'
>>
>> The following command succeeds:
>>
>> $ nix-shell --pure --run 'make clean' && nix-shell --pure --run 'make run-qemu'
>>
>> Interactive Nix shells exhibit the same problems, and adding
>> --pure to the first invocation does not help.
>
> Works for me on 560fd87 in img/app. What were you testing? Logs?
I think the problem only arises when there is a dependency that
default.nix knows about but the makefile doesn't. nix-shell
appears to import default.nix directly, so
$ nix-build default.nix
inside a Nix shell does not update various paths (like the path
to the kernel) that the makefile needs.
I think it would be better for the makefile to import the
variables from Nix if possible.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-08-05 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 18:49 'make clean' followed by 'make' in the same Nix shell doesn't work Demi Marie Obenour
2025-07-29 12:33 ` Alyssa Ross
2025-08-05 19:09 ` Demi Marie Obenour [this message]
2025-08-05 19:33 ` Alyssa Ross
2025-08-05 19:47 ` Demi Marie Obenour
2025-08-31 11:01 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c65948-8987-4367-9b65-5022c297f3f3@gmail.com \
--to=demiobenour@gmail.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).