Re: [PATCH v1] crosvm: Rename `--vhost-user-gpu` flag in checks

[Dom Rodriguez <shymega@shymega.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

On 11.11.2024 11:46, Alyssa Ross wrote:
>Dom Rodriguez <shymega@shymega.org.uk> writes:
>
>> Following on from c9052a4, Alyssa quite rightly pointed out the
>> remaining `--vhost-user-gpu` invocation in the release checks (Wayland).
>>
>> Same principle as c9052a4, just one more replacement to the crosvm flag.
>>
>> Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
>> ---
>>  release/checks/wayland/default.nix | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>Thanks!

np

>
>I had to edit the commit message a bit, because c9052a4 is not a commit
>I have — I'm guessing it was your local version?  The hash will change
>when I apply a patch because the committer will change, trailers will be
>added, etc

It was, yeah - thanks for the correction.

>While I was there I also changed the subject to conform to the normal
>Spectrum convention of prefixing commits with the name of the component
>they're changing ("release/checks/wayland" in this case), which I forgot
>about on the last one. :)  (For single commits that make changes across
>the tree, I just don't use a prefix.)

Ah, gotcha. Idea for the future: pre-commit-hooks.

Best wishes,
--
Dom Rodriguez

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]