From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id A4E141ABC0; Wed, 13 Nov 2024 09:00:22 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 138DA1AB5C; Wed, 13 Nov 2024 09:00:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=DATE_IN_PAST_06_12,DMARC_NONE, KHOP_HELO_FCRDNS,SPF_HELO_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazlp170120005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::5]) by atuin.qyliss.net (Postfix) with ESMTPS id 246F81AB49 for ; Wed, 13 Nov 2024 09:00:10 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i7tZndceLnBwez6M57tzToGeQMS2faTCx0ZynXN/oWOyyQ/CCoSYlsoPJrYpaF7Ud9HMdB6pON4fPinMdFcwBrK/sHR20R3LvbK5PnVcdeKzp2JkI9BaLoBLY5ZIzkyiq/y9DwJw3AcQPuzT0SNdnmXMf+KBll2NuVDwyK0ES7SOolSqvs0U45Fs4A1GlBFaZamreWMRV8Ka6ctToQZePPKQTTZqG/PLV+OA16WFDPk9KhLcyXaocyw0ThsmzWOf7T3RuwJwZU/X2G3zl+R5wB0n9jeJn9mYy+pAWgYZAqwLYTJeIkDTZHciw3XDlL3bk9MrZsxNv9gJuoM0g0RLeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7gnOcWnCyjLDOsSl2JvUMi3m3HQo43PRqifJ2EfoME=; b=HFm5ye9EZVqLTd06nLnaL0uwcN3T/uPjHc5UtqQaInvf2XpuUt8zsReyv3DP/DmFZqzCy7H+9jv1GUkrueTYnii4r63PS2gSIRb3IXSPVC7tIQHNqLae+iqQJKQBDUnqvU5BDsIIRwDfFFuKBNdKepl8f0mr+/9kdXi2z3cPK2ZBbIDw/IJruWVE7uFMiBcwCSMely8tqtBFcm3kKy1X3hESc7VI5CIi2yDFscqZDNtvAR2ywa3iZ07fEQVeDZcgu5/2unSYwBGVf8lb4RMOKk1QLeyJi3AKUgLMVUYCQvxotIQCOsnhhI3eV6GCCKek3zcZBAcDMZbxGlUkFjHzCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7gnOcWnCyjLDOsSl2JvUMi3m3HQo43PRqifJ2EfoME=; b=StNWYzYRpIs2SWQvYLrOYRi/+jzLxjHuICupNjVU0PwA8Cw8LwyBwn3XK1Dqh/SYnof1H8gOZoumZ5B4KLGhvzwgdukvve+DfAsaE2JyJAGAGBJGGd+US6kA390GCA2IMjMAiwkOq+HlPKjj4j6LCvMvMFtmZEcrtwnZ1z6yWYr3I9hAw5ieZmO+EOB/IUtTkzFrYd2xqK2MXEVhVFyB8nwpL3pHNTCwP+ZNa/8A4TLg2juI7gFDGQjt3+dPP8KZGXEQevedV7Zw5OPVvvwXC4nXuMUgrjqbOTUhlpN6NvJu9H++zQnKwS3jjehYGBie4QuDuWzex2bC8rc01nUzAw== Received: from LO4P123CA0617.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::18) by CWLP265MB3044.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:d0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.18; Wed, 13 Nov 2024 09:00:02 +0000 Received: from LN2PEPF000100CB.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:314:cafe::e4) by LO4P123CA0617.outlook.office365.com (2603:10a6:600:314::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29 via Frontend Transport; Wed, 13 Nov 2024 09:00:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by LN2PEPF000100CB.mail.protection.outlook.com (10.167.240.5) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Wed, 13 Nov 2024 09:00:02 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id 174E9ACA0056; Wed, 13 Nov 2024 09:00:02 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id 518411083B7; Tue, 12 Nov 2024 22:19:37 +0000 (GMT) Date: Tue, 12 Nov 2024 22:19:37 +0000 From: Dom Rodriguez To: Alyssa Ross Subject: Re: [PATCH v1] crosvm: Rename `--vhost-user-gpu` flag in checks Message-ID: <43ligvishb4p3eccjeil47iwashqgn6mh2vrkqw3whmkssp2un@i46gvf2d6wha> References: <20241111012846.3137729-1-shymega@shymega.org.uk> <87zfm6caji.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="muxxdj4e3idbvcvs" Content-Disposition: inline In-Reply-To: <87zfm6caji.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LN2PEPF000100CB:EE_|CWLP265MB3044:EE_ X-MS-Office365-Filtering-Correlation-Id: 7054a3d7-6a11-44e1-0f4d-08dd03c18f54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?anJpa2w3Ym1lOXNiaWdiN1VDVVhGNHRDdTVZQUxXVzFIVDRMTHRJOThpdGZk?= =?utf-8?B?cDQ3YUN0dEczK2RIZEowT3QxS293RXhuR2xkeWtSekJXbXdzZjZDRTBGdlNp?= =?utf-8?B?ZXJvS2ZITFhTelZXRmZMajZyamlsa01rbnV3NGhEM043NGxMRWRNOXNiK0Qv?= =?utf-8?B?dWRwTEhZbjkxQ29OS2tBRnQ5WElvQ2Z6TE14ZXhVbnladGczUXRIZnVqQU9M?= =?utf-8?B?dG9PRkdaVkc0cW94dmVlQWJ5amY5QmJxVnc5MDluNVkwQ05Fc2phL0RMRGRv?= =?utf-8?B?eklnMTNmU1FWcDFNcHZjSDBhMUZtUWpGSThJSzM2SEVFR0NDTzhhSWtzK0dn?= =?utf-8?B?OFpkTGhZNjV6M1JjQVBpQ1EzQTltM2RNYWVUSW1yNHhLK3N2TURXMTdxMGti?= =?utf-8?B?aXFkVmFjNE5qY0N2elU3clNvUm9GQVA5QnlTTUtnSzZacVNlTmhVNWFLeWV2?= =?utf-8?B?aVVJbHJZc0ZieHFxVWdwbCtpYXRDRmZlcGxYLzRFTWNLcUw1WWF1Sm8xUUNJ?= =?utf-8?B?emgyS0dEeG1TTTNFMm96a1VvUVVzSitHbXRFaFlXOUJvRGdSLzU0T2JHbE5G?= =?utf-8?B?NzkxdTkxeEhNK1dkeUh3Ym81QkFDdE51WUpNNnVzUmE5b1lMMG9KdW5QNjFJ?= =?utf-8?B?a2w2UGFpNlA2Sm91WW50d3dUNHJCbXhRRHFsQWxzOTEzS1NHSExJQThPT29m?= =?utf-8?B?RGFMV3kzaVl0VlJGRk5nbjAzZ3dRcTVHRmtuei81cGhxWXF5TnlyYWVnUFY4?= =?utf-8?B?UGloM3BURjFzN0hyb2VmVWhpRGFzMnFIUjh4TUhjY2dDa2hzMFJqTXJYaVFN?= =?utf-8?B?V0Z3clpDWUZKaUFKRUpaaVduQ2RKYWVNQ1dnbXRqbExNVEJndUgzRUpQRnBi?= =?utf-8?B?OVFnSlRnWVludExqcHVmeGhKMFd0MUJJR2tob2hNR1lqdVJodCtEL3hvQWRh?= =?utf-8?B?R3l1c2E4ZXdQKy9pQVdCekMrTFRoY1VhNkZGUURVcHpvUlY4NW9aTWk5K2h0?= =?utf-8?B?VTE4THFQUGgwbVlOYmJETGRUUVNsWCs5NkROczhpU1ExODZxL0VkY3krOVdI?= =?utf-8?B?bXNlSWNZdXBqSW8vRVFXMUJocTBwbVdNWG5la2hoQmFhU2dWN3RkbGVhRitJ?= =?utf-8?B?bWFxRjM3VnA5RDRPTUVDbmVhL01NWVJKNkVQVWVoL2x5SmlPL3U3Y3NZSTFO?= =?utf-8?B?WjQza2xHUzFaTU5vZWJpaEFSL3E5WXFndmJlMHU0LzRUOHhuQUNDSHhWRUJ4?= =?utf-8?B?Mm82OFUyUXNSOE9HZCtHUENBU2JPNUdPZW5rZHpJeFZsaEVpaFY4NGsyc1dy?= =?utf-8?B?RXUxVGNDMmN5MDEzZTJaNGZCNmNBWDVFNk5CMGhmdUY3cnZwMU5NdnZ1dE5H?= =?utf-8?B?QXV0T250SERpL0s5UGlDeGpzN01kdFFWQi9keFRIbXZDVWdMS3VlMnp2RFhv?= =?utf-8?B?Q2txcHN0QmtKbU5RNmsyeU55blk0VWdNOTVlcXpkZDRGZitZYzBoRHNGcnlr?= =?utf-8?B?aGlpNDFSK2ZTNVNWRWdQdFY2SHNMZGlDSlhLckdTK2dKMmRSUmFkTUkxb1Bq?= =?utf-8?B?cUhBbHlXOE5OVTREelpleFEvdDZXczAxeDZaa2VkYzVuK2tacmlnaUxBZTBC?= =?utf-8?B?WXZkdi9mTlBKR09VN0RnWlN4aGFZSCthTEpJODlWYzl6bnV5bTZHMzdhdzZk?= =?utf-8?B?bG9IQTYzWFZ3L1BpaXA4czA3U0tUUkREZGJ3VXlRRUxyL01ZaXZ0ZU5sK1pT?= =?utf-8?B?SGtDSmZLOG85ZXZGdXdrNlVWVjJUdG40SWhES1A0VVNLTjhyWjlhK3REMkF3?= =?utf-8?B?QWhIOVZEYzM2M3IyN2VqTWJWWmllUkthWW5GZTFlUDVhVVNWRzczK1BNajZV?= =?utf-8?B?YmVqVVNYQnFBOUx0VmwvVVNkaVhwRm56WFNuUlF0QTdqYXc9PQ==?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2024 09:00:02.4075 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7054a3d7-6a11-44e1-0f4d-08dd03c18f54 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: LN2PEPF000100CB.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB3044 Message-ID-Hash: 4EUJBB7GJZYJIFBMQELUSHIISV5SQ5GC X-Message-ID-Hash: 4EUJBB7GJZYJIFBMQELUSHIISV5SQ5GC X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --muxxdj4e3idbvcvs Content-Type: text/plain; protected-headers=v1; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1] crosvm: Rename `--vhost-user-gpu` flag in checks MIME-Version: 1.0 On 11.11.2024 11:46, Alyssa Ross wrote: >Dom Rodriguez writes: > >> Following on from c9052a4, Alyssa quite rightly pointed out the >> remaining `--vhost-user-gpu` invocation in the release checks (Wayland). >> >> Same principle as c9052a4, just one more replacement to the crosvm flag. >> >> Signed-off-by: Dom Rodriguez >> --- >> release/checks/wayland/default.nix | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >Thanks! np > >I had to edit the commit message a bit, because c9052a4 is not a commit >I have =E2=80=94 I'm guessing it was your local version? The hash will ch= ange >when I apply a patch because the committer will change, trailers will be >added, etc It was, yeah - thanks for the correction. >While I was there I also changed the subject to conform to the normal >Spectrum convention of prefixing commits with the name of the component >they're changing ("release/checks/wayland" in this case), which I forgot >about on the last one. :) (For single commits that make changes across >the tree, I just don't use a prefix.) Ah, gotcha. Idea for the future: pre-commit-hooks. Best wishes, -- Dom Rodriguez --muxxdj4e3idbvcvs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQS8QbGzuJNwWBsvCoTK0brmh9AFqwUCZzPUeQAKCRDK0brmh9AF qznAAPwIA8KboVo0C/YBUZaThDMhlwtCS8NCls8aDCYMiWgbawEAtBzLDrCuk82g 1HTs3Te3Wj3Or7jDAwTrsy0VtI0GtgQ= =r3Ap -----END PGP SIGNATURE----- --muxxdj4e3idbvcvs--