Re: [PATCH] tools/xdp-forwarder: Fix build

[Demi Marie Obenour <demiobenour@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1064 bytes --]

On 10/4/25 11:47, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
> 
>> Clang complains that it can't fine gnu-stubs32.h.  Drop the ICMP parsing
>> code to avoid this error.  No functional change as the code is not
>> actually used.
>>
>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>> ---
>>  tools/xdp-forwarder/parsing_helpers.h | 57 -----------------------------------
>>  1 file changed, 57 deletions(-)
> 
> What did you do that produced this error?  We're supposed to have a
> reproducible environment, so something is going wrong if you're getting
> errors others don't.
> 
> As previously discussed, we don't want to modify these headers, because
> then it'll get harder to sync them with upstream.

For those not on the Matrix discussion, the problem turned out to be that
the BPF code included libc headers for the target CPU architecture.  When
building for arm64 this happened to work, but when building for x86_64 it
reproducibly failed. 
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]