From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id A636D61298; Tue, 20 Sep 2022 11:46:27 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id E628F611F9; Tue, 20 Sep 2022 11:46:25 +0000 (UTC) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by atuin.qyliss.net (Postfix) with ESMTPS id 21F5B611F7 for ; Tue, 20 Sep 2022 11:46:24 +0000 (UTC) Received: by mail-lj1-x235.google.com with SMTP id h3so2692143lja.1 for ; Tue, 20 Sep 2022 04:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=QSIHs9V9eNNIDIVzl+ppXSTLPDgXIuxNecdJ/LJrFO4=; b=ZXnBtrFTm4K2kE3gK0UIp6CQTDspVEofZRJTXUEbLP5VraasO3cHlliqb2vVeAVjVQ VYPLq3zgBxoAanrxlVX9tUk9vesZz4S2SlUD5laBk9bFdFaUHW0q7stAzBcPvkWXTcoF bq33NiKWfJavsbb8LGqzpuOvoAlzzfyWGOJztckTmNCl3DLkGzlISRjNI4e9pyGz6tCO mPdPYU3q3svQaqgZTjExZcPbSYc4KDgnUXmb6yyWmXNY+OJWaoo+CrXjlazylAHA7pti 3YeNJHhIelboY14Fp/FYc7ZRQ4MzGLtKSgfBwLptOsGVYs0jzgSyqbCIM1KdN3EA+ynh 5JwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=QSIHs9V9eNNIDIVzl+ppXSTLPDgXIuxNecdJ/LJrFO4=; b=Zllk7t+f1loLmeEDKkGFSr1P7Q6i+S34oC+71ElXnTs9oxH0d8F6ek5xzDauURH0BL YHaqgHBB6TdgHXsMnE0P3YW6Mzq5bTDmuew65irA/ALGFMJRRsaKSUXUYNEJd7c3zp9e 8/R9dPnhM7I4n2ULVyKgqKfsNxzrrQlmsVc83hJ8HWoC8Sjo5nwHLJqipThrckEH/wy/ wYMdf5zM45SoCMFf3r6dr2Z1XP1I7a+fSjfbCAJnJnHBunfvaqBhlMKH65T/PVqkIFIU Fr4gKzwYZ1vJ6L+x76aWbjGa0ttJYnOdlG+DDqYPlD/XWczHZmaiHMzFx4uHOeVSsZND +3gA== X-Gm-Message-State: ACrzQf2UlPSymjjWU9DtYLgzZP9sUsnsQI3dhcEgbZNVihqRBsbs451N 1/njH4ZwW5WA5k32zrz18EFW7A== X-Google-Smtp-Source: AMsMyM5s2lI+kAOnY81hMF2oS50qBc5PmNU2DTjPjKIsAhwxX+tkkVMNl9OEslrasZjtKe3FUN9ZYw== X-Received: by 2002:a2e:8904:0:b0:26b:e97e:d85b with SMTP id d4-20020a2e8904000000b0026be97ed85bmr6881225lji.7.1663674382037; Tue, 20 Sep 2022 04:46:22 -0700 (PDT) Received: from [192.168.1.26] (mobile-access-567351-194.dhcp.inet.fi. [86.115.81.194]) by smtp.gmail.com with ESMTPSA id be39-20020a05651c172700b0026bca725cd0sm230704ljb.39.2022.09.20.04.46.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 04:46:21 -0700 (PDT) Message-ID: <509b7100-998a-a7e9-a8a4-61312af67767@unikie.com> Date: Tue, 20 Sep 2022 14:46:20 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] fix: config support with vms Content-Language: en-US To: Alyssa Ross References: <20220920110958.2548848-1-ville.ilvonen@unikie.com> <87fsgmmgdf.fsf@alyssa.is> <1263b0d5-14f7-9650-7823-70da02f42c5d@unikie.com> <87bkramfvn.fsf@alyssa.is> From: Ville Ilvonen In-Reply-To: <87bkramfvn.fsf@alyssa.is> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: HKVLIIEY3PMLBOTOHZM4LIECOD725RGZ X-Message-ID-Hash: HKVLIIEY3PMLBOTOHZM4LIECOD725RGZ X-MailFrom: ville.ilvonen@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/20/22 14:42, Alyssa Ross wrote: > Ville Ilvonen writes: > >> On 9/20/22 14:31, Alyssa Ross wrote: >>> Ville Ilvonen writes: >>> >>>> with config.nix, the build of vms fails with >>>> error: undefined variable 'pkgs' >>>> .. >>>> 49| >>>> 50| kernel = pkgs.linux_latest.override { >>>> | ^ >>>> >>>> This fixes the issue for all default vms >>>> >>>> Signed-off-by: Ville Ilvonen >>>> --- >>> >>> Hi Ville, I was wondering how I'd have missed something like the default >>> VMs not evaluating, but indeed I'm not able to reproduce this. And when >>> I look at the default.nix files for the default VMs, I see: >>> >>> 50 kernel = buildPackages.linux.override { >>> >>> So unless I've missed something, I don't think this issue exists in the >>> current upstream. (I checked commit 3aa2f8a.) >> >> I'm not testing with default but with new config.nix support. >> Have you tested with any config.nix? > > I'm not sure I understand what you mean. config.nix support is already > present in the commit I tested. > > I created a simple config.nix file that just set "pkgs" to "import {}" > in case the presence of the config file made a difference, and ran: > > nix-instantiate vm/*/* img/live Interesting. I created a simple config.nix in the root of Spectrum source tree - https://spectrum-os.org/doc/build-configuration.html It only overrides the kernel - to imx8 - and sets crossSystem for aarch64. Build of vms fails without this patch. -Ville > To test evaluating VMs both directly and as part of the whole system, > and it worked fine.