From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 932341AF6B; Sat, 09 Nov 2024 02:00:37 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 30B561AFA5; Sat, 09 Nov 2024 02:00:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=DMARC_NONE,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::1]) by atuin.qyliss.net (Postfix) with ESMTPS id 67F641AF1A for ; Sat, 09 Nov 2024 02:00:14 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iC7ijSr8LYwy5/w/tz141OjQ3Z43rge+JNJu2EPuuuGewIRt7xtUeGc3Tx2i/mKtij8x5ac1gGR4ajyjczmc13Q1wBbzaKWJvwNolbGptXAvdf9VsSYPMhS6b7owjHD47u8HTUxwqszrS8jnLsEwGUOEIfstXwXOO7AuWAl96kH1ZWRXf2BUt2dp+t/vktyTiZiduJxaDq+pBsSJ9Rm/s++tqmhvQTcFRtWDqzpqKjAL1RS80Gez52NvSUXTtdTlYk86wJCe6HMKYH3caUfeGykjuskqxNruwpvzkZAffEslkP1WoJWNgdrKSaBanm8uqvij6lK4mzSIF0L1U2s7wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6bhbGvwOI7kdHxAadGjBXPjDXTFOxAf77TzBWTa8nzk=; b=uVwe4Nq1SHcMkX1eni8hM5ybHthJ9H8om5JNt3m51vIJwvRy+p7PVmOETfQ1l0Vhd4hWt/TFHSllz0HPtKCLoJzn0vO51am80PDF5wIDw3aNETVJU/GfSIAR2D8OSt4LX9n7rDS2DT1dv/Yiidqliu6IOpTM1ME4RtKocHqHCN64VHfhyRXbL9ljtTPyUx9VmN62qslmxVISIQzcvr8P45IYnj4/JLWmngFi/oikJonSjTEhuRq0Lh/6r00x98m/nbSLDC2c1fPvVIxzy5Fmkx+iIIT8p/2I2V0tzzgFfzRhJmLhiBOOBLGK0xyfFw6LQn5Ed7vM000Lq/mS+TlzVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=rodriguez.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=rodriguez.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rodriguez.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6bhbGvwOI7kdHxAadGjBXPjDXTFOxAf77TzBWTa8nzk=; b=Ir3kYOG9ctaZMDNzHO1v+x7QTKoRLZfYzwchLmJ5F4KWWBh/Wqy+DIFDY0gBoZaqzfCnsPPPe6bZafGWVjA/Ps1FtXC/5ZATSJpLVZWfeuoAvgZTBsS5A1xwNueRniDASWZu3RXx+SazdIH6TGya8Qv8LezW80u26k+rbeuB30iF3OhTSjJQIN/bTQSWhWZTvUqTO0BHVQ6m+UgM+TjaoGiaCx4ykiQcS5vFpZgxnpOe/NhSq2krRUQ7hfe0/tT4b5IeoIhZqD76bGNXLe0O4/nxj7y38ig7U5seja9CNF1zG12cdkzb+xH8452JYUKAilO1HfZV7k1lz7iDF0Nx1A== Received: from CWLP265CA0474.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1d4::12) by LO0P265MB6454.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2cb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.31; Sat, 9 Nov 2024 02:00:02 +0000 Received: from CW2PEPF000056BC.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1d4:cafe::4b) by CWLP265CA0474.outlook.office365.com (2603:10a6:400:1d4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.21 via Frontend Transport; Sat, 9 Nov 2024 02:00:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=rodriguez.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=rodriguez.org.uk; Received-SPF: Pass (protection.outlook.com: domain of rodriguez.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by CW2PEPF000056BC.mail.protection.outlook.com (10.167.240.7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8137.17 via Frontend Transport; Sat, 9 Nov 2024 02:00:02 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id BA4FAACA0054; Sat, 9 Nov 2024 02:00:01 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id F1F351088E6; Sat, 09 Nov 2024 01:03:55 +0000 (GMT) Date: Sat, 9 Nov 2024 01:03:55 +0000 From: Dom RODRIGUEZ To: Alyssa Ross Subject: Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args Message-ID: <5s7bk55k6d6vr6gywsx65pn2k7kqj5j4z722762vuqccey4yol@hx6vzlml76tg> References: <20240906224329.2336996-1-shymega@shymega.org.uk> <877cbnfmdf.fsf@alyssa.is> <87bk07am4z.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yftm5yjzndjaikzp" Content-Disposition: inline In-Reply-To: <87bk07am4z.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CW2PEPF000056BC:EE_|LO0P265MB6454:EE_ X-MS-Office365-Filtering-Correlation-Id: c8d717ba-2c1b-43d4-deb3-08dd00623921 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NG1BMmNFOS9OaDluSU5XeXA0SndZV01ncnVYblVtd285WGEramo0Uk9NUGdB?= =?utf-8?B?MnY4dGl2RVlRM0ZZTnduMVdNVWhwQjVXVTlnY3RHTXRkaHhMU3V4S1pkUWNP?= =?utf-8?B?Q1p0VDZyV2htVjFaTi9tNEVKMUhOZ1phYkJoeDNFZHZBeGY4MnNzWEoxSGp0?= =?utf-8?B?ZzlLZ2g4RHJJZW5DZ0FFTlMwNWMxSmZDS0RlN1oyT3NvTk5nK2lacU9vVHg3?= =?utf-8?B?VkMvejlUT0RydStLMVJRSEViejJBMWRJT1p2Wnl1TC9KL3FzdzdRNm1Ld1JI?= =?utf-8?B?K0NZbndwdStHQXo4dzVRWGFVVCtTNWN3RmVtdVZIZDNVbGRqcXBTT2dwZnBx?= =?utf-8?B?U05SNFJGbmtlV0JzaVVEVVVscmxBR2hGT3c2SndaRGQwSERiTzZIVnZKMk1l?= =?utf-8?B?NTBFc2JxMUczclE0Z1dmY3hXS09JbU5WT0lzVzFCUlRHTG0zTlo2Zks3cHJN?= =?utf-8?B?M28yVHpxM0pGcUg2L0FmNzVkWUUvcmUxQzJIamQ1YlhzUXNwWmNzYTJYUmx5?= =?utf-8?B?V3ZQLzlLdTlnb2hRN05MVzNYdVl2WWNIeG5sS3hnNEoyQmJUaU9PelRLeE5r?= =?utf-8?B?Qy84NGF1N2JpMHhTNzV6cEd4OTI0S3pJWFhYQmx1S3R4YWpsMWtuQXJteTBo?= =?utf-8?B?UWp0NmZlcTRacTF0TG5TeFNBWHZJRUF4NjJlR0ZHYXpTNDNLVGRZeDNpSjdM?= =?utf-8?B?bG96WjMzV1V3bk8wcUwyQzVXVVQyRzlzOG1QWWZQMk0zQ01vVVJJR1JielNJ?= =?utf-8?B?eEluRkJsdU12REJMTmZ4N2MvRmkrVEw5ZFpienR1OTNMR2dLVU9WN29rTkZE?= =?utf-8?B?YzA5Q3BvczUwcUZtUWZoWkF3ZkoycXpiNzc0dExDa08rWG9OV3lxdG1jd3Np?= =?utf-8?B?aUh5WTg1ZkN4Y0Qzbkk2emUzSEgwNlhHSjBIZ0hxTW1WOC81dzZnMnpDclAw?= =?utf-8?B?bHV1YUJDUFYwZUU1UHRPNnUyUHNxeWx3RzRFS09aWGI1cmZ1RWJHZkY2OVhq?= =?utf-8?B?K2EzcHlVSGpYVWFGaUh4ZnVQazlEb3djdzZvNnJoRzhUUTJkNFhKMDZtK0JC?= =?utf-8?B?dFQxbUZENWowUFJjWVZYUWhjSjgydUo4L2JoQ1BvV3I5MkJpUFZYM2hFdVhn?= =?utf-8?B?dXNremlUTTBxRk0wU0E4OXFieFJ5NGEva3BzTXJWeE9qYmwrY3FOMjFPVGdJ?= =?utf-8?B?NWZJSjZjVkFPaFB0Mm4vaDBNYk9ISTR5blJZMUlwYlMxL0dJbHpheWEybmVa?= =?utf-8?B?Y0RRVm81MXNzMkVhNFNBT0d6c3ZzZkxRY2UyYnRrNXlSemxvRndmSHY0UVg0?= =?utf-8?B?dzBGQ2RVZ0x3N2xTMGpwVXExUlY3c1dBYWNObG1JTXRkcnJGQkMzcjVCMDVZ?= =?utf-8?B?alBMYVpvOG9tbStrS2pDcG5LQy9nTVVnK0FFbTcxc3V3eXl5S3pFeFVDbklJ?= =?utf-8?B?V2I1Q1FCTXFyZThZYXBuTXpzQ3ZtQXU5dHhnamNLeC90dnJ5dGlIT3lTTG5u?= =?utf-8?B?YU95a1NsYjJMM3BpTjhoSE5td3hybGVuVElCMzNJR1FWRXo3TGQzb0h2Yzkr?= =?utf-8?B?YmVKMjV2Z1YyaEs0UkdNTFFqWEVoeXBlZHFHVjk0c1VzL2g2K3VFcWE4Wk1O?= =?utf-8?B?akRYaTJvMzFlOG13ckV6dVhjaHlyTVp5S1RBYk5MRW5ZOHNuajVVWXFJUUwy?= =?utf-8?B?aldTSW85ZVg4VnEvYXlVZUxINDVDVWNsYnM3VWVnWFFic2txM2sxdTJuNE1U?= =?utf-8?B?di9sbUNWMHd2bE1sZUUvTVJ3NFhCcU8ydS9FS0pEbVJ1R1I3Skk4eFk3ZGlG?= =?utf-8?B?VWJZV1NydFR0dW1ORGtnVHJzVzR1ZFlpaGNtbHpXQzAxYUUzSDJrVjY3TjF3?= =?utf-8?B?NExPSDZVSUE2ZytSSFBneFRBTFBBckMvUkM4NEFaUWZGZ0E9PQ==?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024);DIR:OUT;SFP:1102; X-OriginatorOrg: rodriguez.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2024 02:00:02.1169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8d717ba-2c1b-43d4-deb3-08dd00623921 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: CW2PEPF000056BC.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB6454 Message-ID-Hash: BWGVBFFWTI6L4AEZL4BSHCR57BK4J2WZ X-Message-ID-Hash: BWGVBFFWTI6L4AEZL4BSHCR57BK4J2WZ X-MailFrom: dominic.rodriguez@rodriguez.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Dom Rodriguez , devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --yftm5yjzndjaikzp Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 28.09.2024 16:27, Alyssa Ross wrote: >Dom Rodriguez writes: > >> On 07.09.2024 18:40, Alyssa Ross wrote: >>>Dom Rodriguez writes: >>> >>>> crosvm was producing warnings when using `--vhost-user-gpu` and >>>> `--vhost-user-fs`. >>>> >>>> In this commit, I have adjusted the `crosvm` invocations to look >>>> something like `--vhost-user $DEVICE,socket=3D$PATH`, where `$DEVICE` = is, in this case, >>>> `gpu` or `fs`, and `$PATH` is the path to the Unix socket. >>>> >>>> Signed-off-by: Dom Rodriguez >>>> --- >>>> img/app/Makefile | 4 ++-- >>>> release/checks/wayland/default.nix | 2 +- >>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/img/app/Makefile b/img/app/Makefile >>>> index 3adf8c4..11ef6e1 100644 >>>> --- a/img/app/Makefile >>>> +++ b/img/app/Makefile >>>> @@ -152,8 +152,8 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vho= st-user-gpu start-virtiofsd >>>> --disk $(RUN_IMG) \ >>>> -p "console=3DttyS0 root=3DPARTLABEL=3Droot" \ >>>> --net tap-name=3Dtap0 \ >>>> - --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ >>>> - --vhost-user-gpu build/vhost-user-gpu.sock \ >>>> + --vhost-user fs,socket=3Dbuild/virtiofsd.sock:virtiofs0 \ >>>> + --vhost-user gpu,socket=3Dbuild/vhost-user-gpu.sock \ >>>> --vsock cid=3D3 \ >>>> --serial type=3Dfile,hardware=3Dserial,path=3Dbuild/serial.log \ >>>> --serial type=3Dstdout,hardware=3Dvirtio-console,stdin=3Dtrue \ >>> >>>This is still not right, I'm afraid. >>> >>>When I run nix-shell --run 'make clean && make run' VMM=3Dcrosvm in >>>img/app, I get this error: >>> >>>[2024-09-07T16:36:32.592274891+00:00 ERROR crosvm] exiting with error 1:= failed to connect to vhost-user socket path build/virtiofsd.sock:virtiofs0 >>> >>>Probably the tag should also be a comma-separated key=3Dvalue option? >>> >>>(This doesn't have any automated test, because it's just part of the >>>development environment, and setting up a test environment to resemble a >>>development machine isn't trivial. Should be possible though.) >> >> It's bizarre. I've done some more testing, and it seems that >> `--vhost-user` isn't *quite* there yet on feature parity with >> `--vhost-user-fs`. Maybe I'm going wrong here, but it doesn't recognise >> the tag as a k/v option. >> >> I have managed to get the tests running with `--vhost-user-fs`, but it >> does look mismatched now. >> >> Would you prefer I revert the changes to `--vhost-user fs` =3D> >> `--vhost-user-fs`? > >You're right! I've just spent the last little while looking around >trying to figure out what's up here, and I think I've figured it out. > >In this commit[1] they made the vhost-user-fs tag optional, because it >can now be set with virtiosfd instead of the VMM. This is probably >good, because the more generic vhost-user becomes, the more hope >Spectrum has of one day not needing Cloud Hypervisor patches. :) So we >could try using --vhost-user fs for crosvm, and then passing --tag to >virtiofsd, but it'd need to be tested with VMM=3Dqemu and >VMM=3Dcloud-hypervisor as well, because I'm not sure whether they support >a backend-provided tag. Finally got round to this. By the looks of it, currently `cloud-hypervisor` and QEMU do not support a backend-provided tag. We could introduce an abstraction [function] in the Makefile over `vhost-user-fs` arguments for each hypervisor, which we could use whilst waiting for QEMU and cloud-hypervisor to support backend-provided tags with `vhost-user-fs`, and in the meantime use the abstraction for crosvm. I envision the abstraction as taking a few arguments: hypervisor, virtiofsd socket path, and tag. The abstraction would then construct & return the correct command-line argument for the hypervisor. We would call the abstractive function in the call to the `run` Make target.=20 That way, we're prepared for the future. What do you think? Best wishes, -- Dom Rodriguez --yftm5yjzndjaikzp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTzYTc8OH7LT+RncO4meeUvJe7sOwUCZy60+wAKCRAmeeUvJe7s O39HAP9hSMGNE/orx8Ll7SPGVXWz8P1pT7X6PNLunusNc71oOAEAhdutHLa9eIkI Zews5pbrS+EqdOG9CTEY4C8S7x87uwM= =/OHU -----END PGP SIGNATURE----- --yftm5yjzndjaikzp--