patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Alyssa Ross <hi@alyssa.is>,
	Spectrum OS Development <devel@spectrum-os.org>
Subject: Re: Is builtins.readFile okay?
Date: Sat, 1 Nov 2025 14:13:58 -0400	[thread overview]
Message-ID: <630be45c-86d7-4308-a262-d0bf9ef8ac8b@gmail.com> (raw)
In-Reply-To: <878qgqq6yg.fsf@alyssa.is>


[-- Attachment #1.1.1: Type: text/plain, Size: 992 bytes --]

On 11/1/25 08:21, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
> 
>> Is it okay to use builtins.readFile in a Spectrum derivation?  If the
>> input is a store path that is Import From Derivation and discouraged,
>> but I don't know if Spectrum's sources will ever be in a store path.
> 
> That wouldn't be a problem.  readFile is fine in principle, although it
> is rarely what you actually want.  There are very few cases where you
> have a string you need at eval time but don't want to inline into a Nix
> file, so if you're reaching for readFile I'd take a step back and think
> about whether there's a better approach.
> 
> Where readFile is used in your sysupdate VM, the build configuration
> mechanism[1] might be a better fit, if you don't want to hardcode it.
> 
> [1]: https://spectrum-os.org/doc/development/build-configuration.html

readFile is used only to read the version number.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-11-01 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-01  3:23 Is builtins.readFile okay? Demi Marie Obenour
2025-11-01 12:21 ` Alyssa Ross
2025-11-01 18:13   ` Demi Marie Obenour [this message]
2025-11-02 12:03     ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=630be45c-86d7-4308-a262-d0bf9ef8ac8b@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).