patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Alyssa Ross <hi@alyssa.is>, devel@spectrum-os.org
Subject: Re: [PATCH] release/update.nix: fix import of efi
Date: Mon, 15 Dec 2025 13:28:01 -0500	[thread overview]
Message-ID: <748509a2-09b6-422d-aa94-166dd242f5f2@gmail.com> (raw)
In-Reply-To: <20251215122640.115699-1-hi@alyssa.is>


[-- Attachment #1.1.1: Type: text/plain, Size: 957 bytes --]

On 12/15/25 07:26, Alyssa Ross wrote:
> import does not pass through custom configuration options.
> 
> Fixes: 49f33a1 ("release: Create directory with system update")
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
>  release/update.nix | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/release/update.nix b/release/update.nix
> index 18a91ac..f6e7772 100644
> --- a/release/update.nix
> +++ b/release/update.nix
> @@ -6,7 +6,7 @@ import ../lib/call-package.nix (
>  { callSpectrumPackage, config, runCommand, stdenv }:
>  
>  let
> -  efi = import ../host/efi.nix {};
> +  efi = callSpectrumPackage ../host/efi.nix {};
>  in
>  runCommand "spectrum-update-directory" {
>    __structuredAttrs = true;
> 
> base-commit: 6ceeb9b236cc50d2bba90068533ca1b7ff229c8b

Clearly an oops in my commit, so:

Reviewed-by: Demi Marie Obenour <demiobenour@gmail.com>
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-12-15 18:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 12:26 [PATCH] release/update.nix: fix import of efi Alyssa Ross
2025-12-15 18:28 ` Demi Marie Obenour [this message]
2025-12-16 10:30 ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=748509a2-09b6-422d-aa94-166dd242f5f2@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).