From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 8E849EE34; Mon, 21 Oct 2024 08:00:18 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id E6EEFEDEE; Mon, 21 Oct 2024 08:00:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=DMARC_NONE,FORGED_SPF_HELO, KHOP_HELO_FCRDNS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 Received: from LO2P265CU024.outbound.protection.outlook.com (mail-uksouthazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::3]) by atuin.qyliss.net (Postfix) with ESMTPS id 2244FEDE9 for ; Mon, 21 Oct 2024 08:00:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qeVCJrTOOw+p8RsceLpncg/OOPbQJ+L1odDTXuorZj8ug907zgf3ssSe5rntCz/9WfpTuSnF/89TA9/xQOam4iI8k+Wu3HIK6GRoXvG0Lr6xAr3oRgX6AT4XWBBkcQcnCfcVeabeuJLjTsyxuNSaKW75E4d4HZCX0Zw/g/6mpOdOgzSabxOMsiR2pqJ+meN0GUbwcW/abldFU8zUEwg8cSG5KjuSGrAjdrc5b93jjqxYHT+1lE6ddRCJnWjioDywqYA9lFt1hyn0o6BB0DBZtmF5Jooq1nceecREnpi+HPk0yNaRF4Tri5fYMtlJYKbwnW1G7jpv3te8Qk1DHxK/qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X2C7g0wavuwytgqPRmuh/btsx2NnYy/Y6mR77eEwh+c=; b=KpUVZX245k2ywQJhOZSonoK2tL+wnErNgXBCDbWeM+OtvbdYpK51pBEJYmC+w696pNfT/rL9US8WLaPx4YyvdQiZZHpIk0ytyG8HaSJ7xpibS/DUkWWPHXcQM6UGSScbFtkigk99tvOxQvmscbWUHAdLOJUaYVq9lp4ZVfR9nDgLaaVMJx551hHv2vjrBSL5cLXP1UC0HdG0SLhHD+08HIpGM8pw+fLXJmnH+IfXL9KJ9Lkh+J8vGpYlEZu6uflnz2jltDgX4jWG8hfIBw+rzKOgrd40WXQv+Oc7bZti72zq18Hf3KyZpsxoAY6+zJjCI+UWIHjqnrHzSvVx8WkjEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X2C7g0wavuwytgqPRmuh/btsx2NnYy/Y6mR77eEwh+c=; b=Of30U1wuQ7XtTkZuVaO7Gw1qILOGvMiKk0lQArE9lJGzzTBvrrZ3nNnxvvaKQfRQAr9/xw94IKLIvdk/MPPENEs4gTAKeeXNGtq6m99ZnHywgaSjPTRB1BOjI+ops+EVsVon5KmcAGmKqXNsoiDf6wMkjYOgKC0kcsLRn9ljXdp/RgrPvaC/emxyNDqTEP3LsN+lFgL1W0zg/cqGlsFwzkAZHVf8IbcFh9N/heYxrMC5GjYHJLmpsNw+WTQHMkRAnxdfeMRlowrADGaGMqdlacsLhnWulEkuLfzi6eOiuQ/QhD+FV5B1hgwCntQSOFpFik5Kfj6T622IDYesYoNi7w== Received: from LO4P265CA0308.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:391::7) by CWXP265MB2486.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:4d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.29; Mon, 21 Oct 2024 08:00:03 +0000 Received: from LO1PEPF000028CE.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:391:cafe::2d) by LO4P265CA0308.outlook.office365.com (2603:10a6:600:391::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28 via Frontend Transport; Mon, 21 Oct 2024 08:00:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by LO1PEPF000028CE.mail.protection.outlook.com (10.167.240.38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8093.14 via Frontend Transport; Mon, 21 Oct 2024 08:00:02 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id 0C954ACA0052; Mon, 21 Oct 2024 08:00:02 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id E6D6D7DF1; Fri, 18 Oct 2024 20:53:16 +0100 (BST) Date: Fri, 18 Oct 2024 20:53:16 +0100 From: Dom Rodriguez To: Alyssa Ross Subject: Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args Message-ID: <7nuyrpnpikc7ctg54yupkv72wdk2ckaqwbexfjtz3bnmxlvkoj@qhrjrshiotxh> References: <20240906224329.2336996-1-shymega@shymega.org.uk> <877cbnfmdf.fsf@alyssa.is> <87bk07am4z.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3a6sosimt3u2ao6d" Content-Disposition: inline In-Reply-To: <87bk07am4z.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO1PEPF000028CE:EE_|CWXP265MB2486:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e39c2c5-99aa-4a2d-934a-08dcf1a65e47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T09YNzNkZ3N5VlRiSm1xdXp3dGtUeW05d1NTcjVINCsxaklaVm4xOStkby9v?= =?utf-8?B?NEVHdEJuYmJmay9LanpvOWxBMng3R2JSVTAyaXlRTk92UnBXYlhTR2Rvenla?= =?utf-8?B?YjI4bTdPaVhvdkF0M3I2ZHQ0RXpyNzFNVGt5WmlyNC8wUmFqMlQ0ZzhsNk1G?= =?utf-8?B?Mytab1A4WU5NYkpkOXJhb25PbjYwejBaWkJtTXlJQ0FoWlR6WDNhK0hRMU9w?= =?utf-8?B?dDVoUXh3Rm8zemJpVU90WGdQaXlhdEdmbDhEbHRscHhqdUtJUmsvRThJeUd3?= =?utf-8?B?cFN4ZDIvbFo0M1NpcEk4ZlMwc2RNNU8zOGFya1djQm83YlVndnoyNUNHOUxx?= =?utf-8?B?a1lldENzcXVXenZtUnJMY2lvTTkwaUFXS3N2bVpSNWo1K3lOdi8yNDFEcE9r?= =?utf-8?B?bHBTZkpaTjRybTA3UXZXUmNza1hKRGVvZFYycnB4UTJhekx5ZUhOK2JoQ3ow?= =?utf-8?B?K3FNSWpac0hVa1JoYVBjV3hnVGdtMjFic3dJdWk2bXNwWjljU1FUOXNYcGpO?= =?utf-8?B?U2RZMzRoYUhlWGRCNTYwNmhvR1F5bFpTRFV5a1hlQndGaFhWS3AwbnBEcmNs?= =?utf-8?B?SncxOEtQTVBmUEhrdlpTTVJ4Ym91MEFzcDlZM0NyMXpONWpQUW1yWWhrbFZq?= =?utf-8?B?YnFvaWhSZGZYSTh3enFsVGxSUWpKSGVYZzJsc0ZnanlQU0U4c0dmT25WcXJ4?= =?utf-8?B?NUh0Mk4vekJOT1I0enM4QndzOXh0ZVJua1BpS25xM1R4SC90S2xZZ1I3ZUlP?= =?utf-8?B?RVhlUlJsazlLaS9XTm1wOXVtcVFNdDQzMG1ReThnZHFvOGh0ekdhRHh6ZXEr?= =?utf-8?B?cVp0WUlSSktlOVRrYk9FV2NHY3JRMmx5aVBnVnZ1aWVNYytWczBLSDJaSVps?= =?utf-8?B?SmlzZzRNQlNsMnRSNVJ4VmhMUDNRKzhPVEo0aUdxdEE5cWN6WVpBV1I3ZThT?= =?utf-8?B?dnJ6dnJGNVJTSStjNmQyOWlMV1RVa0xsd1lDZ1JteFlSM1VFMEJFUTN1Z2Zv?= =?utf-8?B?Z25tTFZ4V0pRbzVUejUwT0lnTlVHNGRVc2lJaWg3OENWblpsODlyR3N4di9i?= =?utf-8?B?SU1TSVRHd00xc2tzcGpyeDAvUFJtcVFlOVRpNk5FK08vK1F2UHEvWW56Zm9L?= =?utf-8?B?QTFGbGdEOUw5L3h0Q3BiNzZmTUswVzlvUjJ2Wm5qaTFQSUJOQ0ZmODVvbi8z?= =?utf-8?B?OTdGWWoyS2RIeVFpNVIxK291SFI3QUZWdlJkM1hXQ1lrUWt1OVVuZk0yYVJz?= =?utf-8?B?UzRlNjhIU1E1dTRpcExKQUVYMHAzZ1dEb0Zoa1BObkZmS1VjWDlpcEdheUtH?= =?utf-8?B?K095cm9Rb2pENXErVVIwQzE3cVVHUTJ6dXhQQXZ2ZTV4T3l4RHFHRG1PeG93?= =?utf-8?B?UERseVFFVWlnbmg2OStBcTlEeUp2OUNDMTV0UEwvVk96NFlIOE84ME9wQlg3?= =?utf-8?B?am05Z0Z3VzhvM0Z5OHNZN1lmb2VUSFdjb1EvREJuR2NrWCtnS0daN1pENjNU?= =?utf-8?B?WUt5THZxeXpTbVBpK21EQ042WmkvK2ZlUnh5RWF0bGd5RjhQRHhGTmphVWZG?= =?utf-8?B?OEptMldJdHJJWDJJRjMvZXNwbnYxcWZEV2d4ejF4VmQwemp0ODludkxSZEFZ?= =?utf-8?B?eFlHYUR2VjVLdzhBK2NvOCs0ZW5DZ3M4K0tsemFVVG1KRUxVOHBvZ2R6NWlM?= =?utf-8?B?Z1NtSW5tUEJXZkZUc2Z4YnZmTW0waTJzRnJNeHVpQXFVNlNCTXBBZTVMeWt6?= =?utf-8?B?TUZocGxjUG1qNFlxWmpjdDFLNGIxZ1k4OUhWSjUwSENoanExdHUxRzY4MkJl?= =?utf-8?B?UXNMU2ZCRlFyczdVeUhUQ1NLMTRDZ3cyZ3p5REZsWFlUOWtxN1UyblYwd3FG?= =?utf-8?B?Y2RRcmRFc0EvSTBOUHg1Z3dVTGlCN1FiUXZVM05UWUNZTVE9PQ==?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2024 08:00:02.7756 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e39c2c5-99aa-4a2d-934a-08dcf1a65e47 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: LO1PEPF000028CE.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB2486 Message-ID-Hash: Q6RVKAKLWPIPEGDUOHIWGUV2U7VSBE6J X-Message-ID-Hash: Q6RVKAKLWPIPEGDUOHIWGUV2U7VSBE6J X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3a6sosimt3u2ao6d Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, Sorry for the super late reply. I was flying back home on the 28th, and then I had to prepare for a new job - room organising, laptop configuring, onboarding, etc :-/ On 28.09.2024 16:27, Alyssa Ross wrote: >Dom Rodriguez writes: > >> On 07.09.2024 18:40, Alyssa Ross wrote: >>>Dom Rodriguez writes: >>> >>>> crosvm was producing warnings when using `--vhost-user-gpu` and >>>> `--vhost-user-fs`. >>>> >>>> In this commit, I have adjusted the `crosvm` invocations to look >>>> something like `--vhost-user $DEVICE,socket=3D$PATH`, where `$DEVICE` = is, in this case, >>>> `gpu` or `fs`, and `$PATH` is the path to the Unix socket. >>>> >>>> Signed-off-by: Dom Rodriguez >>>> --- >>>> img/app/Makefile | 4 ++-- >>>> release/checks/wayland/default.nix | 2 +- >>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/img/app/Makefile b/img/app/Makefile >>>> index 3adf8c4..11ef6e1 100644 >>>> --- a/img/app/Makefile >>>> +++ b/img/app/Makefile >>>> @@ -152,8 +152,8 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vho= st-user-gpu start-virtiofsd >>>> --disk $(RUN_IMG) \ >>>> -p "console=3DttyS0 root=3DPARTLABEL=3Droot" \ >>>> --net tap-name=3Dtap0 \ >>>> - --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ >>>> - --vhost-user-gpu build/vhost-user-gpu.sock \ >>>> + --vhost-user fs,socket=3Dbuild/virtiofsd.sock:virtiofs0 \ >>>> + --vhost-user gpu,socket=3Dbuild/vhost-user-gpu.sock \ >>>> --vsock cid=3D3 \ >>>> --serial type=3Dfile,hardware=3Dserial,path=3Dbuild/serial.log \ >>>> --serial type=3Dstdout,hardware=3Dvirtio-console,stdin=3Dtrue \ >>> >>>This is still not right, I'm afraid. >>> >>>When I run nix-shell --run 'make clean && make run' VMM=3Dcrosvm in >>>img/app, I get this error: >>> >>>[2024-09-07T16:36:32.592274891+00:00 ERROR crosvm] exiting with error 1:= failed to connect to vhost-user socket path build/virtiofsd.sock:virtiofs0 >>> >>>Probably the tag should also be a comma-separated key=3Dvalue option? >>> >>>(This doesn't have any automated test, because it's just part of the >>>development environment, and setting up a test environment to resemble a >>>development machine isn't trivial. Should be possible though.) >> >> It's bizarre. I've done some more testing, and it seems that >> `--vhost-user` isn't *quite* there yet on feature parity with >> `--vhost-user-fs`. Maybe I'm going wrong here, but it doesn't recognise >> the tag as a k/v option. >> >> I have managed to get the tests running with `--vhost-user-fs`, but it >> does look mismatched now. >> >> Would you prefer I revert the changes to `--vhost-user fs` =3D> >> `--vhost-user-fs`? > >You're right! I've just spent the last little while looking around >trying to figure out what's up here, and I think I've figured it out. > >In this commit[1] they made the vhost-user-fs tag optional, because it >can now be set with virtiosfd instead of the VMM. This is probably >good, because the more generic vhost-user becomes, the more hope >Spectrum has of one day not needing Cloud Hypervisor patches. :) So we >could try using --vhost-user fs for crosvm, and then passing --tag to >virtiofsd, but it'd need to be tested with VMM=3Dqemu and >VMM=3Dcloud-hypervisor as well, because I'm not sure whether they support >a backend-provided tag. Oh, that explains *a lot*! I agree, a generic approach would be preferable. >If that's too much work, I'd also be happy to apply just the GPU part of >this patch. Just let me know. :) I've started a new job, and so I've only really got weekends free - and even then, I have Repair Cafes to volunteer at.=20 If I send over the GPU patch only, can you apply that, and then we can discuss on Matrix/IRC the best approach for `vhost-user-fs`? Feel free to tag me - I'm mostly using IRC rightn ow. Thanks. >[1]: https://chromium.googlesource.com/crosvm/crosvm/+/b3f46c8fcbb0ce1047c= 4a5ca2c26c66e29e8eb44 Best wishes, -- Dom Rodriguez --3a6sosimt3u2ao6d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE6w1F5tDcG6GitfwkctzxIx5UvUMFAmcSvKwACgkQctzxIx5U vUNuKA/9H+MTk0+ZrDTX7AsPsqYuRC48ggnNYq9m1M53HXY+ZpWdgqIC6B25veMD d8cvC1AdbEfWp0rD72iwF92PoNl5brvKQT8itVXSpjToY8EDgIzvxwbk4gjpqbWc AzbH0PhNUjF62ERAY9XtnBeW3/hI7cEl1fvTxZRoNlMzImBVvi7AbDZIKL0DcrVR b07yQjabglZWWupc9e55NCkwbvTGq8tWI7eWAi2ioHE1K7KJsTCPvRgMsmZJIc+5 lvvy68ADQv+98K71rj7PGKrLQCHBrw5wl3qukv87vh9iD02RG0iILEHFXoapZcAQ sEzHvC8pT2txfxqkBGsRhrFXMVAGCo8F/DpJCIQUtwZ74QLZQNpVHonG1xAPN8A3 YgkBILrt96PGF3qRLWrbmDayiBA1Wvc6JRHsIf1795i6AiH7Uidknm0C8ViNDsdR +/I7IfKsYpQ8T/7Gd0QDN6qx4XQhYqYw4t8IeI3IpzX0MxNSJ0/4lXc1AopCmzzy wbNBLm8hjA7jhD6M2Tg0Q+Btrkz4JSXO6M3Nppl5y4JKqwagO8UDKdmZWGGrLnOK +Uj9eit6qdlmDOCdlE7FNacYstCBxIzZ2d7XGvOON4hcc/j41hfI33vPgaA/zbmD 47m0ls0xdR6804sE2SaTYumBZ7UkJwQCJ/6oaZ7bMw7cVra68K0= =Tbnm -----END PGP SIGNATURE----- --3a6sosimt3u2ao6d--