patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: Demi Marie Obenour <demiobenour@gmail.com>
Cc: Spectrum OS Development <devel@spectrum-os.org>
Subject: Re: Sandboxing strategy
Date: Wed, 17 Sep 2025 13:27:08 +0200	[thread overview]
Message-ID: <871po5z5df.fsf@alyssa.is> (raw)
In-Reply-To: <37d4dc51-4ee1-4ccf-8d37-2272988b9361@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> On 9/10/25 11:11, Alyssa Ross wrote:
>> This all sounds fine, BUT there are a couple of important things to bear
>> in mind:
>> 
>>  • This needs to be maintainable.  I don't know how much code this is
>>    going to be our how complex it's going to be, but that this will be
>>    totally custom does make me a bit concerned.
>
> This should not be too difficult.  It's the same system calls used by
> container managers, so if there is a problem it should be possible to
> get help fairly easily.  bubblewrap 

bubblewrap? :)

>>  • These services are part of our TCB anyway.  Sandboxing only gets us
>>    defense in depth.  With that in mind, it's basically never going to
>>    be worth adding sandboxing if it adds any amount of attack surface.
>>    One example of that would be user namespaces.  They've been a
>>    consistent source of kernel security issues, and it might be better
>>    to turn them off entirely than to use them for sandboxing stuff
>>    that's trusted anyway.
>
> Sandboxing virtiofsd is going to be really annoying and will definitely
> come at a performance cost.  The most efficient way to use virtiofsd
> is to give it CAP_DAC_READ_SEARCH in the initial user namespace and
> delegate _all_ access control to it.  This allows virtiofs to use
> open_by_handle_at() for all filesystem access.  Unfortunately,
> this also allows virtiofsd to open any file on the filesystem, ignoring
> all discretionary access control checks.  I don't think Landlock would
> work either.  SELinux or SMACK might work, but using them is
> significantly more complicated.
>
> If one wants to sandbox virtiofsd, one either needs to
> use --cache=never or run into an effective resource leak
> (https://gitlab.com/virtio-fs/virtiofsd/-/issues/194).
> My hope is that in the future the problem will be solved
> by DAX and an in-kernel shrinker that is aware of the host
> resources it is using.  Denial of service would be prevented
> by cgroups on the host, addressing the objection mentioned
> in the issue comments.

Do we not trust virtiofsd's built-in sandboxing?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2025-09-17 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  7:57 Sandboxing strategy Demi Marie Obenour
2025-09-10 15:11 ` Alyssa Ross
2025-09-10 15:14   ` Alyssa Ross
2025-09-10 20:35   ` Demi Marie Obenour
2025-09-17 11:27     ` Alyssa Ross [this message]
2025-09-18  2:34       ` Demi Marie Obenour
2025-09-19 13:17         ` Alyssa Ross
2025-09-19 19:37           ` Demi Marie Obenour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871po5z5df.fsf@alyssa.is \
    --to=hi@alyssa.is \
    --cc=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).