From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 2F0DE17B76; Mon, 21 Jul 2025 09:21:40 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 0AFA017B9E; Mon, 21 Jul 2025 09:21:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by atuin.qyliss.net (Postfix) with ESMTPS id 34F9917B54 for ; Mon, 21 Jul 2025 09:21:35 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 24BAFEC023C; Mon, 21 Jul 2025 05:21:33 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 21 Jul 2025 05:21:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1753089693; x=1753176093; bh=lkNKmizGCM zEyGb8823Rw+Nw4xx0l7LvHz23BYPw1JU=; b=GoVNBnLN4q+vlQVeQAxfZB7KXR GgM1gFTL9V/ae/GJJCnL18uHKGBSdC2bEky23sAPYjFattuPkULkShQAc7etBGHU uZfB8o1BF2TYOC7gljH2Ok9Sd+I0XsUXdLyETh/3nmyorD654e55P8FF3g7xK7fB m4LTL3PoyyIEsWP7AqUhr9pcCnga58frsGmxOue2ZyNMNlqoUIRE12yQXff28xJg zKF3WX3Nu5Uq/4JKx3HzLwW4NNnxfwKWhNkQS4qubN12q3qaK0r9IT5EG6UYjpoK bpjoPonfpw+Lqn4ulZiNYHa3TVl6b0GzeFeJJsqjg6WgMQB6PO9qrFRwNUPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1753089693; x=1753176093; bh=lkNKmizGCMzEyGb8823Rw+Nw4xx0l7LvHz2 3BYPw1JU=; b=gvlpA4h/CW6v8C5iIiL3EA7pi8wWrskxiZRS7LhZHviDyTDuQKX srNh2X9i6VTkimIRq/nA+6VYwQlNPHiyGOW5zwLTFpQrt7v674ZqDWNT0xEIiF9a m+lInmS95BNv7c4vo3Hjw4YuVlEXSPxshId4+GxsdsqtViBpsDjKZ3Y52BCesnoi 1eQfHe9PyfzGmsI5aaEIt+FbJoa1/iEhvaSKjmdWoM+JbmdOMXn3E4cjLij2EWOn Q0PwuoRfwWees6SeEBiJBy/75fPuu7rmCQ8m71iFUciKjLnD01I+Osfyq6FNqXtg FcQOe9pxtBG8VZitc2OF+rKnwCllf/w/HcQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdejudejtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffujghffffkgggtsehgtderredttdejnecuhfhrohhmpeetlhihshhsrgcutfho shhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeffudduffeuff egheeigeejtdekhfduheehfeduheelffettdekiedtgeefgfelheenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhish dpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggv mhhiohgsvghnohhurhesghhmrghilhdrtghomhdprhgtphhtthhopeguvghvvghlsehsph gvtghtrhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Jul 2025 05:21:32 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id 6AB7E2CC9D4D3; Mon, 21 Jul 2025 11:21:30 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour , Spectrum OS Development Subject: Re: [PATCH v5 2/8] img/app: Use separate service to create directories In-Reply-To: <52183cba-75c4-4f1a-af97-b5eb2337baed@gmail.com> References: <52183cba-75c4-4f1a-af97-b5eb2337baed@gmail.com> Date: Mon, 21 Jul 2025 11:21:27 +0200 Message-ID: <871pq9nbl4.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: GXBCYZOLYCQLIA3DBO7566PVMI3GYXJQ X-Message-ID-Hash: GXBCYZOLYCQLIA3DBO7566PVMI3GYXJQ X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > The app, D-Bus, and wayland-proxy-virtwl all rely on /run/user and > /run/user/0 to exist. The app and wayland-proxy-virtwl also relies on > /tmp/.X11-unix existing. Move the directory creation to a oneshot > service that other services rely on. > > Signed-off-by: Demi Marie Obenour > --- > img/app/Makefile | 5 +++++ > img/app/etc/s6-rc/app/dependencies.d/directories | 0 > img/app/etc/s6-rc/dbus/dependencies.d/directories | 0 > img/app/etc/s6-rc/directories/type | 1 + > img/app/etc/s6-rc/directories/type.license | 2 ++ > img/app/etc/s6-rc/directories/up | 10 ++++++++++ > .../wayland-proxy-virtwl/dependencies.d/directories | 0 > img/app/etc/s6-rc/wayland-proxy-virtwl/run | 11 ----------- > 8 files changed, 18 insertions(+), 11 deletions(-) > create mode 100644 img/app/etc/s6-rc/app/dependencies.d/directories > create mode 100644 img/app/etc/s6-rc/dbus/dependencies.d/directories > create mode 100644 img/app/etc/s6-rc/directories/type > create mode 100644 img/app/etc/s6-rc/directories/type.license > create mode 100644 img/app/etc/s6-rc/directories/up > create mode 100644 img/app/etc/s6-rc/wayland-proxy-virtwl/dependencies.d= /directories > > diff --git a/img/app/Makefile b/img/app/Makefile > index 80ef37ddf0c44636813725bd499e4ea5fad03c06..e11be09a3c6ca801d9211e49b= 58e3d05d57e344e 100644 > --- a/img/app/Makefile > +++ b/img/app/Makefile > @@ -82,12 +82,16 @@ build/rootfs.erofs: ../../scripts/make-erofs.sh $(PAC= KAGES_FILE) $(VM_FILES) $(V >=20=20 > VM_S6_RC_FILES =3D \ > etc/s6-rc/app/dependencies.d/dbus \ > + etc/s6-rc/app/dependencies.d/directories \ > etc/s6-rc/app/dependencies.d/wayland-proxy-virtwl \ > etc/s6-rc/app/run \ > etc/s6-rc/app/type \ > + etc/s6-rc/dbus/dependencies.d/directories \ > etc/s6-rc/dbus/notification-fd \ > etc/s6-rc/dbus/run \ > etc/s6-rc/dbus/type \ > + etc/s6-rc/directories/type \ > + etc/s6-rc/directories/up \ > etc/s6-rc/mdevd-coldplug/dependencies \ > etc/s6-rc/mdevd-coldplug/type \ > etc/s6-rc/mdevd-coldplug/up \ > @@ -96,6 +100,7 @@ VM_S6_RC_FILES =3D \ > etc/s6-rc/mdevd/type \ > etc/s6-rc/ok-all/contents \ > etc/s6-rc/ok-all/type \ > + etc/s6-rc/wayland-proxy-virtwl/dependencies.d/directories \ > etc/s6-rc/wayland-proxy-virtwl/notification-fd \ > etc/s6-rc/wayland-proxy-virtwl/run \ > etc/s6-rc/wayland-proxy-virtwl/type > diff --git a/img/app/etc/s6-rc/app/dependencies.d/directories b/img/app/e= tc/s6-rc/app/dependencies.d/directories > new file mode 100644 > index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae7= 75ad8c2e48c5391 > diff --git a/img/app/etc/s6-rc/dbus/dependencies.d/directories b/img/app/= etc/s6-rc/dbus/dependencies.d/directories > new file mode 100644 > index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae7= 75ad8c2e48c5391 > diff --git a/img/app/etc/s6-rc/directories/type b/img/app/etc/s6-rc/direc= tories/type > new file mode 100644 > index 0000000000000000000000000000000000000000..bdd22a1850ae6c03a414eeb80= 84998679a2cdf92 > --- /dev/null > +++ b/img/app/etc/s6-rc/directories/type > @@ -0,0 +1 @@ > +oneshot > diff --git a/img/app/etc/s6-rc/directories/type.license b/img/app/etc/s6-= rc/directories/type.license > new file mode 100644 > index 0000000000000000000000000000000000000000..c4a0586a407fe14c3e0855749= a7524ac3871dda4 > --- /dev/null > +++ b/img/app/etc/s6-rc/directories/type.license > @@ -0,0 +1,2 @@ > +SPDX-License-Identifier: CC0-1.0 > +SPDX-FileCopyrightText: 2025 Demi Marie Obenour > diff --git a/img/app/etc/s6-rc/directories/up b/img/app/etc/s6-rc/directo= ries/up > new file mode 100644 > index 0000000000000000000000000000000000000000..0ce4a06a37077cef8881d4538= 2a81950e164560f > --- /dev/null > +++ b/img/app/etc/s6-rc/directories/up > @@ -0,0 +1,10 @@ > +#!/bin/execlineb -P > +# SPDX-License-Identifier: EUPL-1.2+ > +# SPDX-FileCopyrightText: 2023-2024 Alyssa Ross > +# > +# Directory creation (if it's copyrightable): > +# SPDX-License-Identifier: MIT > +# SPDX-FileCopyrightText: 2022 Unikie > + > +if { mkdir /run/user /tmp/.X11-unix } > +if { mkdir -m 0700 /run/user/0 } Since you've basically rewritten this, let's reset the copyright here. We could also create /run/user in VM_DIRS in the Makefile, like we already do for /run/service =E2=80=94 probably good to keep that consistent= when we don't have reasons not to like a special mode. > diff --git a/img/app/etc/s6-rc/wayland-proxy-virtwl/dependencies.d/direct= ories b/img/app/etc/s6-rc/wayland-proxy-virtwl/dependencies.d/directories > new file mode 100644 > index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae7= 75ad8c2e48c5391 > diff --git a/img/app/etc/s6-rc/wayland-proxy-virtwl/run b/img/app/etc/s6-= rc/wayland-proxy-virtwl/run > index 7b8034368f547cfaf83a81a3b5d73ab864edafff..c1e0e088c789ab8c5fde7e50c= 9f4b856fff0e477 100755 > --- a/img/app/etc/s6-rc/wayland-proxy-virtwl/run > +++ b/img/app/etc/s6-rc/wayland-proxy-virtwl/run > @@ -1,17 +1,6 @@ > #!/bin/execlineb -P > # SPDX-License-Identifier: EUPL-1.2+ > # SPDX-FileCopyrightText: 2023-2024 Alyssa Ross > -# > -# Directory creation (if it's copyrightable): > -# SPDX-License-Identifier: MIT > -# SPDX-FileCopyrightText: 2022 Unikie > - > -foreground { mkdir /tmp/.X11-unix } > -foreground { mkdir /run/user } > -foreground { > - umask 077 > - mkdir /run/user/0 > -} >=20=20 > s6-ipcserver-socketbinder -B /run/user/0/wayland-0 > fdmove -c 3 0 > --=20 > Sincerely, > Demi Marie Obenour (she/her/hers) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaH4GlwAKCRBbRZGEIw/w orVTAP4hMXVR1sQKkOt6xWxwFE87H6QTvnTiAPRApIfY+HdXbQEA2wrK5Ezx0FyZ 2CpzxSpOSVfZust+A2TYIsx/xg0nWQY= =1vIg -----END PGP SIGNATURE----- --=-=-=--