From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH www] CONTRIBUTING: ask people to add copyright headers
Date: Wed, 12 Aug 2020 12:45:32 +0000 [thread overview]
Message-ID: <871rkc9gnn.fsf@alyssa.is> (raw)
In-Reply-To: <SJ0PR03MB5581F58C06C2BC04DE05A30BB3420@SJ0PR03MB5581.namprd03.prod.outlook.com>
"Cole Helbling" <cole.e.helbling@outlook.com> writes:
> On Tue Aug 11, 2020 at 7:04 AM PDT, Alyssa Ross wrote:
>> I want to make sure we're collecting copyright information right from
>> the start, because it's much easier to keep track of this as content
>> is created, rather than try to piece it together after the fact should
>> we ever need to.
>
> +1, and it's also nice to see individuals being attributed, rather than
> "Spectrum Contributors," as many other projects have turned to (not that
> this is any less valid -- it's just nice to see your name called out
> somewhere).
IKR!
>> ---
>> CONTRIBUTING | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
> Overall SGTM. However, I don't think I'll refer to the contributing
> document everytime I post a patch, so I hope you'll gently remind
> me/people as they post patches (or offer to do it yourself, as you did
> in the recent Matrix instructions patch).
Yeah, of course! I think in general it's often way easier for a
maintainer to fix up a patch and apply it themselves, and maintainers
should do that more often.
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Thanks for the review. Applied as
9e1415ed1ad0bc6e1071d988c73dd0fdc8b4e894.
prev parent reply other threads:[~2020-08-12 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 14:04 [PATCH www] CONTRIBUTING: ask people to add copyright headers Alyssa Ross
2020-08-12 6:27 ` Cole Helbling
2020-08-12 12:45 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rkc9gnn.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).