Re: [PATCH] Add and clarify matrix workarounds.

Alyssa Ross
2020-08-12T13:34:22Z

Philipp Steinpaß <philipp@xndr.de> writes:

> Thank you for the remarks, they were all very helpfull.
> If you want to include me in the copyright, you are free to use my full
> name. It's in the mail header now.

Cool, so I'll add the following if that's okay:

<!-- SPDX-FileCopyrightText: 2020 Philipp Steinpaß <philipp@xndr.de> -->

> P.S. Please feel free to comment on any potential problems with the
> formatting of these patch mails, if you want to. It's my first time
> using git via mail and I'd like todo it the proper way right away.

Okay! Well, what you've done here has pretty much worked, but there's a
couple of things that were a little unusual:

- When I apply a patch with git am, it expects to find the commit
message at the start of the email. So usually, when you're sending v2
of a patch, you repeat the message from v1, because that's usually
what makes sense to be recorded in the commit log. If you want to
include stuff like you did here, describing what's changed in this
version of the patch, you can include that after the "---" (above the
diffstat), and it won't become part of the commit message.

- Often people indicate which version of a patch they're sending using
the subject, like "[PATCH v2] Add and clarify Matrix workarounds".

Thanks for your patch! I appreciate it -- I know it's not easy getting
up to speed with a new workflow.