Re: [PATCH www] impressum: fix broken relative paths in subdirectories

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 2337 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> On 12/25/25 22:17, Angel J wrote:
>> Signed-off-by: Angel J <iamanaws@httpd.dev>
>> ---
>>  logo/index.html                      | 2 +-
>>  software/cloud-hypervisor/index.html | 2 +-
>>  software/index.html                  | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/logo/index.html b/logo/index.html
>> index 0750053..2471cf9 100644
>> --- a/logo/index.html
>> +++ b/logo/index.html
>> @@ -61,4 +61,4 @@ by the Free Software Foundation; with no Invariant Sections, no
>>  Front-Cover Texts, and no Back-Cover Texts.</small>
>>  
>>  <p>
>> -<a href="impressum.html" lang="de"><small>Impressum</small></a>
>> +<a href="../impressum.html" lang="de"><small>Impressum</small></a>
>> diff --git a/software/cloud-hypervisor/index.html b/software/cloud-hypervisor/index.html
>> index 2fef585..0bda4a7 100644
>> --- a/software/cloud-hypervisor/index.html
>> +++ b/software/cloud-hypervisor/index.html
>> @@ -177,4 +177,4 @@ by the Free Software Foundation; with no Invariant Sections, no
>>  Front-Cover Texts, and no Back-Cover Texts.</small>
>>  
>>  <p>
>> -<a href="impressum.html" lang="de"><small>Impressum</small></a>
>> +<a href="../../impressum.html" lang="de"><small>Impressum</small></a>
>> diff --git a/software/index.html b/software/index.html
>> index a05e177..2a8a852 100644
>> --- a/software/index.html
>> +++ b/software/index.html
>> @@ -38,4 +38,4 @@ by the Free Software Foundation; with no Invariant Sections, no
>>  Front-Cover Texts, and no Back-Cover Texts.</small>
>>  
>>  <p>
>> -<a href="impressum.html" lang="de"><small>Impressum</small></a>
>> +<a href="../impressum.html" lang="de"><small>Impressum</small></a>
>
> Nice catch!  I wonder if automation can reduce the chance of similar
> problems.  Could a template engine be used to reduce repetition?
> Or at least check that all of the internal links are valid?

You don't need a template engine for that!  Take a look at
release/checks/doc-links.nix in Spectrum, which checks internal links in
the Spectrum documentation.

It might be good to unify the documentation with the rest of the
website, but I'm not sure yet.  It feels a bit weird to have stuff that
isn't about the Spectrum system inside the spectrum repo.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]