Re: [PATCH doc v2] Document crosvm memfd server

Alyssa Ross
2020-05-29T18:12:38Z

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

> Looks good. One minor nitpick, take it or leave it:
>
>> +Spectrum's crosvm has been augmented with a feature called the "`memfd
>> +server`", (currently only on the
>> +https://spectrum-os.org/git/crosvm/log/?h=interguest[interguest]
>> +branch). This is a small server that listens on a Unix stream socket.
>
> This should be either a comma or parenthesis, not both.

Will fix, thank you.

> This is just a personal preference of mine, but one I wish were
> more widely adopted: when writing markdown I only wrap the "proper
> nouns" in `code blocks` for consistency, e.g. "`memfd` server" not
> "`memfd server`". But this isn't a hill I'm prepared to die on.

I strongly agree! But this isn't Markdown. That's just the syntax for
double quotes in AsciiDoctor. :)

> Reviewed-by: impaqt <impaqt@vendek.net>
> ^^^ Is this what you meant by a tag?

Yes! Thank you. :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]