From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 997A59624; Mon, 27 Jul 2026 12:15:03 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id BD5FC95F7; Mon, 27 Jul 2026 12:15:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by atuin.qyliss.net (Postfix) with ESMTPS id 84AB19610 for ; Mon, 27 Jul 2026 12:14:59 +0000 (UTC) Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 384331D00213; Mon, 27 Jul 2026 08:14:58 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Mon, 27 Jul 2026 08:14:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1785154498; x=1785240898; bh=nMeM7Z6OyN Jhc+BjQaDabAe3x9Zb3ulnl7LqTjPHPXE=; b=YKhjggokNixZ6R8jUbKmkz3G0w tnpMVpOMpubiPUqprM0aBAlfSXluLd0B36eZR9JVGGUCIdD6G156USAPfQoQUWmr 0CN5kXlbSi6SC4GqN8njnv6djafmqa6O1QKNLstVqtJo574Ln8r3Rsr647MdXcoY 3SrqkzpCgwOPzD9zjbLWZWGv08vAv/4I3KtIukO1J6D+6ppmw8bgzibDlRsHn1sS KzoI+Pm5nlLSW21W3CeZRPloAHKir2pMLTKDS/gEK6n5Np7RGK7vxdTfoxbQjqPB mjro/6NY4+csG3kPcZR79XA/fKlPEChdyvjHhoUJJad8DamXIdhlj8Ih2ERA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1785154498; x=1785240898; bh=nMeM7Z6OyNJhc+BjQaDabAe3x9Zb3ulnl7L qTjPHPXE=; b=asRV9M0LdMk47q3zIVPay+8ei9ndRxdU4UmT3uZBjUKcm+J+zWj jYdOWZIS06yYnop1mc5qvtWB7v+Dti1J7loXTcl862w7yXcgPH5LwEaII/X7q5Du L276GAlLk+vYdU5ovXwTVgXza29MPVHMWS2DBe37/8KV8sHaIZR/nGPCIG4ssZul 9VT/+b01sjkWT21Uv6kfJGidCpBKymkA8U6RE9y6rOzdKR0jxZM5Os2OEOLyymUP THLHemvV1lbjG+GJ9jzJ1kgkasUs/UwkwWZJnFMaKQH67cFZUOdx4oHcIwyUF2Ug hX7Nsg8lKH2iFLnjZavYnwStzGKvXdpLXEw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGXP4jU7Ebg979q/prvspCwgWFae7HHpvj1tJQmrzInYwsCH77HFGApAHV9jyjxba 4XmW9wUakkJNcdlqJdsDPzSZhOlYXILXAGGnVx9afH8dBl6gZ1nHkcMk3VEhJxEzGa+VDk t0a9b2BM0Ascz5Q1zD61zZYQ+/MjQug6yOnVVxdyGlaJclw3neljwrnO0328+LIyFaTp++ kurNI2ybAq4zrd7W5oLlEbjKJlrbdofl1KN7usedbS5U9eWreKh2doLIMp4tKODxwuBXN+ B/8Y/f5+eewEUe05olHpPeCuL7ba2XuVQz/t6NoXV1oG+eKJgZZATmBV00GauH12IoK9ZA l7Kj9NGD7uSToZgBA3RMS79TG4shisuld7lppoSsZw6jO1i8hI6xI9Y1QBj+FBDK1f4PXN +z48VL6aiQ391WvC1T8TLQrABmzzuiZd9s7OGjqZ7g1JJwH/fJelBwBWFZDweTuKvvJnGx 5IZLVk2M5+JmsweUEkovCQAcVmPmlDqLx7B3DUtKYoUMDZ2ULG4A6quFanEA5MyuDlf/Pl FD+Dp0D+ajVwN8lmqTeaFYfbrSBLDRaBauVheJTNelHykymbhIlpcFxcfdlUhW2+x30KbA J9XJ5o23nj4x3bCbyEP+yWJT+1jHFXHxYo1INiLN8XrJg2xL5xEq3je3/Nwg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Jul 2026 08:14:57 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id BCAC1C4D7A59; Mon, 27 Jul 2026 14:14:56 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH v4 08/20] host/rootfs: serial-getty-generator: Use cgroups In-Reply-To: <20260721-cgroups-v4-8-46b2e5fff7b6@gmail.com> References: <20260721-cgroups-v4-0-46b2e5fff7b6@gmail.com> <20260721-cgroups-v4-8-46b2e5fff7b6@gmail.com> Date: Mon, 27 Jul 2026 14:14:55 +0200 Message-ID: <874ihkljcw.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: BCFOHWH5OJYCQ3BATCLLLH643CJJK3RI X-Message-ID-Hash: BCFOHWH5OJYCQ3BATCLLLH643CJJK3RI X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > Avoids concurrent execution and leaked child processes. Those things shouldn't happen anyway, but I guess it's cheap to make sure of it. With cgroup-s6-finish changed to something that only does cgroups: Reviewed-by: Alysa Ross > Signed-off-by: Demi Marie Obenour > --- > host/rootfs/file-list.mk | 1= + > .../s6-linux-init/run-image/service/serial-getty-generator/finish | 5= +++++ > .../etc/s6-linux-init/run-image/service/serial-getty-generator/run | 4= +++- > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/host/rootfs/file-list.mk b/host/rootfs/file-list.mk > index c707c01179238231f70164ffda5b7c940b34192a..b899b4356d73d73ad0fc4ecd3= 837b7a3525d6f5a 100644 > --- a/host/rootfs/file-list.mk > +++ b/host/rootfs/file-list.mk > @@ -21,6 +21,7 @@ FILES =3D \ > image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run \ > image/etc/s6-linux-init/run-image/service/s6-svscan-log/notification-fd= \ > image/etc/s6-linux-init/run-image/service/s6-svscan-log/run \ > + image/etc/s6-linux-init/run-image/service/serial-getty-generator/finish= \ > image/etc/s6-linux-init/run-image/service/serial-getty-generator/run \ > image/etc/s6-linux-init/run-image/service/serial-getty/notification-fd \ > image/etc/s6-linux-init/run-image/service/serial-getty/run \ > diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial= -getty-generator/finish b/host/rootfs/image/etc/s6-linux-init/run-image/ser= vice/serial-getty-generator/finish > new file mode 100755 > index 0000000000000000000000000000000000000000..4d5b454e97c3584d0644c2d73= 8514f13b1c53957 > --- /dev/null > +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-= generator/finish > @@ -0,0 +1,5 @@ > +#!/usr/bin/execlineb -WS3 > +# SPDX-License-Identifier: EUPL-1.2+ > +# SPDX-FileCopyrightText: 2026 Demi Marie Obenour > + > +cgroup-s6-finish $@ > diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial= -getty-generator/run b/host/rootfs/image/etc/s6-linux-init/run-image/servic= e/serial-getty-generator/run > index bf66ab0878fc6d8e77ca71a4a89e50c139a6bb11..a1846a29cf55892127feb7ecf= c0adcd12f0497bd 100755 > --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-= generator/run > +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/serial-getty-= generator/run > @@ -1,7 +1,9 @@ > -#!/bin/execlineb -WP > +#!/bin/execlineb -WS1 > # SPDX-License-Identifier: EUPL-1.2+ > # SPDX-FileCopyrightText: 2024-2025 Alyssa Ross >=20=20 > +# avoid concurrent operation > +cgroup-setup --leaf -- $1 > piperw 3 4 > background { > fdclose 3 > > --=20 > 2.55.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCamdLvwAKCRCZddwkt31p FYhXAP9gpyEjSfq+EtY2Dhr+rD5+mGN8viU6WgN3VPWxnkBQcQEAqEcrf/spVqBU x+FDHB2ETNkzgmaKEDMEKKngIqun3QE= =zvbV -----END PGP SIGNATURE----- --=-=-=--