Re: [PATCH v2 1/3] Move all files for the image into a subdirectory

Demi Marie Obenour
2025-09-11T12:21:44Z

[-- Attachment #1.1.1: Type: text/plain, Size: 1126 bytes --]

On 9/10/25 14:58, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
>
>> This avoids conflating files that will only be used during the build
>> with files that will be included in the generated image. It also makes
>> it vastly easier to generate the lists of files in the Makefile from a
>> script.
>>
>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>
> I like it, but release/checks/wayland.nix fails for me with this applied
> on top of cbb10b15f36a7ac35400e226b284b1cb091cb3c9, as well as possibly
> the integration tests. Can you reproduce?

Yes, I can. The problem is that tar is passed -C image, so
instead of image/etc/s6-rc/<something> it tries to access
image/image/etc/s6-rc/<something>, which doesn't exist. This
error gets swallowed, though, so s6-rc-compile gets passed an
empty directory. This causes s6-rc to not know about any
services, and hilarity ensues.

I'll fix this in v3, but also ensure that such problems would
prevent an image from being built instead of producing a broken
image.
--
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]