From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id B83AE8FA8; Sat, 23 May 2026 08:57:13 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 790858F9D; Sat, 23 May 2026 08:57:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) by atuin.qyliss.net (Postfix) with ESMTPS id AE2318F9C for ; Sat, 23 May 2026 08:57:10 +0000 (UTC) Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 60FEA1D00055; Sat, 23 May 2026 04:57:09 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Sat, 23 May 2026 04:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1779526629; x=1779613029; bh=6a3Yg372H8 QwosFgACiicJijZfxuyRFzLMRIyvOH/fw=; b=t8DZ8tnlAIqgZFLxbjbnL0wjAL LFPy+ZRI2ewFlMTgcphvwdLjQo/Ttz4ANVPBPH7uXezCd7NfBYMvUYZNoFWf42JH WNJkVUCpxKXjibsJPwVfxd7CKurTJEPPZV+rmNBV27vowtUOEtvfeh079VzfsvtK synEjjt5GpGUfiAKmbpJ7JcYrTxomRerZTOsCYzIAOQogKSYm35cn3WL8cjwGo50 3l3SMuAN3xk+LP3/zIQ7AsrvDCNbNQCMyYfgevviqe2VJkjrbr85OIF1D4sO8XEX JQwh6gbdnE3JW1/MFRvTj63DM/afSa+XwQqJpCM3kJ0sPohZb3Mt87f8lH/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1779526629; x=1779613029; bh=6a3Yg372H8QwosFgACiicJijZfxuyRFzLMR IyvOH/fw=; b=XEefGwReMGV8S86OIsBYCO+ED/LxnIw4Or7jyCXAPr6HnWu4SA3 glW2REETmE1w9St4AfKskTywoa92ny7g9ixM6jNIyIAkD9xquKb+OKjZ3II0xvNH 8C3BLGuD+E8BzAoSZjaqSnFt9wZvGHx7hJWUpLDcnvJWiTy4RFJ3/hvVEyVBOMqd M9LKFQbAXBBoULyCm2X8oA8ZTr1wdr9CdG3BQZmd3Eivmav5mgbQFHuROI4pzaK/ O/0EuV7w3878U7/NkqQuw698HyNFfLyVEYJ1KeJEs0C8UEwF1CKOrIsWJkw2tHzQ E17eXJIVldIGVYUdvEaXi7fZIjtWn7u6oWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduhedviedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiueefff ehfeeftdffhfegfeeuhfevleefgeekhefgieefleeuueejffekhffghfenucffohhmrghi nhepghhithhhuhgsrdgtohhmpdhsphgvtghtrhhumhdqohhsrdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdr ihhspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhope hvrghlvghnthhinhesghgrghgrrhhinhdrfihorhhkpdhrtghpthhtohepuggvvhgvlhes shhpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 23 May 2026 04:57:08 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id B3283B22445B; Sat, 23 May 2026 10:57:07 +0200 (CEST) From: Alyssa Ross To: Valentin Gagarin Subject: Re: [PATCH v4] Documentation: add logo to site header In-Reply-To: <20260520085723.135653-1-valentin@gagarin.work> References: <20260518210454.64173-1-valentin@gagarin.work> <20260520085723.135653-1-valentin@gagarin.work> Date: Sat, 23 May 2026 10:57:05 +0200 Message-ID: <875x4eqza6.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: 4DYTBW7JFOQMXWLKO3ZW6D4VR7IQHTX2 X-Message-ID-Hash: 4DYTBW7JFOQMXWLKO3ZW6D4VR7IQHTX2 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Valentin Gagarin writes: > Also spell out the title. The stylesheet adjustment makes the logo > align properly with the longer title text for different display widths. > Override the [title template] to show both the title text and the logo. > > [title template]: https://github.com/just-the-docs/just-the-docs/blob/f43d7cfc4b1e18a97e6d6d20b88f1aaeda0e7196/_includes/title.html > > Signed-off-by: Valentin Gagarin > --- > Documentation/_config.yml | 3 ++- > Documentation/_includes/title.html | 11 +++++++++++ > Documentation/_sass/custom/custom.scss | 13 +++++++++++++ > 3 files changed, 26 insertions(+), 1 deletion(-) > create mode 100644 Documentation/_includes/title.html > > diff --git a/Documentation/_config.yml b/Documentation/_config.yml > index 90018ba..dbc4f7a 100644 > --- a/Documentation/_config.yml > +++ b/Documentation/_config.yml > @@ -1,7 +1,8 @@ > # SPDX-License-Identifier: CC0-1.0 > # SPDX-FileCopyrightText: 2022 Alyssa Ross > --- > -title: Spectrum Docs > +title: Spectrum documentation > +logo: "https://spectrum-os.org/logo/logo_html.svg" > theme: just-the-docs > aux_links: > Home: > diff --git a/Documentation/_includes/title.html b/Documentation/_includes/title.html > new file mode 100644 > index 0000000..0b36987 > --- /dev/null > +++ b/Documentation/_includes/title.html > @@ -0,0 +1,11 @@ > +{% comment %} > +SPDX-License-Identifier: MIT > +SPDX-FileCopyrightText: 2016 Patrick Marsceill > +SPDX-FileCopyrightText: 2026 Valentin Gagarin > +{% endcomment %} > +{% if site.logo %} > + > +{% endif %} > +{% if site.title %} > + {{ site.title }} > +{% endif %} > diff --git a/Documentation/_sass/custom/custom.scss b/Documentation/_sass/custom/custom.scss > index fd5a676..75e3f16 100644 > --- a/Documentation/_sass/custom/custom.scss > +++ b/Documentation/_sass/custom/custom.scss > @@ -20,3 +20,16 @@ > margin-left: 2ch; > } > } > + > +.site-logo { > + width: 3rem; > +} > + > +@media (min-width: 50rem) { Took me a while to understand what was significant about 50rem here. We have access to the same SCSS mixins just-the-docs itself uses, so we could use them rather than hardcoding a magic number that might get out of sync: @include mq(md) { I also noticed that if I hover over the .site-title in a viewport wider than 50rem, its background becomes opaque and reveals that it's overflowing the sidebar. Really this is reinforcing to me that we need a version of the logo that includes the name. We need that in other contexts too, and here it would avoid the need to make changes to Just The Docs. Up to you whether it's better to wait for that or to do it this way in the meantime. I think it would also be fine if just the homepage of the documentation included the logo in its content. > + .site-logo { > + width: 5.5rem; > + } > + .site-title { > + font-size: 1.25rem !important; > + } > +} --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCahFr4QAKCRCZddwkt31p FYp6AQCBy/ejGYxjaRdQqwBLTmNSwxi27lk8JQqJvYJ4tnzmogEAyO6H+VP7uUZ9 yfCS/lBuk58Od3PyLM8c9/NSHu6bIw4= =gxze -----END PGP SIGNATURE----- --=-=-=--