From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 22D6ED427; Wed, 01 Oct 2025 09:35:31 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id BD4BED41B; Wed, 01 Oct 2025 09:35:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by atuin.qyliss.net (Postfix) with ESMTPS id 64336D3F4 for ; Wed, 01 Oct 2025 09:35:27 +0000 (UTC) Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id 9FA671400100; Wed, 1 Oct 2025 05:35:26 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Wed, 01 Oct 2025 05:35:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1759311326; x=1759397726; bh=si0MItQGEA oLG3j8OYF3qP7VT0X/7ynxHUhBZJJqs+0=; b=g4qvBz9O14+5FJpfyO2EzCrIyw VY1nxJOMltSwW2QMfBH4sTec0YO/iiaWmo48pelNiNoC/VMMwuPMwqXRaEPGLzw7 1YyfXNJ+ROjkjOoI7ZW0nc5bVug76Zn1FZf06tvWJPDEetdmx7tTm46bZEAsVOl2 0HgwQX4yksOnX17/mVRNOy8tsDWq7NItcnRkpqjQ5QOWVt8PT/8jeDNi6mJvE1p5 FgkWUtLewMs78eXfeCi9TOs5m7haU6m/U+cKW45jdJzQyyXBcKcGL4ZnMcVLhExK Y/xWTo42IPPw9e7ff8tRYtfRFxTESilaGPuhxofSBPYGIHd2VB6BAAIlAqKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1759311326; x=1759397726; bh=si0MItQGEAoLG3j8OYF3qP7VT0X/7ynxHUh BZJJqs+0=; b=aXIApOg1/JvpfFEmJQalxmDdOZFwoDeetepdM5hSS7+dIPBqYXd ItccTRUQl8K9PJSEN95izAcW5E2ldCr1nPpVjiz6TYAU+UVsKCVnXYGqWoLH4nWs a46vEnZSEorxN9KODf46AGyJxdsIn8sGWD5+U2hG3bEHvHdlQt9qaOlbtzWp2Mkg ZMtcgK9pesIFlm2+h0wOoxjf5i5HtbORdNL8ZUA8se5l+a2dZus73qVtTX1TDp/N I5iJly6FMvfJjbYEDSjcsoqsNQtsxxoFmHeJra6UH1SJOM5/7NkZe+mDUust7NB3 9Xs2+ffG3ygB9ASzg0ubQCU+Nf2ZQn8cpig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdekvdejlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuie elgfetgfdttddtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Oct 2025 05:35:26 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 1E17E5D68F03; Wed, 01 Oct 2025 11:35:25 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH v7] Generate file lists from a script In-Reply-To: <20250929-genfiles-v7-1-5a702ee452b1@gmail.com> References: <20250927-genfiles-v6-1-2111a981596d@gmail.com> <20250929-genfiles-v7-1-5a702ee452b1@gmail.com> Date: Wed, 01 Oct 2025 11:35:24 +0200 Message-ID: <875xczhsmb.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: 4SD7GUUWQM2VATFTMY3QMMY2GVBI7WMP X-Message-ID-Hash: 4SD7GUUWQM2VATFTMY3QMMY2GVBI7WMP X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Demi Marie Obenour writes: > diff --git a/scripts/genfiles.sh b/scripts/genfiles.sh > new file mode 100755 > index 0000000000000000000000000000000000000000..5bee72ec72bc3aeb5b2e1db26721664858661d35 > --- /dev/null > +++ b/scripts/genfiles.sh > @@ -0,0 +1,26 @@ > +#!/bin/sh -- > +# SPDX-License-Identifier: EUPL-1.2+ > +# SPDX-FileCopyrightText: 2025 Demi Marie Obenour > +set -euo pipefail > +export LC_ALL=C LANGUAGE=C > +dir=$(git rev-parse --show-toplevel) shellcheck points out that this variable is never used. I'm not sure whether you'd prefer to remove it, or re-add the cd, so please submit a new version with your preferred behavior. With that and DIRS reinstated in vm/sys/net: Reviewed-by: Alyssa Ross > +for i in host/rootfs img/app vm/sys/net; do > + output_file=$i/file-list.mk > + { > + git -C "$i" -c core.quotePath=true ls-files $'--format=%(objectmode)\t%(path)' -- image | > + sort -t $'\t' -k 2 > + } | > + awk -f scripts/genfiles.awk > "$output_file.tmp" > + if [ -f "$output_file" ]; then > + # Avoid changing output file if it is up to date, as that > + # would cause unnecessary rebuilds. > + if cmp -s -- "$output_file.tmp" "$output_file"; then > + rm -- "$output_file.tmp" > + continue > + else > + astatus=$? > + if [ "$astatus" != 1 ]; then exit "$astatus"; fi > + fi > + fi > + mv -- "$output_file.tmp" "$output_file" > +done --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaNz13AAKCRBbRZGEIw/w osuoAQDTFJ0RpOGJwMiYvNdAW+zspI+OuAV15W2RWoLx4d9E4AD6AtIqaosGNlIE geeSXUiWFO9g2Zo6v28ChKCWiGycGQg= =8ECn -----END PGP SIGNATURE----- --=-=-=--