From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 5A1B9288E; Fri, 08 Nov 2024 11:14:57 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 8BF8A2881; Fri, 08 Nov 2024 11:14:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DMARC_MISSING, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_SBL_A autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) by atuin.qyliss.net (Postfix) with ESMTPS id B60D02827 for ; Fri, 08 Nov 2024 11:14:48 +0000 (UTC) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.stl.internal (Postfix) with ESMTP id 480B21140149; Fri, 8 Nov 2024 06:14:46 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Fri, 08 Nov 2024 06:14:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1731064486; x=1731150886; bh=5Z4axEFX7m 4eM/3QCeeWdcVVWqQrSwn65lyYI0V99H4=; b=kXRhOvjCXmVCOrL9MLYWuXVt18 8RWbcakF1cJJzJUkRyMQyXa4J1veM0pgXt+6hsMdYkxpoWDldx6YXBEUPVS+3EWT zOWHwIBd5NRm5drMli+pNgfpZgDeFBdD4Bkn9AzbneY10AblZbEg/MtpYMk2Qiuw 9mkO7xpMIety2HOvUX5SnouSntGfh0jL8kiOY5dC9tjb8Nk4kxpw3tOupPuYLuSb eJPA8RrX/8Ek1sIY3iuW65rvYPbhhbWATnz/aSsVT5Erq1MiQdvKsOtSPSkZ+qt2 yHxbTD8bf0V8of0UeFIanTFi0xUBuyVKdGOdJPbjl/umOkBa0zbJD4TPlekg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1731064486; x=1731150886; bh=5Z4axEFX7m4eM/3QCeeWdcVVWqQrSwn65ly YI0V99H4=; b=fbbAyGvt3++Cv5GsFA3txjJcD8I+R4VXNuQyAEcTEpAKZeVQMC3 s7IDfTBcVEsxh+HqOD3BY+K5bLCC/17tT0B0BDKgUL2XfhqUNjApWHDJdJASnuXT LzM6SRmOj+1nb3cxGJ2rkHD1w8F3BjuWMHI6ZiL20/Fw5q4IWh70xphDgOyOnhqz i9vEIiXMvAXXeGOtzPjdTNmzsuInBtornbbZbMDAayuD4e7ON0DLqVgeuCa0RJAq +yO4JFDnqAM5mP9RrQdPsGxNb6vC3nVJgDc8Kr5B0Z+P/hzxmFKDxMVKB027LWdj khVWEYPlImhm1i+UFfsZS3/S00qEMPdBO2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdeigddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujg hffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhi segrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiudffueeilefgtefgtddttd ekkeehkefgheekudefveetgeefiefftedvteeuveenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspghrtg hpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhhhihmvghgrges shhhhihmvghgrgdrohhrghdruhhkpdhrtghpthhtohepuggvvhgvlhesshhpvggtthhruh hmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Nov 2024 06:14:45 -0500 (EST) Received: by sf.qyliss.net (Postfix, from userid 1000) id 0CB913831C5B6; Fri, 08 Nov 2024 12:14:42 +0100 (CET) From: Alyssa Ross To: Dom Rodriguez Subject: Re: [PATCH v3] crosvm: Rename `--vhost-user-gpu` flag In-Reply-To: <20241107005948.2318591-1-shymega@shymega.org.uk> References: <20241107005948.2318591-1-shymega@shymega.org.uk> Date: Fri, 08 Nov 2024 12:14:40 +0100 Message-ID: <875xoyf04f.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: NDXCFWB5NCI3OEBSJA2ZFNUDD2MVMNSP X-Message-ID-Hash: NDXCFWB5NCI3OEBSJA2ZFNUDD2MVMNSP X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Dom Rodriguez writes: > crosvm was producing warnings when using `--vhost-user-gpu` and > `--vhost-user-fs`, of which the former is fixable, but the latter > requires some more work. The latter will be patched later on. > > To mitigate the former, I have adjusted the `crosvm` invocations to look > something like `--vhost-user $DEVICE,socket=3D$PATH`, where `$DEVICE` is, > in this case, `gpu`, and `$PATH` is the path to the Unix socket. > > Signed-off-by: Dom Rodriguez > --- > img/app/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/img/app/Makefile b/img/app/Makefile > index 7c3e3e8..db9fbea 100644 > --- a/img/app/Makefile > +++ b/img/app/Makefile > @@ -167,7 +167,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-= user-gpu start-virtiofsd > -p "console=3DttyS0 root=3DPARTLABEL=3Droot" \ > --net tap-name=3Dtap0 \ > --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ > - --vhost-user-gpu build/vhost-user-gpu.sock \ > + --vhost-user gpu socket=3Dbuild/vhost-user-gpu.sock \ [2024-11-08T11:12:36.503808752+00:00 ERROR crosvm] arg parsing failed: Erro= r parsing option '--vhost-user' with value 'gpu': missing field `socket` Is the space between "gpu" and "socket" supposed to be a comma, like in your commit message? > --vsock cid=3D3 \ > --serial type=3Dfile,hardware=3Dserial,path=3Dbuild/serial.log \ > --serial type=3Dstdout,hardware=3Dvirtio-console,stdin=3Dtrue \ > --=20 > 2.44.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCZy3yoAAKCRBbRZGEIw/w ogzvAQDeYxvyZ2vdlv+LGb0c9o6kwKdox7S1ztRtNJfbXAdG9gD7BhGOuW9VW8jH Xjn9Y2H3bh5yyZJ3QF6pykzRoX4gTg8= =q6Y7 -----END PGP SIGNATURE----- --=-=-=--