From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 79223FCCD; Mon, 21 Oct 2024 09:08:26 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 9BC40FCA3; Mon, 21 Oct 2024 09:08:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DMARC_MISSING, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) by atuin.qyliss.net (Postfix) with ESMTPS id 12EE3FCA1 for ; Mon, 21 Oct 2024 09:08:20 +0000 (UTC) Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id C68111140220; Mon, 21 Oct 2024 05:08:17 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Mon, 21 Oct 2024 05:08:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1729501697; x=1729588097; bh=4dNvZ+hNa3 d11AajXGOPOuBeyBGPsRqVp6QTr49x8O4=; b=TqYTF3Ak75kJPa0EtvjPb7wkEC u+xNwtJFg9toVlnixkjPINhfiRVMZKouR/DklOQ0373f4vDlKQrkAxeVOW+Curuv NNeJTAMBeUIbq0wOXdWTcCup0HlJMtElPcbQfFGOOuF31Ktxn2lBvj428ktXat+S pwmTQmo4yMQVTfAp7WV4aihWlZitzUCMbSQRehNjyclr8NXCouNLpz+dCH4z6R6D AGo4oDUbRWFLWC7Re5DNkKwaqvGQsW6Cy+PTAGlkf68/KgGyvuoARV1M6TVb3pZt bOZ/R40YB8eQXKL/pRlC8i3c2C7eCNhtx4zUBAfAtR/FVySe8+eEHk58Y5jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1729501697; x=1729588097; bh=4dNvZ+hNa3d11AajXGOPOuBeyBGP sRqVp6QTr49x8O4=; b=gIhtEiacM/0k+NgR3sYrB00K28vsDnRs8CppnN7pOTm1 hAhXDBb50jHVdEBP812hEQSc044ayXNIOYFltHj7rKJDKHvDaC+7RfCmA5fY/iqb svCA1nsmcp2LTT9f8hc7JFUzQ48GO0GG8O4AhdZpN9c5d73DcLhzNQfDKm9Cwu4d POoy8uR12QA3kF7ojv9Y1NMvUnnZBhhZGQPO5jyLUaZo9+vvjO8n6hFJwALGGE6L s+6gJ9fYVxBa6J+bDdUfEm1gyrFGGNdAnasJXJpCa5jrLWgjV3NhVWnEQA23WgUM 0ftxrtFDfCbGRBjCOQVVlUlOjqi5FJcCiep1MYOm/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehledguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf gjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehh ihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuieelgfetgfdttd dtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprh gtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehshhihmhgvghgr sehshhihmhgvghgrrdhorhhgrdhukhdprhgtphhtthhopeguvghvvghlsehsphgvtghtrh humhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Oct 2024 05:08:16 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id 786293828AE6C; Mon, 21 Oct 2024 11:08:14 +0200 (CEST) From: Alyssa Ross To: Dom Rodriguez Subject: Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args In-Reply-To: <7nuyrpnpikc7ctg54yupkv72wdk2ckaqwbexfjtz3bnmxlvkoj@qhrjrshiotxh> References: <20240906224329.2336996-1-shymega@shymega.org.uk> <877cbnfmdf.fsf@alyssa.is> <87bk07am4z.fsf@alyssa.is> <7nuyrpnpikc7ctg54yupkv72wdk2ckaqwbexfjtz3bnmxlvkoj@qhrjrshiotxh> Date: Mon, 21 Oct 2024 11:08:12 +0200 Message-ID: <875xpl962r.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: DVK3GEZ64UYBDHDIHCQRCRHPZ34CRCAF X-Message-ID-Hash: DVK3GEZ64UYBDHDIHCQRCRHPZ34CRCAF X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Dom Rodriguez writes: > On 28.09.2024 16:27, Alyssa Ross wrote: >> >>You're right! I've just spent the last little while looking around >>trying to figure out what's up here, and I think I've figured it out. >> >>In this commit[1] they made the vhost-user-fs tag optional, because it >>can now be set with virtiosfd instead of the VMM. This is probably >>good, because the more generic vhost-user becomes, the more hope >>Spectrum has of one day not needing Cloud Hypervisor patches. :) So we >>could try using --vhost-user fs for crosvm, and then passing --tag to >>virtiofsd, but it'd need to be tested with VMM=3Dqemu and >>VMM=3Dcloud-hypervisor as well, because I'm not sure whether they support >>a backend-provided tag. > > Oh, that explains *a lot*! I agree, a generic approach would be > preferable. > >>If that's too much work, I'd also be happy to apply just the GPU part of >>this patch. Just let me know. :) > > I've started a new job, and so I've only really got weekends free - and > even then, I have Repair Cafes to volunteer at.=20 > > If I send over the GPU patch only, can you apply that, and then we can > discuss on Matrix/IRC the best approach for `vhost-user-fs`? Feel free > to tag me - I'm mostly using IRC rightn ow. SGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmcWGfwACgkQ+dvtSFmy ccAcQQ/9GqEBb5yuNUW3Lc+2NLKRV9e3sn856wDfsbJyTGV6slDKSwxwdeyZlWnR 6fIThseGI9ZC32JCkBoxrYAj6BnPHboW9jcrmNSicnsNWYNTu+NaTEvkP9p0qy+f 6vYLbVvq8Yo+c3VTM0tiK+b8ilDCTiZ8DSDpUf49mMFmbdnImamaffNzUd+FM2Wr iV/5W7H3GSAOlPoCzDPFPAaA13JYbaeCjqMVTT7U5Q4Zszgrl3auDipS2Tp1Xf+i WxRpvqMBqCwO6P45q9vc3wmTd9m7YLP24AzLwEiLCCK524uaV/o6exMz629Ya3dK N0RchckvUkeWouchfW9ooF/dm2Xq2kG23QYiy2abB0LqpTR2xgCWWNa6+CvWdn4Q 0u4PP/lj4Yl1KykJVAKS4sZdCCsfc7t/XrDH8GcciP2eBkhx3h9F3jhRPYW/qe1d J0G1TE27jgxCOOYrodhhGobsTBWpRHiJffsby6JGi2DW4h2iu63+6S0e8pZx4plO BZhv6Vvr8QVsQ6y+FQza5+hTWEzJB5IBB5Vy0OyhSgeMHv84krfTgKBqgpxUl34u ERXEsP3iKumRhigzrOnKjdokZUiDX2H0tVdjxTmaKlJI4l8Jo+TMDDghf5CDga9x eY7pUr4uMtF9vgwpwjytwJbK2LUTjGNuHmqDtu21rQjcsAPPBxE= =92Cw -----END PGP SIGNATURE----- --=-=-=--