From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 84FEC1963D; Mon, 08 Sep 2025 08:23:24 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 4B23D19633; Mon, 08 Sep 2025 08:23:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) by atuin.qyliss.net (Postfix) with ESMTPS id 96D9019631 for ; Mon, 08 Sep 2025 08:23:21 +0000 (UTC) Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 7CA331D0013B; Mon, 8 Sep 2025 04:23:20 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Mon, 08 Sep 2025 04:23:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1757319800; x=1757406200; bh=LAzkrjb1eG F/AY31HbHxtll2HLtcYd68iqY8WXPIdjc=; b=jeAxbEX6GeqpkmEKGXGJrTzHMj gdBSQxRUaHnaDpVkdDeXV5SaZFEfw8GG6Ewilx5BmiJ8MpiW0pfJ2jZXunNBVOOV +FmIUcG3ysChxrQPrRgKSgmRqUaKC2dGR4hZ/V5VEdGyNbAtTcneu/nIORy9GtHT SNYmOsYDsB9wVkHpzqJJ/3A5fLcCPrW4hmNwMnkpYrEK279e++av8dBV+hVcgW9h O3UOBf+L5TDpZt04ixIBLFpPsunh+TRBb5X4E/uTS81eSSWDRIDUsJZyJoISaEvy H4NL0Zk55nwzw2Ne32adp/iNtzs2vjQ7woMBUCXSh1fmsY0XfnRHaoGIba2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1757319800; x=1757406200; bh=LAzkrjb1eGF/AY31HbHxtll2HLtcYd68iqY 8WXPIdjc=; b=XFltMX6mkLpQ6E33NVWRlDHGbZL/IMRSvJ3eypmuIrTTkSkZ6S9 AMWvZ/hxLwDK0ggPij2FnIFo+9h4Jnuu2oLMIN/MBjHoxwxbCinuMpitIoKS1sU8 GKUX2XbHFZC4sT62AB/IiN/jfgWYrALG2zUwXpSwAl8EtDJM/HA66NMAqYsyXPEL yXb1mD4RG1PkevSj6QDZ6nvNL142ZueCrDnlxu0JvzEbtJSudJaqVobqRguUfTW5 gFDjZPK9yfgsp57VrWgMLL4YPNGlaHdjwKDja+nmXU2Vlvkcxp2se+IHPvnPPxCC d9NtgiWhb0JUsJ1LErW5ZNq8whpAHrgh0WQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddujedtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuie elgfetgfdttddtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 Sep 2025 04:23:19 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id C323216744DA; Mon, 08 Sep 2025 10:23:16 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 02/20] scripts/make-erofs.sh: Do not read one byte at a time In-Reply-To: <20250904-systemd-v1-2-2a63b790a913@gmail.com> References: <20250904-systemd-v1-0-2a63b790a913@gmail.com> <20250904-systemd-v1-2-2a63b790a913@gmail.com> Date: Mon, 08 Sep 2025 10:23:16 +0200 Message-ID: <877by9l5e3.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: GTWLQNLRKBVEYN5SAQCLDNIV2M7HL6R5 X-Message-ID-Hash: GTWLQNLRKBVEYN5SAQCLDNIV2M7HL6R5 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Demi Marie Obenour writes: > POSIX requires that the shell read builtin not consume any bytes beyond > the end-of-line character. For non-seekable files like pipes, this > requirement can only be met by reading one byte at a time, which is very > slow. Avoid this by reading the entire input into a temporary file and > having sh read from the temporary file. Since regular files are > seekable, sh can read many bytes and then seek back to the correct file > position. Slow enough to make a noticeable difference in the context of the whole script? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaL6SdAAKCRBbRZGEIw/w otwfAQCOO2bqVED7LBOcM/pLi+HiEv6oOgLHQAOSw92oVtZQ0AEAoxWACenFSAIj Aplf9AeLRvpz7ToZLdmOCjb2xCqb7wQ= =QdOf -----END PGP SIGNATURE----- --=-=-=--